zobo
Repos
56
Followers
18
Following
3

Events

Extended xdc tests, need to make some calls async with setTimeout so that internal dbgp logic can clean up. Removed extra logging.

Created at 6 hours ago

Added tests for connection.

Created at 8 hours ago

Refactor and tests

Created at 17 hours ago
pull request opened
feat: xdebug cloud support
Created at 1 day ago
create branch
zobo create branch cloud
Created at 1 day ago
issue comment
Step filter to skip files

No sorry, not yet. There is still no feasible way to implement this and I'm currently dealing with cloud support.

Created at 3 days ago
issue comment
"Disconnect" action missing its icon

Looks like it this here: image I don't think this has anything to do with the extension.

The arrow does not appear when debugging javascript. It's only availabe when the Capability supportTerminateDebuggee is present.

I honestly don't remember if it was there, but seems this is a issue for microosft/vscode

Created at 6 days ago

fix: replace Sabre\Uri with Path (#31)

  • Move phpunit launch to random xdebug port.

  • Do not use Sabre\Uri as is started adding a / in front of Windows paths (https://github.com/sabre-io/uri/issues/81).

Created at 2 weeks ago
pull request closed
fix: replace Sabre\Uri with Path
Created at 2 weeks ago
issue comment
Parsing Windows file:/// URIs is now broken

I think some implementations will treat file:///X:/... as a special case. Like .NET for example https://dotnetfiddle.net/lIMLo0 others will not https://go.dev/play/p/I8ekrHTEUkB

I bet al lot was written about it, like this for example: https://github.com/golang/go/issues/6027#issuecomment-66083310

Node has a function that will produce "expected" results, but specifically for paths https://nodejs.org/api/url.html#urlfileurltopathurl

I've bumped into similar problems before https://bugs.xdebug.org/view.php?id=1964

All in all, the change is probably correct and native PHP behaves wrong. I was just bothered that this happened on a patch level version change. But what's done is done, it would probably be worse to revert it now.

I would however suggest that this be explicitly noted in README, where the clame is:

  1. parse, which works like PHP's parse_url.
Created at 2 weeks ago
pull request opened
fix: replace Sabre\Uri with Path
Created at 2 weeks ago
create branch
zobo create branch fixes
Created at 2 weeks ago
opened issue
Parsing Windows file:/// URIs is now broken

I did a minor upgrade on https://github.com/zobo/php-language-server and and after spending hours on debugging why a whole lot of things stopped working realized that Release 2.2.3 with #71 changed how Windows file URIs are parsed.

Now instead of getting path: C:/dir/... we get path: /C:/dir/....

I have looked into a few different issues here to figure out why this would be OK, but I'm sorry, this is a breaking change and should have been released under a new major version.

Created at 2 weeks ago

fix: resolve variable assignment in current node, type resolve in assignment expression (#30)

Created at 2 weeks ago
pull request closed
fix: var resolving, assignment type resolving
Created at 2 weeks ago
issue comment
Check why parent::func() is not resolved

Fixed in #29 will be released soon.

Created at 2 weeks ago
pull request opened
fix: var resolving, assignment type resolving
Created at 2 weeks ago
create branch
zobo create branch var-resolve
Created at 2 weeks ago

feat: inherit traits and fix parent::method resolving (#29)

  • Extend class definition with traits.

  • Fix wrong resolve "parent" to class. Handle special call parent:: to non-static method.

  • Add missing reference in test due to fixed parent::method resolving.

Created at 2 weeks ago
pull request closed
feat: inherit traits and fix parent::method resolving
Created at 2 weeks ago

Add missing reference in test due to fixed parent::method resolving.

Created at 2 weeks ago
pull request opened
feat: inherit traits and fix parent::method resolving
Created at 2 weeks ago
create branch
zobo create branch traits
Created at 2 weeks ago

chore: warn that STDIO is not possible on Windows (#28)

Created at 2 weeks ago
pull request closed
chore: warn that STDIO is not possible on windows
Created at 2 weeks ago
pull request opened
chore: warn that STDIO is not possible on windows
Created at 2 weeks ago
create branch
zobo create branch stdio
Created at 2 weeks ago
go to definition not showing in menu

I can use vscode remote and this extension just fine. Check the Panel, Output and then select PHP Language Server on the right. See if there is any output.

See if it helps if you set the php.executablePath setting (but be sure to select either remote, remote user or project local).

Created at 2 weeks ago
issue comment
Check why parent::func() is not resolved

The problem is that functions get stored in the index either as Namespace\Class->func() or Namespace\Class::func() depending on if they are not static or static defined. When making a parent::func() call the parses can't figure out if it's looking for a static method or a non-static method.

Maybe try both?

Created at 2 weeks ago
go to definition not showing in menu

I don't think this is correctly implemented.. Opened and issue: https://github.com/zobo/php-language-server/issues/27

Created at 2 weeks ago