Add ASCII art to README

Add getBuildCost endpoint

Taken from LT75.

I'm still seeing this issue in RC2, MacOS.

Add more core unit tests

Refactor function to apply bonus as an accumulator, not a multiplier

Add ACSII startup logo

Bug fixes

Move ruleset switching to a separate module

Added unit tests and found bugs.

General:

• Added gingko unit tests for core module.
• Move validation function into ruleset module and changed name to PopulateInput()
• Changed several function params to pointers.

In core.go

• Removed error return value from GetStats() function.
• Added unit class exception to fortress bonus.
• Added defence bonus for airbases.
• Changed river bonus from 1.5 to 1.25.

Implement movement point penalty

Add Dockerfile

Add getTerrain and getUnits endpoints

Remove underscore from class names in LTX rulesets

Add JSON tags to CombinedResults struct

Describe the bug Under the LT75 ruleset, and only under that ruleset as far as I can tell, the National Budgetdialog box is not unique. Clicking repeatedly on the tab opens multiple windows. I've observed this both in the online LT75 game as well as in an offline game with the LT75 ruleset, but not in LT76 or in an offline game with the default ruleset. Also, those boxes don't clear when you leave the game.

To Reproduce

• Log into the current LT75 game, or create an offline game with the LT75 ruleset.
• Click on the National Budget tab multiple times. You should see several boxes appear, that will all need to be closed individually.

Expected behavior The clicking several times on the National Budget tab only ever opens 1 dialog box.

Screenshots

Platform and version (please complete the following information):

• MacOS 12.6
• Freeciv21 version: V3-RC1
• Ruleset/Longturn game (if applicable): LT75

Add missing LTX classes to switch cases

Add formatting to calculate results

Add combat results to attack endpoint

Implement Great Wall bonus

Fix various issues with warcalc module

Add partially working port of LT warcalc algorithm

Fix capitalisation of validation error message

Fix conversion error in GetTerrainBonus() function

Add initialisation of 2D structs

Fix typo in validateInput function

Replace all float32 and uint8 types with float64 and int respectively

Add original Python and Go port of Longturn warcalc function

Thanks for the extra details. I also notice that at no point do you see Temple of Artemis in the popup. @lmoureaux @wieder-fi is this caused by an issue in the ruleset or something buggy in the game client?

I've already raised this as a separate issue: https://github.com/longturn/freeciv21/issues/1656

Artemis Glitch.sav.gz

After some further testing, I have been able to reproduce this in an offline game. These are screenshots from an offline game using LT75 rules using some manipulation of the save file to save time (hence why I have so much gold). This city has a temple while the Temple of Artemis has already been built in another city, so I should see four content civilians from buildings. Note that the bonus from Artemis does not show in the tooltip. I've raised this as a separate issue.

CG preset selected. Note that only two citizens are being made content from buildings.

CG preset disabled. Still only 2 content.

Deselecting 1 tile fixes the issue, and it stays fixed after reselecting. Now we have 4 citizens content from buildings, as expected.

After re-enabling the preset, the bonus is still there. ¯_(ツ)_/¯

But I'm back to two if I disable it.

The four content citizens after re-enabling the governor seems to be a visual glitch. With this same city, I can manually get +11 food, though I need the Temple of Artemis bonus for public order.

But a "max food" preset can only manage +9 food, even though it seems to be applying the bonus.

Disabling the preset reverts the visual back to 2 content citizens, but doesn't change the values, showing that the preset wasn't actually applying the bonus.

This issue still exists in V3-RC1.

Describe the bug The Temple of Artemis bonus is not applied when selecting a CV preset in LT75.

To Reproduce I can only see this bug in LT75. I tried to replicate the same issue in a local game with LT75 rules, but it did not appear.

In LT75, with the citizen governor and citizens tabs open, if I have a preset selected I can see that I'm only getting 2 content citizens from buildings in cities with a temple. Disabling the governor does not fix this, but by manually changing the city workers, the bonus kicks in and buildings now provide 4 content citizens. Selecting another preset disables this issue again

Expected behavior With a temple and Temple of Artemis in a city, buildings should provide 4 content citizens with the governor preset enabled.

Screenshots As this is an on-going multiplayer game, I will only provide screenshots privately through Discord upon request.

Platform and version (please complete the following information):

• MacOS 12.6
• FC21 Beta 7

Remove unnecessary line

Add LTX and LT75 rulesets

Add LT76 ruleset

Is your feature request related to a problem? Please describe. The General tab of the city production windows show various breakdowns of the stats such as corruption penalties, government bonuses, etc. One piece of information missing from this is the luxury bonus from small wonders like the Hypogeum or Hanging Gardens. These bonuses show up in the stats, but not in the tooltip, so there's no explanation of where the luxury bonus comes from.

Describe the solution you'd like Adding data to the tooltip indicating where the luxury bonus comes from would make it clear what is contributing to that bonus.

Additional context This is a screenshot from a local game with the LT75 ruleset of a city with the Hypogeum and Hanging Gardens built. The luxury value is 10, which is correct, but there's no information in the tooltip saying where this value is coming from. Logically it should say +6 from the Hypogeum and +4 from the Hanging Gardens.