Thanks:)
I've already signed the CLA several times with the correct email address of my commit (wonseop.kim@samsung.com). I will send the CLA pdf file to your email if you need it.
Condition 'isLoadingMessage' is always true at this point because it has been already checked at line 348. This patch removes the unnecessary condition statement.
Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.
Remove or strikethrough items that do not apply to your PR.
withEuiTheme
need to pass true
as the second argument to its propUtilityForPlayground
in src-docs/src/views/{component}/playground.js
)
shouldRenderCustomStyles()
test was added and passes with parent component and any nested childProps
(e.g. tooltipProps
)mount()
ed snapshots in favor of render()
or a more specific assertion
$euiSize
to euiTheme.size.base
)calc()
to mathWithUnits
if possible (if mixing different unit types, this may not be possible)@warn
deprecation message within the global_styling/mixins/{component}.scss
filesrc/components/index.scss
src/amsterdam/overrides/{component}.scss
files (styles within should have been converted to the baseline Emotion styles)
euiCanAnimate
gap
property to add margin between items if using flex-inline
and -block
logical properties (check inline styles as well as CSS)
euiComponent
, euiComponent__child
){euiComponent}-
(case sensitive) to check for source code usage of modifier classesdata
attribute so that consumers still have something to hook into
**/target, **/*.snap, **/*.storyshot
for less noise) for eui{Component}
(case sensitive) to find:euiBadge
class on a div instead of simply using the EuiBadge
component)
.js
docs files to TSfrom '../src'
, replace <React.Fragment>
with <>
)[EuiAccordion] Remove a unnecessary condition statement
Condition 'isLoadingMessage' is always true at this point because it has been already checked at line 348. This patch removes the unnecessary condition statement.