Can this function be implemented? Because I found that when I mount config.user.inc.php on the host as a volume, when I use vim to edit config.user.inc.php, then the container will find The name and attributes of the file become a bunch of question marks, and if you want to view the file in the container, there will be a stale file handle error. I think using conf.d can avoid this problem.
For sure, I would like to have it too. You can send a PR for it before someone has the chance to do it This file is probably the one that should be edited: https://github.com/phpmyadmin/docker/blob/0006406e352ddd5addd5122de53fe354307b2460/config.inc.php#L159-L161
I did some research, and the code has been like this since 10 years or near to ever. See 30e0e3648d90f349a119d9f53c94230fb7675210 that changed it a bit.
Or did I mis understand the logic ?
Here is the 2008 initial implementation: https://github.com/phpmyadmin/phpmyadmin/commit/c28818ecee0743e799b60df755b91f3f3b3b6972#diff-9260a516a07596bd0bc2e1e7a636b3af2e6fd9b7edfa1a3b7d46415ad5121359R64 it was renamed since then in https://github.com/phpmyadmin/phpmyadmin/commit/41ddd1cc6a048261b98fa8636ef0c07cf00eb747
Hi @mapreri
Can you hard reset your PR branch onto QA_5_2
and then cherry-pick the commits and force push ?
So this PR target can be edited and sent to 5.2.
Please do not close it or open a new one :)
I think that after that it's ready for a merge into 5.2. And QA_5_2
will be merged into master.
Or, this bug is not present on 5.2 versions ?
Update the psalm baseline
Change Component
abstract class to an interface
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Merge pull request #365 from mauriciofauth/component-interface
Change Component
abstract class to an interface
Replace @final
annotation with the final
keyword
Related to #271 and #362.
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Bump PHP minimum version to 7.2.5
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Remove Context::load call from the Context file
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Merge pull request #366 from mauriciofauth/php72
Bump PHP minimum version to 7.2.5
Merge pull request #367 from mauriciofauth/context-load
Remove Context::load
call from the Context
file
Merge branch 'master' into 6.0.x
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Rename class members to use camel case format
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Merge pull request #368 from mauriciofauth/members-camel-case
Rename class members to use camel case format
Merge branch 'master' into 6.0.x
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Add string return type to Component::build
methods
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Use class-string type where possible
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Refactor Context
class
Improves readability of some methods.
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Merge branch 'master' into 6.0.x
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Merge branch 'master' into 6.0.x
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Merge branch 'master' into 6.0.x
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch 'master' into 6.0.x
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch 'master' into 6.0.x
Signed-off-by: William Desportes williamdes@wdes.fr
Change error handling to returning a boolean value
In case an error occurs during loading of a context, let the Context::load() method return a boolean value indicating whether the context was successfully loaded or not. Throwing an Exception causes a false positive in debuggers,since the Context::load() method does the correct thing anyway
Add phpbench
Signed-off-by: William Desportes williamdes@wdes.fr
Adjust .gitattributes
Signed-off-by: William Desportes williamdes@wdes.fr
Add GitHub workflow
Signed-off-by: William Desportes williamdes@wdes.fr
Drop PHP 7.1 support
Signed-off-by: William Desportes williamdes@wdes.fr
Try to fix #404. Miss some unit tests.
Use the contextGenerator to rebduilf the contexts.
Add some unit tests.
Fix context generated as events have been added on MySQL 5.1.6 and not before.
Re-generate out files about ALTER EVENT tests.
Remove useless flag "EVENT" in case of ALTER EVENT parsing.
Install infection using shivammathur/setup-php
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #408 - Fix #404 - Implement ALTER EVENT
Fixes: #404 Pull-request: #408
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #404
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #352 - Add phpbench and drop PHP 7.1
Pull-request: #352
Signed-off-by: William Desportes williamdes@wdes.fr
Fixing the alter operation table options
Signed-off-by: Fawzi Abdulfattah iifawzie@gmail.com
Adding the alter test to the provider
Signed-off-by: Fawzi Abdulfattah iifawzie@gmail.com
Merge #410 - Fix #405 - Fixing the alter operation table options
Pull-request: #410 Fixes: #405
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #405
Pull-request: #410 Ref: #405
Signed-off-by: William Desportes williamdes@wdes.fr
Adjust phpbench expectations and remove progress mode for GitHub actions
Signed-off-by: William Desportes williamdes@wdes.fr
Update baselines
Signed-off-by: William Desportes williamdes@wdes.fr
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/17654
Also: ALTER USER 'public'@'%' IDENTIFIED WITH mysql_native_password BY '***'
Fix management of ALTER USER when used with IDENTIFIED WITH option
Merge remote-tracking branch 'phpmyadmin/5.8.x' into fix/alter-user-identified-with
Support IDENTIFIED VIA in CREATE/ALTER USER statements
Merge #436 - Fix #431 - management of ALTER USER when used with IDENTIFIED WITH/VIA/BY option
Pull-request: #436 Fixes: #431
Signed-off-by: William Desportes williamdes@wdes.fr
Add more test cases for user IDENTIFIED WITH/VIA/BY
Ref: https://github.com/phpmyadmin/sql-parser/pull/436#discussion_r1148354982
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch '5.8.x'
Update .out files after #436
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #431
Pull-request: #436
Signed-off-by: William Desportes williamdes@wdes.fr
Ref #360 - load the default context to avoid side effects
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch '5.8.x'
Remove not needed anymore ascii workaround
Ref: 62533e808aaa59465511ed8a1fa0388c69bf918e
Signed-off-by: William Desportes williamdes@wdes.fr
Remove the project root path from .out files
Signed-off-by: William Desportes williamdes@wdes.fr
Apply JSON_UNESCAPED_SLASHES on .out files
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch '5.8.x'
Remove not needed anymore ascii workaround
Ref: 62533e808aaa59465511ed8a1fa0388c69bf918e
Signed-off-by: William Desportes williamdes@wdes.fr
Remove the project root path from .out files
Signed-off-by: William Desportes williamdes@wdes.fr
Apply JSON_UNESCAPED_SLASHES on .out files
Signed-off-by: William Desportes williamdes@wdes.fr
Found it, probably caused by this PR. Fixed by 3cf7606ad351abc687f6aed0c227536846cb5065
Ref #360 - load the default context to avoid side effects
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #431
Pull-request: #436
Signed-off-by: William Desportes williamdes@wdes.fr
Looking at 2b92a492aa885667736d340252d4442b0152cee4 There is some stuff to add to remove the new errors
I now have some weird diffs in stage on full re-build
rm -r ./tests/data/**/*.out
./tools/run_generators.sh
Do you also have them ?
This fix is linked to following issues:
Fix management of ALTER USER when used with IDENTIFIED WITH option
Merge remote-tracking branch 'phpmyadmin/5.8.x' into fix/alter-user-identified-with
Support IDENTIFIED VIA in CREATE/ALTER USER statements
Merge #436 - Fix #431 - management of ALTER USER when used with IDENTIFIED WITH/VIA/BY option
Pull-request: #436 Fixes: #431
Signed-off-by: William Desportes williamdes@wdes.fr
Add more test cases for user IDENTIFIED WITH/VIA/BY
Ref: https://github.com/phpmyadmin/sql-parser/pull/436#discussion_r1148354982
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch '5.8.x'
Update .out files after #436
Signed-off-by: William Desportes williamdes@wdes.fr
Please close this one and send it to the official repo: https://github.com/net-snmp/net-snmp
Please close this one and send it to the official repo: https://github.com/net-snmp/net-snmp
Please close this one and send it to the official repo: https://github.com/net-snmp/net-snmp
Please close this one and send it to the official repo: https://github.com/net-snmp/net-snmp