vlakoff
Repos
79
Followers
61
Following
41

Events

pull request opened
Revert "Consider brackets within wildcard as regular characters"

I'm opening this PR to make sure the broken #16965 doesn't land into 4.5.0 release.

As spotted by @tristanleboss, and as I confirmed too, the implementation appeared to be broken. See https://github.com/qbittorrent/qBittorrent/pull/16965#issuecomment-1263084823 and following.

Until the implementation is fixed, or better, an UI letting optionally use the wildcards is implemented (see https://github.com/qbittorrent/qBittorrent/pull/9255#issuecomment-1263081969 and following), it should be reverted.

Created at 1 day ago
create branch
vlakoff create branch revert_escape_brackets
Created at 1 day ago
issue comment
Consider brackets within wildcard as regular characters
  • On qBitorrent 4.4.5, I can type « [[] » to manually espace a « [ » character. So the Qt Wildcard matching seems to work with such nested brackets, and I'm not sure the second explanation from my above message is the cause.
  • The WildcardUnix mode, from the initial implementation of wildcards in filtering, later got replaced with Wildcard mode (see #14546, precisely here, see also #6369), so we can no longer escape the brackets with a backslash.
Created at 4 days ago
issue comment
Add option to use regexps in the transfer list's search filter's context menu

Some other nitpicks:

  • Of course, the dropdown arrow should be at the far right of the input, i.e. at the right of the "clear search" icon.
  • There should be some spacing between the search input and the lock UI icon, because inadvertently clicking on that icon opens an annoying modal dialog (closing it requires moving the mouse or pressing Escape).
Created at 4 days ago
issue comment
Add option to use regexps in the transfer list's search filter's context menu

As I posted on https://github.com/qbittorrent/qBittorrent/pull/16965#issuecomment-1263130130, I'm afraid the brackets issue couldn't be fixed.

Thus, your suggestion would be the best solution by far.

  • Plain Text (default mode, doesn't bring any surprise)
  • Wildcards (without trying to escape the brackets) (power users could still even escape the brackets in the search input)
  • Regular Expression
Created at 4 days ago
issue comment
Consider brackets within wildcard as regular characters

I can think of two explanations:

  • Overlapping occurs during the regex replacement of [ and ] with [[] and []], so that the resulting brackets get replaced again.
  • The Qt Wildcard matching gets confused by the [[] and []] and doesn't handle them as expected.

The former could be ruled out by trying a code such as:

escapedPattern
    .replace(u"["_qs, u"PLACEHOLDER_LBRACKET"_qs)
    .replace(u"]"_qs, u"PLACEHOLDER_RBRACKET"_qs)
    .replace(u"PLACEHOLDER_LBRACKET"_qs, u"[[]"_qs)
    .replace(u"PLACEHOLDER_RBRACKET"_qs, u"[]]"_qs);

But I believe the issue is the latter, which sadly couldn't be easily fixed.

Thus, I'd suggest to revert this PR, and to implement the great suggestion from https://github.com/qbittorrent/qBittorrent/pull/9255#issuecomment-1263081969.

Created at 4 days ago
issue comment
Add option to use regexps in the transfer list's search filter's context menu

I agree such a dropdown arrow would be a great enhancement.

Maybe just put Plain Text at top, so the order would be Plain Text / Wildcards / Regular Expression (order from simplest to most complex).

But if the square brackets issue is solved (https://github.com/qbittorrent/qBittorrent/pull/16965#issuecomment-1263084823), I don't think the Plain Text mode would be very useful, as the Wildcards mode could be used for plain text searches as well.

Created at 4 days ago
issue comment
Consider brackets within wildcard as regular characters

Many thanks for reporting this. I just tried 4.5.0beta1, both Qt5 and Qt6 versions, and I confirm it doesn't work on both…

It would be really great if someone were able to determine the cause of the issue. Otherwise, let's take the opportunity it's still in beta stage and revert this change for the time being.

Created at 4 days ago
Don't enable "show only one entry per found line" by default

Related: #12023

Created at 1 month ago
Don't enable "show only one entry per found line" by default

It's not about liking the mode or not. The issue is that this mode can lead the user to trouble (miss results) if he is not aware of it.

Created at 1 month ago
Don't enable "show only one entry per found line" by default

Per https://github.com/notepad-plus-plus/notepad-plus-plus/pull/11808#issuecomment-1212701012:

Although this new mode can be useful, I think the setting shouldn't be enabled by default.

It makes very easy to overlook that an entry occurs several times on a same line. There is no hint that a line contains several matches, apart from the highlights that the user has to look for. Actually, for long lines that don't fit on screen width, there is no hint at all, unless the user horizontally scrolls the results pane while looking for the highlights...

Created at 1 month ago

Don't enable "show only one entry per found line" by default

Signed-off-by: vlakoff vlakoff@gmail.com

Created at 1 month ago

Don't enable "show only one entry per found line" by default

Signed-off-by: vlakoff vlakoff@gmail.com

Created at 1 month ago

Allow custom URL schemes

Fix #9155, close #9190

Add GUI in preferences dialog for adding URI customized schemes

And add default supported url schemes. Related: 5168bdb and #9155

Close #9195

Fix function list is empty with new user profile issue

The new behaviour of loading function list will be:

  1. For the installer package: Try to load from %APPDATA%\Notepad++\functionList, if it failed, then load from %PROGRAMFILES%\Notepad++\functionList. In this way, users can override function list in %APPDATA%\Notepad++\functionList\ manually. Otherwise, function list won't be empty.

  2. For the portable package:

  • with doLocalConf.xml : Load always from <Notepad++ Dir>\functionList\
  • without doLocalConf.xml : Try to load from %APPDATA%\Notepad++\functionList, if it failed, then load from <Notepad++ Dir>\functionList\

Fix #9134

Folder as Workspace: Change folder images after "Expand/Collapse All"

Folder images are changed in FileBrowser::notified() when TVN_ITEMEXPANDED is recieved. This works fine when e.g. expand/collapse using "+" button. However, when foldAll() or expandAll() are called on a TreeView, the TVN_ITEMEXPANDED is not sent. The reason is that TVIS_EXPANDEDONCE flag is set. To reset that flag, it would be needed to pass TVE_COLLAPSERESET to TreeView_Expand that also removes all child items which is unwanted.

Resolve the problem by notifying TreeView parent manually when recieve TVM_EXPAND and TVIS_EXPANDEDONCE is set.

Fix #8912

Update the build instructions

  1. Add Visual Studio 2017 to Pre-requisites section.
  2. Add link to community forum with more details about the build process.
  3. Restructure Scintilla build instructions. Move common build steps upper.
  4. Add more details about the Developer Command Prompt for Visual Studio.

Fix #9087, fix #5566, close #9192

Fix find in files failure issue due to directory path with leading/trailing spaces

Trim spaces on Directory for FindInFiles to fix such issue.

Fix #9199, close #9208

Create new Margin/Border/Edge sub-page in Preferences

  1. Add Margins/Border/Edge sub-page in Preferences dialog
  2. Update Preferences dialog sub-page naming

Close #8896, close #9218

Fix command line arguments -p, -n & -c negative value's undefined behaviour

The negative values of these 3 arguments won't be undefined anymore. They will be rejected - so negative values are just ignored.

Fix #9146

Add an option for displying constant line number width

  1. Add an option for displying constant line number width in Preferences dialog. This option set the line number constant width according the total line number in the document (minimun 4 digits). It ensures no unexpected visual effect while scrolling content vertically. If the document content is modified and the total number of lines is increased or decreased, more digits will be added or removed according the number of digits in total number of lines.

  2. Add new plugin messages NPPM_GETLINENUMBERWIDTHMODE & NPPM_SETLINENUMBERWIDTHMODE for getting or setting LINENUMWIDTH_DYNAMIC / LINENUMWIDTH_CONSTANT. So plugins may send NPPM_SETLINENUMBERWIDTHMODE message with LINENUMWIDTH_CONSTANT to Notepad++ for avoiding some unexpected visual effect (while scrolling).

Fix #5670

Fix menu check marks not being removed after closing the panels

For both "Clipboard History" and "Character Panel" panels.

Fix #9216

Update taiwaneseMandarin.xml

Close #9236

Make "Line" preceding each line number on Search Results translatable

Fix #9224

Fix Search result line number highlighting inaccurate issue

Enhance localization of "Line" of Search result

This enhancement translates "Line" prefix of Search resulton when user change each time the localization.

Inspired from #9233

Remove obsolete code

Fix dockable panels display issue in RTL direction

Fix #9241

Make the text direction of search result window follow the direction of main edit zone

and the text direction of function list always LTR.

Make the text direction of finder's search result follow the main edit zone's one

Fix Search result's text direction not always synchronized with main edit zone's one issue

Fix a typo

Fix #9259

Created at 1 month ago
vlakoff create branch search_results
Created at 1 month ago
Add an option allows to show only 1 entry per found line in search result of find in files

Although this new mode can be useful, I think the setting shouldn't be enabled by default.

It makes very easy to overlook that an entry occurs several times on a same line. There is no hint that a line contains several matches, apart from the highlights that the user has to look for. Actually, for long lines that don't fit on screen width, there is no hint at all, unless the user horizontally scrolls the results pane while looking for the highlights...

Created at 1 month ago
Is "elements" really a special word in JavaScript?

When writing some JavaScript code, I wanted to name a variable elements, and noticed it got emphasized (as a special word).

After some research, I found nowhere such an identifier/property exists (ECMA, JavaScript, browser environment...). The only place I found a gleam of it, is on this webpage: https://www.w3schools.com/js/js_reserved.asp.

If it is confirmed this is not a reserved/special word actually, it would be great to remove it from the "langs[.model].xml" file.

Created at 2 months ago
Is "elements" really a special word in JavaScript?

Nevermind, I just found it: https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/elements.

The HTMLFormElement property elements returns an HTMLFormControlsCollection listing all the form controls contained in the <form> element.

Created at 2 months ago
Is "elements" really a special word in JavaScript?

When writing some JavaScript code, I wanted to name a variable elements, and noticed it got emphasized (as a special word).

After some research, I found nowhere such an identifier/property exists (ECMA, JavaScript, browser environment...). The only place I found a gleam of it, is on this webpage: https://www.w3schools.com/js/js_reserved.asp.

If it is confirmed this is not a reserved/special word actually, it would be great to remove it from the "langs[.model].xml" file.

Created at 2 months ago