182
667
Events
fix: 1065 query filter for in with keys test
val in Property Filter is of type any
As discussed it should probably be unknown instead.
Are these definitely the only two cases with which we can expect users to filter with key?
Probably. You should be able to leverage Typescript conditional types to enforce that.
1065 query filter on key with adjustment
This PR shows what the problem is but it's not a proper fix
fix temp label placement
They were misplaced for F
release 1.5.4
Change to try to ignore __key__ as it is redundant
The test failures tell us that
https://github.com/googleapis/nodejs-datastore/blob/main/src/entity.ts#L672-L675
is never taken.
Did some debugging, the root cause is that the Key in tests in a copy (i.e. not the same as) the lib Key due to the the way it's imported in test.
https://github.com/vicb/nodejs-datastore/commit/184f0ede1a897a5ae18f6d3d93bad5d7cec995ce proves it
vicb push vicb/flyxc
Load ArcGis CSS from the CDN
And only for the 3D map
Better way to retrieve modesl
Do not use the picker on mobile
Update deps
release 1.5.3
Query filter on __key__ using the "IN" operator
Hey @danieljbruce not sure who you are asking the question to?
As long as the value is guaranteed to be a key. But what if it isn't?
What's the problem here?
if you query.filter('numberField', "some string") it would just returns nothing. Why should the __key__ be any different?
(I hope I am not saying a stupid thing here - hard to context switch while I'm in a middle of other stuff)
I don't think WithUsignal is correct?
sorry for disappointing
not at all, your code is great and helpful. happy that I could contribute!
fix lit integration (WithUsignal)
fixes #30
vicb push vicb/usignal
fix lit integration (WithUsignal)
fixes #30
I don't think WithUsignal is correct?
Sorry I might not have been very clear, I'm quite new to the signal hype :)
What I am saying is that your WithUsignal implementation is incorrect.
In my original playground, if you click on "Reactive property counter" until "Late signal counter" appears
You'll see that the "++ (not working)" is not working.
The current implementation is broken each time changing an internal prop results in a different set of signals.
I'll upload a PR to fix that.
