vespakoen
Repos
185
Followers
106
Following
47

Events

issue comment
Emscripten: Fix to build with latest toolset, and merge recent commits

@verylowfreq I looked into this today.

It looks like your emscripten-develop branch has more features in it than this PR does.

And it also already seems to be rebased correctly with the current master branch.

Is there any reason for not making a PR using that branch, because if not I think it would be better to make a PR using that branch?

Over here I am getting the following warnings

emcc: warning: please replace -g4 with -gsource-map [-Wdeprecated]

And this one:

emcc:WARNING: Wasm source map won't be usable in a browser without --source-map-base

I tried compiling using -gsourcemap and --source-map-base but it was a bit hard to setup and didn't really work.

However, without those flags / in the current state I was able to get a decent stack trace with the Debug mode and a fast build in Release mode so it seems to work all right, at least for me.

Lastly, when compiling you might want to turn off some features to speed up the build:

emcmake cmake \
    -DEMSCRIPTEN="ON" \
    -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" \
    -DENABLE_OPENMP="OFF" \
    -DENABLE_LTO="OFF" \
    -DENABLE_TESTS="OFF" \
    -DENABLE_CLI="OFF" \
    -DENABLE_COVERAGE="OFF" \
    ..

And you can use the -j <NUM_CPUS> flag on the emmake make command to parallelise it:

emmake make -j$(sysctl -n hw.logicalcpu)

Hope that helped ;)

Created at 1 month ago
pull request closed
Rebased @verylowfreq Emscripten Fixes

I rebased @verylowfreq's changes from #1275 to the latest master branch over here, will review this later today.

Created at 1 month ago

Add emscripten support

Created at 1 month ago

Add emscripten support

Created at 1 month ago
pull request opened
Rebased @verylowfreq Emscripten Fixes

I rebased @verylowfreq's changes from #1275 to the latest master branch over here, will review this later today.

Created at 1 month ago
create branch
vespakoen create branch verylowfreq-emscripten
Created at 1 month ago
issue comment
Emscripten: Fix to build with latest toolset, and merge recent commits

@verylowfreq Thanks, this is awesome!

I tested out https://github.com/ruevs/solvespace/tree/rebasetest-emscripten and it worked really great!

Obviously some things are broken, but I think we should go ahead and merge those changes in and see if we can polish it up some more later.

What I noticed from a quick test:

  • Getting stuff in and out is not working yet (load file / save / export)
  • font-family for the menu's / modals could be better
  • A (1px) seperator between the main view and the property browser would be great

Once this is merged I can take a look at hooking it up into CI to make it easily downloadable, and maybe automatically make a PR to the SolveSpace website repository and host it somewhere on the website.

Created at 1 month ago

mac: Distinguish trackpad from Magic Mouse scroll (#1274)

This is the second attempt to distinguish trackpad scrolling that when used should yield panning from Magic Mouse scrolling that should control zoom.

Since trackpad will begin with a touch prior to the scroll event, but Magic Mouse not, we can use it to make sure we trigger panning only on a trackpad.

Previous "mac: Don't interpret single-touch scroll events as pan gestures" that was flawed was reverted which ultimately lead to being unable to zoom using Magic Mouse.

Created at 1 month ago
pull request closed
mac: Distinguish trackpad from Magic Mouse scroll

This is the second attempt to distinguish trackpad scrolling that when used should yield panning from Magic Mouse scrolling that should control zoom.

Since trackpad will begin with a touch prior to the scroll event, but Magic Mouse not, we can use it to make sure we trigger panning only on a trackpad.

Previous "mac: Don't interpret single-touch scroll events as pan gestures" that was flawed was reverted which ultimately lead to being unable to zoom using Magic Mouse.

This fixes again #1107 and is also related to #1218

Created at 1 month ago
issue comment
mac: Distinguish trackpad from Magic Mouse scroll

This is working for me now as well.

Thanks for working on this and figuring out a way to distinguish between mice ;)

Merging...

Created at 1 month ago
issue comment
mac: Distinguish trackpad from Magic Mouse scroll

I just compiled this and I still have the issue that when I scroll fast, in stead of panning SolveSpace zooms instead.

Maybe we should not pan with 2 finger scroll, and use mouse-down-drag to pan (like it was in the past, I think?)

Created at 1 month ago
issue comment
mac: Don't interpret single-touch scroll events as pan gestures

From the top of my head: I also had difficulty = was not able to differentiate between trackpad and magic mouse. It works nicely now with the trackpad, and there is room for improvement for the Magic Mouse, but I am not sure yet how we can implement it. I will take a look at this when I am returned from my holiday in a couple of weeks.

Created at 2 months ago