thaJeztah
Repos
345
Followers
1374
Following
32

Moby Project - a collaborative project for the container ecosystem to assemble container-based systems

65553
16977

An open and reliable container runtime

13476
2588

The Docker CLI

3930
1621

Automated nginx proxy for Docker containers using docker-gen

4
0

Automated build for pgAdmin4 Docker image

219
52

A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.

2981
569

Events

issue comment
Starting docker saturates all CPUs available.

Do you have the diagnostics ID that was generated? (I see you marked that you uploaded diagnostics, but there's no ID in your description above 😅)

Created at 2 hours ago
issue comment
[release/1.6] Update ttrpc to v1.1.1

/retest

Created at 3 hours ago
issue comment
libnet/d/windows: log EnableInternalDNS val after setting it

Marked this for cherry-picking, as this put us on the wrong foot when debugging an issue (and this should be a safe, no-risk change) (famous last words, because I've said that before 😂)

Created at 3 hours ago

vendor: github.com/moby/swarmkit/v2 v2.0.0-20230315203717-e28e8ba9bc83

  • CSI: Manager PublishVolume verify CSI node ID is not empty

full diff: https://github.com/moby/swarmkit/compare/a745a8755ce3...e28e8ba9bc83f7e7429dca435c5066340823842c

Signed-off-by: Sebastiaan van Stijn github@gone.nl

Merge pull request #45191 from thaJeztah/bump_swarmkit

vendor: github.com/moby/swarmkit/v2 v2.0.0-20230315203717-e28e8ba9bc83

Created at 4 hours ago
issue comment
Publish updates from main

@aevesdocker @usha-mandya @crazy-max ptal (/cc @sam-thibault )

Created at 4 hours ago
pull request opened
Publish updates from main
  • relates to https://github.com/docker/docs/pull/16964
  • relates to https://github.com/docker/docs/pull/16958

Proposed changes

Related issues (optional)

Created at 4 hours ago
issue comment
engine: add 23.0.2 release notes

/cc @neersighted @sam-thibault @corhere

Created at 4 hours ago
pull request opened
engine: add 23.0.2 release notes
  • re-applying https://github.com/docker/docs/pull/16946
  • "reverts" https://github.com/docker/docs/pull/16964

Proposed changes

Related issues (optional)

Created at 4 hours ago

engine: add 23.0.2 release notes

Signed-off-by: Bjorn Neergaard bneergaard@mirantis.com

Created at 4 hours ago
thaJeztah create branch engine_23.0.2_take2
Created at 4 hours ago
create branch
thaJeztah create branch revert-16964-revert-16946-engine_23.0.2
Created at 4 hours ago
delete branch
thaJeztah delete branch revert-16946-engine_23.0.2
Created at 4 hours ago
pull request opened
Revert "engine: add 23.0.2 release notes"

Reverts docker/docs#16946

  • see https://github.com/docker/docs/pull/16946#issuecomment-1483067324
Created at 5 hours ago
create branch
thaJeztah create branch revert-16946-engine_23.0.2
Created at 5 hours ago
issue comment
engine: add 23.0.2 release notes

Packages are up on staging, but we're still validating, so plan is to release after the weekend; let me do a revert of this for now, and we can merge it again on Monday.

Created at 5 hours ago
issue comment
Prohibit /proc and /sys to be symlinks

Probably not for this PR, but I noticed that we're inconsistent in handling "where to return". It looks like all switch cases have a return, except for one, and that one is put outside of the switch; https://github.com/opencontainers/runc/blob/efad7a3b80f4585065f93aad3e91989da5012d63/libcontainer/rootfs_linux.go#L475-L478

Perhaps we should move that one inside the case "bind" branch to make it clearer what condition it relates to. Doing so may also help linters detect that we're missing a return statement if we would add a new branch to any of the switches. https://github.com/opencontainers/runc/blob/efad7a3b80f4585065f93aad3e91989da5012d63/libcontainer/rootfs_linux.go#L436

Created at 8 hours ago
issue comment
Incorrect detection of lack of Apparmor installed

not according to GitHub though

Yes, GitHub's indicator if a commit is part of a tag is a bit "hit-and-miss" recently. It's in the tag though if you browse; https://github.com/moby/moby/blob/v23.0.1/daemon/apparmor_default.go#L22-L25

At first glance it seems like it should fix the issue though.

It does... partially. This PR from containerd is also needed to fix the remaining part;

  • https://github.com/containerd/containerd/pull/8087

Because some other code-paths may also hit that code;

  • https://github.com/moby/moby/blob/v23.0.1/daemon/oci_linux.go#L134
  • https://github.com/moby/moby/blob/v23.0.1/daemon/exec_linux.go#L28
  • (and in containerd itself for CRI); https://github.com/containerd/containerd/blob/v1.6.19/pkg/cri/server/helpers_linux.go#L141-L148
Created at 8 hours ago
issue comment
unknown service moby.sshforward.v1.SSH when building an image from github using buildkit

Yeah. It's not sure yet if there will be more 20.10 patch releases (and it probably is no issue with 23.0, right?). Guess it won't hurt to have a backport prepared at least; do you want to open one?

Created at 8 hours ago