A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.
Do you have the diagnostics ID that was generated? (I see you marked that you uploaded diagnostics, but there's no ID in your description above 😅)
/retest
Marked this for cherry-picking, as this put us on the wrong foot when debugging an issue (and this should be a safe, no-risk change) (famous last words, because I've said that before 😂)
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230315203717-e28e8ba9bc83
full diff: https://github.com/moby/swarmkit/compare/a745a8755ce3...e28e8ba9bc83f7e7429dca435c5066340823842c
Signed-off-by: Sebastiaan van Stijn github@gone.nl
Merge pull request #45191 from thaJeztah/bump_swarmkit
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230315203717-e28e8ba9bc83
@aevesdocker @usha-mandya @crazy-max ptal (/cc @sam-thibault )
/cc @neersighted @sam-thibault @corhere
engine: add 23.0.2 release notes
Signed-off-by: Bjorn Neergaard bneergaard@mirantis.com
Reverts docker/docs#16946
Packages are up on staging, but we're still validating, so plan is to release after the weekend; let me do a revert of this for now, and we can merge it again on Monday.
Probably not for this PR, but I noticed that we're inconsistent in handling "where to return". It looks like all switch cases have a return
, except for one, and that one is put outside of the switch; https://github.com/opencontainers/runc/blob/efad7a3b80f4585065f93aad3e91989da5012d63/libcontainer/rootfs_linux.go#L475-L478
Perhaps we should move that one inside the case "bind"
branch to make it clearer what condition it relates to. Doing so may also help linters detect that we're missing a return statement if we would add a new branch to any of the switches.
https://github.com/opencontainers/runc/blob/efad7a3b80f4585065f93aad3e91989da5012d63/libcontainer/rootfs_linux.go#L436
not according to GitHub though
Yes, GitHub's indicator if a commit is part of a tag is a bit "hit-and-miss" recently. It's in the tag though if you browse; https://github.com/moby/moby/blob/v23.0.1/daemon/apparmor_default.go#L22-L25
At first glance it seems like it should fix the issue though.
It does... partially. This PR from containerd is also needed to fix the remaining part;
Because some other code-paths may also hit that code;
Yeah. It's not sure yet if there will be more 20.10 patch releases (and it probably is no issue with 23.0, right?). Guess it won't hurt to have a backport prepared at least; do you want to open one?