tgalopin
Repos
42
Followers
328
Following
2

Sanitize untrustworthy HTML user input

378
39

Sanitize untrustworthy HTML user input (Symfony integration for https://github.com/tgalopin/html-sanitizer)

86
9

Symfony bundle integrating Flysystem into Symfony 4.2+ applications

282
54

Let's Encrypt/ACME Command Line client written in PHP

536
88

Events

issue comment
[Symfony UX React] component not rendering

Hi!

It is actually normal: the rendering is done in JavaScript, the HTML output is empty. Does the behavior work in the browser?

Created at 5 days ago
Created at 2 weeks ago
tgalopin create tag 3.0.0
Created at 3 weeks ago

Update README and UPGRADE, fix composer.json typo, update gitignore

Created at 3 weeks ago
tgalopin delete branch flysystem-v2
Created at 3 weeks ago
tgalopin delete branch master
Created at 3 weeks ago
tgalopin create branch 3.x
Created at 3 weeks ago
Version 3

Thanks a lot for this PR!

Created at 3 weeks ago

Reinstate Azure Blob Storage support

Added Azure support

Updated tests. Dropped support for PHP 7, Symfony 4.2/4.3 and Flysystem v2

Updated package version requirements and test jobs

Updated PHPCSFixer

Updated readme and upgrade

Updated indentation and Upgrade docs

Removed unnecessary test cases

Merge pull request #115 from nspyke/v3

Version 3

Created at 3 weeks ago
pull request closed
Version 3
  • Added Azure Blob Storage support
  • Dropped support for Symfony 4.2 to 5.3
  • Dropped support for PHP 7.2 - 7.4
  • Dropped support for Flysystem v2
  • Dropped support for v2 adapter versions

Version 3 as suggested in #112

Created at 3 weeks ago
tgalopin create branch 2.x
Created at 3 weeks ago
tgalopin create tag 2.4.0
Created at 3 weeks ago
tgalopin create tag 1.6.1
Created at 3 weeks ago
fix(docs): File permission should be octal in yaml

Thanks!

Created at 3 weeks ago

fix: File permission should be octal

Without the octal type this results in very weird file permissions

Merge pull request #99 from Tofandel/patch-1

fix(docs): File permission should be octal in yaml

Created at 3 weeks ago
pull request closed
fix(docs): File permission should be octal in yaml

Without the octal type this results in very weird file permissions

Created at 3 weeks ago
Wrong default for visibility in yaml configuration

Bug Report

| Q | A |------------ | ------ | BC Break | no (maybe) | Version | 1.5.0

Summary

I encountered this when using league/flysystem (1.0.46) with the available league/flysystem-bundle (1.5.0).

In my opinion the default for visibility should not be null, but public instead. Alternatively the configuration node should be marked as required.

                            ->scalarNode('visibility')->defaultNull()->end() // <- This does not seem correct.
                            ->booleanNode('case_sensitive')->defaultTrue()->end()
                            ->booleanNode('disable_asserts')->defaultFalse()->end()

This is related to this issue

How to reproduce

Using the following yaml configuration:

flysystem:
  storages:
    example.storage:
      adapter: 'local'
      options:
        directory: '%kernel.project_dir%/var/storage/example/storage'

Somewhere in my code I'm calling createDirectory(). Make sure the directory does not yet exist.

That's caused by the way the default is retrieved. Currently array_key_exists() is used to check if the configuration object passed to the adapter method contains such a key. It is empty by default, so the fallback config is asked about that key (visibility). The fallback config contains null as value. That issue is already described in the linked issue at league/flysystem.

Created at 3 weeks ago

Change the default visibility to 'public' in config

Merge pull request #67 from GameplayJDK/1.x-change_config_visibility_default

Change the default visibility to 'public' in config

Created at 3 weeks ago
pull request closed
Change the default visibility to 'public' in config

See #54 for details.

Fix #54

Created at 3 weeks ago
pull request closed
Fix sftp permission

This PR will fix #113 . A new configuration node was added in order to allow directory_visibility to be set

        asset_remote.storage:
            adapter: 'sftp'
            visibility: 'public'
            directory_visibility: 'public'
// omitted
Created at 3 weeks ago
Fix sftp permission

I merged https://github.com/thephpleague/flysystem-bundle/pull/100, thanks for the PR still!

Created at 3 weeks ago

Missing config definition SFTP adapter

Add missing configuration definition for SFTP adapter for options passphrase and hostFingerprint

Missing config definition SFTP adapter

Update tests

Update SftpAdapterDefinitionBuilderTest.php

Fix tests

Merge pull request #109 from meyron/patch-1

Missing config definition SFTP adapter

Created at 3 weeks ago
pull request closed
Missing config definition SFTP adapter

Add missing configuration definition for SFTP adapter for options passphrase and hostFingerprint

Created at 3 weeks ago
Lazy adapter can cause infinite recursion

I made a mistake in my configuration which lead me to infinite recursion (segfaulting). Turns out I had the name of the lazy storage in my environment variable, trying to infinitely create itself through LazyFactory::create()

parameters:
    env(RECURSION_SOURCE): recursion

flysystem:
    storages:
        recursion:
            adapter: 'lazy'
            options:
                source: '%env(RECURSION_SOURCE)%' #also breaks if I just fill in "recursion" here

Due to the nature of being a runtime calculation on which storage to use, I think the factory should probably validate that it's not trying to initialize the lazy adapter as the lazy adapter. If multiple levels of factories should be support (lazy -> lazy -> real) my suggestion won't solve it, but this would be a fix for my scenario:

class LazyFactory
{
    private $storages;

    public function __construct(ContainerInterface $storages)
    {
        $this->storages = $storages;
    }

    public function createStorage(string $source, string $storageName)
    {
        if ($source === $storageName) {
            throw new \InvalidArgumentException('... some message saying you try to initialize the lazy adapter');
        }

        if (!$this->storages->has($source)) {
            throw new \InvalidArgumentException('You have requested a non-existent source storage "'.$source.'" in lazy storage "'.$storageName.'".');
        }

        return $this->storages->get($source);
    }
}

Created at 3 weeks ago

Prevent recursion when the lazy adapter refers to itself

Merge pull request #108 from linaori/fix/lazy-factory-recursion

Prevent recursion when the lazy adapter refers to itself

Created at 3 weeks ago
pull request closed
Prevent recursion when the lazy adapter refers to itself

Fixes #106

Not sure if everything is set up as desired as there were no existing tests for this

Created at 3 weeks ago