@pesseba Can you review and approve this update? Two approvals are required 🙂
I forgot to run
composer update to get the new version of the library. Why is
composer.lock not under version control?
With the updated library, all tests pass for me:
$ URL=http://jwt.local USERNAME=test PASSWORD=test composer run test > ./vendor/bin/phpunit PHPUnit 9.5.25 ............. 13 / 13 (100%) Time: 00:33.838, Memory: 6.00 MB OK (13 tests, 110 assertions)
FYI: You can see additional debugging output for all requests by passing the
--debug flag to phpunit; though you need to separate it from the arguments for composer with
$ URL=http://jwt.local USERNAME=test PASSWORD=test composer run test -- --debug
Sorry for the late reply - Bogdan didn't have time to look into this. One of our other developers will check the query and whether the data can be used now. Thanks for implementing a fix so promptly!
Code inspired by Automattic's WordPress.com VIP mu-plugin:
Fixed features are still active when disabling them in settings.
Props @sun, @bogdanarizancu
w.org tha_sun, bogdanarizancu
E2E tests for Comments
Add E2E tests for Comments Feature
Fix terms e2e test
Merge pull request #2984 from 10up/burhan/fix-2971
Fix: Intermittent tests failures
Merge branch 'develop' into burhan/e2e-for-comments
Merge pull request #2955 from 10up/burhan/e2e-for-comments
E2E tests for Comments Feature