sun
Repos
46
Followers
70
Following
16

Events

Created at 4 hours ago
issue comment
Updated firebase/jwt to 6.3.

@pesseba Can you review and approve this update? Two approvals are required 🙂

Created at 2 days ago

Added composer.lock to ensure correct composer install behavior.

Created at 4 days ago
issue comment
Updated firebase/jwt to 6.3.

I forgot to run composer update to get the new version of the library. Why is composer.lock not under version control?

With the updated library, all tests pass for me:

$ URL=http://jwt.local USERNAME=test PASSWORD=test composer run test
> ./vendor/bin/phpunit
PHPUnit 9.5.25

.............                                                     13 / 13 (100%)

Time: 00:33.838, Memory: 6.00 MB

OK (13 tests, 110 assertions)

FYI: You can see additional debugging output for all requests by passing the --debug flag to phpunit; though you need to separate it from the arguments for composer with --:

$ URL=http://jwt.local USERNAME=test PASSWORD=test composer run test -- --debug
Created at 4 days ago
Created at 1 week ago
Bug for GraphQL query

Sorry for the late reply - Bogdan didn't have time to look into this. One of our other developers will check the query and whether the data can be used now. Thanks for implementing a fix so promptly!

Created at 1 week ago

Added caching for date filter options on administrative listing pages. (#77)

  • Added caching for date filter options on administrative listing pages.

  • bump version

Created at 1 week ago
sun delete branch feature/admin-date-filter-cache-sun
Created at 1 week ago
Added caching for date filter options on administrative listing pages.

Task

Code inspired by Automattic's WordPress.com VIP mu-plugin:

  • https://github.com/Automattic/vip-go-mu-plugins-built/blob/master/performance/vip-tweaks.php

Related issues

  • https://core.trac.wordpress.org/ticket/41675
  • https://wordpress.stackexchange.com/questions/200376/disable-slow-media-queries

Notes

  • This does not do anything on sites that do not have a persistent object cache set up.

TBD

  • Should this use transients instead to also work on smaller sites that do not have a lot of infrastructure?
Created at 1 week ago

fixup coding style

Created at 2 weeks ago

Fixed linter error.

Created at 2 weeks ago
pull request closed
Fixed elasticpress facets feature cannot be disabled.
Created at 2 weeks ago
sun delete branch patch/elasticpress-brands-filter-no-results-bogdan
Created at 2 weeks ago

Fixed elasticpress facets feature cannot be disabled. (#30)

Upstream: https://github.com/10up/ElasticPress/pull/3002

Co-authored-by: Daniel Kudwien daniel@netzstrategen.com

Created at 2 weeks ago

Added upstream PR.

Created at 2 weeks ago
pull request opened
Fixed features are still active when disabling them in settings.

Description of the Change

Problem

  • When disabling a feature in the plugin settings, then the feature is still active on the site.

Goal

  • We want to disable the Facets feature, because it manipulates taxonomy queries, causing them to yield wrong results (outside of scope of this issue).

Cause

  • Disabling a feature sets the 'force_inactive' property on it, but the property is never checked when

How to test the Change

  1. Disable the Facets feature.
  2. Go to the Widgets settings page; you should not see the Facets widgets as available widgets anymore.

Changelog Entry

Fixed features are still active when disabling them in settings.

Credits

Props @sun, @bogdanarizancu

w.org tha_sun, bogdanarizancu

Checklist:

  • [x] I agree to follow this project's Code of Conduct.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [x] All new and existing tests pass.
Created at 2 weeks ago

Fixed features are still actively loaded when disabling them in settings.

Created at 2 weeks ago
create branch
sun create branch fix/settings-feature-active-sun
Created at 2 weeks ago

E2E tests for Comments

Add E2E tests for Comments Feature

Minor change

Feedback Addressed

Fix Tests

Fix Unit-tests

Fix terms e2e test

Add Comments

Minor change

Merge pull request #2984 from 10up/burhan/fix-2971

Fix: Intermittent tests failures

Merge branch 'develop' into burhan/e2e-for-comments

Merge tests

Minor change

Merge pull request #2955 from 10up/burhan/e2e-for-comments

E2E tests for Comments Feature

Created at 2 weeks ago