Checks if packages are up to date to last major versions after update
By the way, we already have a somewhat related expo monorepo
group preset configured here: https://github.com/renovatebot/renovate/blob/25c60afa8ed705066be3f8e4d927cfc91b89c8b9/lib/config/presets/internal/monorepo.ts#L89
However, it was not very helpful to me because of this discussion subject, and I am not currently using it.
It's getting challenging to detect all these variants (including Lerna too) and automatically do the right thing
@rarkins Why not starting with that ruleset?
{
"packageRules": [
{
"matchSourceUrlPrefixes": ["https://github.com/expo"],
}
]
}
This is not an exhaustive match, but we can at least be sure that package coming from expo
itself must be updated using expo install
instead of npm install
.
For the rest as the other package has to be installed with expo install
only if we are using expo, this matching will indeed be harder.
However, we may maintain a package list for that on a :expoProject
preset to be manually activated.
Is that making any sense?
Adds @gitbeaker
mono repo to the presets list.
I have verified these changes via:
feat(presets): gitbeaker monorepo
Add OutlinedInput for label adjustment
Add import
Merge branch 'master' of https://github.com/sebastianbuechler/react-admin
Memoize mutation callbacks
Add tests
Merge pull request #8526 from rkfg/master
Memoize mutation callbacks
Add ability to use a React Node as useNotify
message
Fix typos
Merge pull request #8580 from marmelab/useNotify-node
Add ability to use a React Node as useNotify
message
enhancement: add generic type
refactor: add removed imports
refactor: add removed imports
refactor: improve code readability
refactor: fix types
Make List children responsible of the empty state
Touching up Tutorial.md with improvements to TypeScript examples.
Fixing TS-only syntax.
Tutorial examples now use .js instead of .ts. Noted required changes for TS in comments.
Bump http-cache-semantics from 4.1.0 to 4.1.1
Bumps http-cache-semantics from 4.1.0 to 4.1.1.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Prepare changelog for v4.7.4
[systemd] Allow to configure service name suffix
Merge pull request #2 from jeromemacias/master
[systemd] Allow to configure service name suffix
Because my service name is not php-fpm.service
but php7.2-fpm
so I need to be able to configure both service name and the suffix.
It should be full compatible as with default value the service in the command is php-fpm.service
by default for systemd
.
Thanks for your plugin !
Looks good to merge, thanks!
feat(npm): performance improvements
I got a similar issue running commitlint
on a GitLab CI job.
Here is the Dockerfile
of my commitlint
command:
FROM node:18.14-alpine
RUN apk add --no-cache git~=2 \
&& npm install --global @commitlint/cli@17.4.4 @commitlint/config-conventional@17.4.4
COPY rootfs /
USER node
ENTRYPOINT [ "commitlint", "--strict", "--config", "/commitlint.config.js" ]
The related CI job:
release:commitlint:
stage: release
needs: []
image:
name: registry.gitlab.com/kidways/images/commitlint
entrypoint: ['']
script:
- git config --global --add safe.directory ${CI_PROJECT_DIR}
- git fetch --quiet origin ${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}
- npx commitlint --version
- npx commitlint --strict --config /commitlint.config.js --from=origin/${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}
rules:
- if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
allow_failure:
exit_codes: 2
Works on any of my project excepts the one using tsonfig.json
, ending to a similar error.
My workaround was to add a rm -f tsconfig.json
just before the commitlint
command.
Is your feature request related to a problem? Please describe.
The current fake data provider of getMany
implementation assumes the identity key is id
: https://github.com/marmelab/react-admin/blob/3d7e3842504e993d6defee601c3156f9a2167c10/packages/ra-data-fakerest/src/index.ts#L68
However, this is not representative to my real API database, which has an _id
property.
Describe the solution you'd like
Make the id key configurable.
Describe alternatives you've considered
Adds a id
value. However, this may leads to misunderstanding mistake during development process.
Additional context Add any other context or screenshots about the feature request here.
Was able to get a full control by copy/pasting the original prBodyDefinitions
and using it with a combination of my column definition:
diff --git a/tasks/renovate/config.js b/tasks/renovate/config.js
index ec835c1..23f9812 100644
--- a/tasks/renovate/config.js
+++ b/tasks/renovate/config.js
@@ -1,3 +1,10 @@
+const prBodyColumns = [
+ 'Package',
+ 'Type',
+ 'Update',
+ 'Change',
+];
+
/**
* @see https://docs.renovatebot.com/self-hosted-configuration/
* @see https://docs.renovatebot.com/configuration-options/
@@ -13,7 +20,6 @@ module.exports = {
'group:monorepos',
'group:recommended',
'workarounds:all',
- 'github>whitesource/merge-confidence:beta',
],
autodiscover: true,
autodiscoverFilter: [
@@ -33,6 +39,16 @@ module.exports = {
dependencyDashboardApproval: true,
gitLabIgnoreApprovals: false,
},
+ prBodyDefinitions: {
+ // @see https://github.com/whitesource/merge-confidence/blob/main/beta.json
+ Age: "[](https://docs.renovatebot.com/merge-confidence/)",
+ Adoption: "[](https://docs.renovatebot.com/merge-confidence/)",
+ Passing: "[](https://docs.renovatebot.com/merge-confidence/)",
+ Confidence: "[](https://docs.renovatebot.com/merge-confidence/)",
+ },
+ // https://sourcegraph.com/search/badge?q=repo:github.com/babel/babel+case:yes+-file:package-lock.json+babel/babel&label=matches
+ // https://sourcegraph.com/search?q=repo:github.com/babel/babel+case:yes+-file:package-lock.json+babel/babel
+ prBodyColumns,
hostRules: [
{
hostType: 'npm',
@@ -41,6 +57,18 @@ module.exports = {
},
],
packageRules: [
+ // @see https://github.com/renovatebot/renovate/issues/7879
+ {
+ matchDatasources: ['maven', 'npm', 'pypi'],
+ updateTypes: ['patch', 'minor', 'major'],
+ prBodyColumns: [
+ ...prBodyColumns,
+ 'Age',
+ 'Adoption',
+ 'Passing',
+ 'Confidence',
+ ],
+ },
Spoke too fast. Defining prBodyColumns
on the global config does apply them to all merge request kind. But it does more, providing confidence badges when I don't want. I'll play with the package rules for that, thanks!
@setchy Isn't what the issue is telling for? I of course did add the following to my config:
prBodyDefinitions: {
Sourcegraph: '[](https://sourcegraph.com/{{{sourceRepo}}}?badge)',
},
prBodyColumns: [
'Package',
'Type',
'Update',
'Change',
'Pending',
'Sourcegraph',
],
But it does not change a thing on the mr bodies managed by the merge confidence feature.
I am currently testing @rarkins workaround adapter to my needs.
It does not remove only the custom columns, but also changes the default configuration.
Here is my configuration:
module.exports = {
extends: [
':pinAllExceptPeerDependencies',
':dependencyDashboard',
':ignoreModulesAndTests',
':semanticCommits',
':separateMultipleMajorReleases',
'group:monorepos',
'group:recommended',
'workarounds:all',
'github>whitesource/merge-confidence:beta',
],
autodiscover: true,
autodiscoverFilter: [
'company/**/*',
],
npmrc: '@company:registry=https://gitlab.com/api/v4/packages/npm/',
persistRepoData: true,
onboarding: false,
platform: 'gitlab',
platformAutomerge: true,
automergeType: 'pr',
gitLabIgnoreApprovals: true,
requireConfig: 'optional',
commitBodyTable: true,
stabilityDays: 3,
major: {
dependencyDashboardApproval: true,
gitLabIgnoreApprovals: false,
},
hostRules: [
{
hostType: 'npm',
matchHost: 'https://gitlab.com/api/v4/packages/npm/',
token: process.env.GITLAB_TOKEN,
},
],
packageRules: [
// The following packages can not be updated because of the Expo constraints.
// @see https://github.com/renovatebot/renovate/issues/7417
{
packageNames: [
'@react-native-community/datetimepicker',
'@types/react-native',
'expo-linking',
'expo-notifications',
'expo-splash-screen',
'expo-updates',
'react-native',
'react-native-gesture-handler',
'react-native-reanimated',
'react-native-safe-area-context',
'react-native-screens',
'react-native-web',
],
matchManagers: ['npm'],
enabled: false,
},
{
matchPackagePrefixes: [
'company/',
'@company/',
],
dependencyDashboardApproval: false,
stabilityDays: 0,
},
{
matchManagers: [
'gitlabci-include',
],
semanticCommitType: 'ci',
semanticCommitScope: null,
},
{
matchUpdateTypes: [
'minor',
'patch',
'pin',
],
packageNames: [
'@company/eslint-config',
'eslint',
'company/ci',
'typescript',
],
matchPackagePrefixes: [
'@sentry/',
'@typescript-eslint/',
'eslint-',
'eslint-',
],
matchPackagePatterns: [
'^company/.*/ci$',
],
automerge: true,
},
],
};
Result before introducing github>whitesource/merge-confidence:beta
:
Result after introducing the confidence feature:
As you can see, the "Type" and "Update" column are gone.
It looks like the issue is somewhat related to hidden paths.
Given the following .gitignore
:
/.cache/
/cache/
We have a difference of behavior we can quickly figure out simply by storing the npm cache on the root project directory:
# Produce no duplicate report from the `cache` directory
g clean -fdx && npm_config_cache=cache npx jscpd@3.5.3 --gitignore .
# Produce duplicate report from the `.cache` directory
g clean -fdx && npm_config_cache=.cache npx jscpd@3.5.3 --gitignore .
Looking at the related source code, we may assume it come from the pattern custom transformation or a bug with the used gitignore-to-glob
package.
In case of second option, we may replace it by a more maintained one named ignore
.
fix: not handled let's encrypt error without status