soullivaneuh
Repos
277
Followers
128
Following
60

Just yet another dotfiles repository

2
0

Checks if packages are up to date to last major versions after update

234
12

Events

Created at 6 hours ago
issue comment
Manifest missing originalFullName in EAS Build Development Client

It seems you're using eas anyway.

Yes but I do have this issue using eas! By the way, I'm not trying to use the same variables as you, I try to fetch a extra.apiEndpoint custom var we defined.

My https://github.com/expo/expo/issues/13513#issuecomment-1237238178 works with that without any hardcoding. I'm using that solution in production too :)

Indeed, you don't have value hardcoded on your code. However, what a complex custom logic just for a not provided manifest property. :-/

I think I'll just be careful of doing a eas upate command just after the eas build to be sure the app load the configuration correctly until I do the upgrade to SDK 46.

Thanks for the help! :+1:

Created at 3 days ago
issue comment
Manifest missing originalFullName in EAS Build Development Client

@SleeplessByte Well, if I can avoid hard-coding ugly workaround, I'll prefer. :-)

I do not understand how we can being in such situation.

However, I noticed something:

  1. If you publish an app using eas build, the manifest2 property is not present
  2. If you do a eas update command next after, the updated app will have the property

However, if the eas update command is done before the eas build one, it will lead to the same situation. I assume this is because the built app won't update because it is more recent than the updated version.

Created at 3 days ago
issue comment
Manifest missing originalFullName in EAS Build Development Client

@danshilm I indeed did found the same thing, using Constants.expoConfig starting expo SDK 46.

However, I can not upgrade to that right now because it require react v18 that is not yet supported by my other dependencies

Also, I just figured out that Constants.manifest2 looks not available when the application come from an eas build result directly, but works with Expo Go.

So currently, I don't have any solution about this mess.

Created at 4 days ago
Two Factor (2FA) challenge is required on next login despite of the device trust option being selected

We have an interrogation about that subject: Can the 2FA computer trust option being reset in case of the external ip of the user is changed?

Created at 6 days ago
Google connect black square logo

appears resolved and stale

I don't know, you tel me? I applied the workaround I described to get my own working SVG file, but if yours is still the same, I would say no, the issue is not resolved.

It became stale because it got not any answer since its opening.

Created at 6 days ago
issue comment
Manifest missing originalFullName in EAS Build Development Client

It's probably not the recommended way as with eas-updates, manifest is no longer set :/

@SleeplessByte I think you are right. I personally solve my issue by using the following:

Constants.manifest2?.extra?.scopeKey

Important note: The Constants.manifest2 looks to be provided only when you configure your application for eas update.

See also the related comments set on the typing of both manifest properties.

Created at 1 week ago
Two Factor (2FA) challenge is required on next login despite of the device trust option being selected

Hi,

Thanks for the help, here is the answers:

Which edition of FusionAuth are you using?

Starter plan.

If you are using a paid version, what options do you have enabled under Tenant > Edit Tenant > Multi-Factor? Please upload a screenshot here.

Here is the extract:

image

For the users that you’ve enabled MFA on, which form of MFA is enabled?

Currently, authenticator and email provider are enabled but both produce the reported issue.

Did you enable MFA through the self service account, User API, or build your own MFA interface?

Both of:

  • Built our own MFA interface (legacy) using the FusionAuth API in background..
  • Use the self service account

Currently both are available, we are during a migration process.

Can you confirm which cookies you are deleting? I can confirm that when I clear cookies on Chrome and try to log back into an application that has MFA enabled, I am prompted for an MFA challenge again.

We do not remove FusonAuth related cookies, only the PHPSESSID cookie generated by our PHP application.

When we does and refresh the page, our app security firewall will redirect to the FusionAuth Oauth process redirect.

This is at this point the code is asked again.

Do you have application level MFA enabled and if so, how are you enforcing it?

The tenant level is used:

image

For the tenant settings, please see the previous details block.

Regards

Created at 1 week ago
Created at 2 weeks ago
no-unused-styles: false positive with variable based style object selection

Considered this component having a variant prop with values white and primary, affecting the selection of the styles object:

import React, { FC } from 'react';
import {
  StyleSheet, KeyboardAvoidingView, Platform, View,
} from 'react-native';
import { SafeAreaView } from 'react-native-safe-area-context';
import { colors } from '@company/design';
import Constants from 'expo-constants';

interface Props {
  logonScreen?: boolean;
  variant?: 'white' | 'primary';
}

const styles = StyleSheet.create({
  safeArea: {
    flex: 1,
    backgroundColor: colors.white,
  },
  safeAreaLogon: {
    backgroundColor: 'white',
  },
  container: {
    flex: 1,
  },
  center: {
    justifyContent: 'center',
  },
});

const variants = {
  white: StyleSheet.create({
    container: {
      backgroundColor: 'white',
    },
  }),
  primary: StyleSheet.create({
    container: {
      backgroundColor: colors.primary,
    },
  }),
};

export const ScreenWrapper: FC<Props> = ({
  logonScreen, children, variant,
}) => {
  const variantStyle = variants[variant || 'white'];
  const viewStyle = [
    styles.container,
    variantStyle.container,
    ...logonScreen ? [styles.center] : [],
  ];

  return (
    <SafeAreaView
      style={[
        styles.safeArea,
        ...logonScreen ? [styles.safeAreaLogon] : [],
      ]}
    >
      <View style={viewStyle}>
        {
          Platform.OS === 'ios'
            ? (
              <KeyboardAvoidingView
                style={{ flex: 1 }}
                behavior="padding"
                keyboardVerticalOffset={Constants.statusBarHeight}
              >
                {children}
              </KeyboardAvoidingView>
            )
            : children
        }
      </View>
    </SafeAreaView>
  );
};

export default null;

ESlint will complain with the following:

error  Unused style detected: undefined.container  react-native/no-unused-styles

Maybe related to #125.

Created at 2 weeks ago
feat(fr): password related translations
Created at 2 weeks ago
soullivaneuh create branch fr/password
Created at 2 weeks ago
issue comment
expo-clipboard crashes on Android with "undefined is not an object (evaluating 'default.setString')"

@keith-kurak So if I well understand, including any new expo-* package require to publish a new build on the app stores?

Do we have a documentation referencing that?

Thanks!

Created at 3 weeks ago
Two Factor (2FA) challenge is required on next login despite of the device trust option being selected

Two Factor (2FA) challenge is required on next login despite of the device trust option being selected

Description

Login again on an application re-trigger the two factor verification challenge process despite having the device trust option being selected at the first login.

Affects versions

v1.38.1

Steps to reproduce

  1. With an account having multi-factor enabled, login to an application requiring multi-factor.
  2. On the multi-factor verification challenge, fill the verification code
  3. Check the "Trust my computer" option.
  4. Once logged-in to your app, remove it session cookie (of the developed app, not FusionAuth) to trigger a re-authentication

Current behavior

The Oauth re-authenticate immediately the user to the application but ask for a two-factor code.

Expected behavior

The Oauth authentication process should just re-authenticate the user to the application.

Screenshots

N/A

Platform

(Please complete the following information)

  • Device: Desktop
  • OS: Multiple
  • Browser + version: Multiple
  • Database: PostgresSQL

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

Please note that it does not happen all the time. However, when it happens, it looks like to be applied to all the users at the same time (tested with my office co-workers).

I unfortunately can not add more context to this bug, I would like some indication to help me determinate the root cause.

The only clue I have is we did only one change: An upgrade from v1.36.8 to v1.38.1.

Created at 4 weeks ago
issue comment
Add a way to ignore by full path, not basename

@Pierre-Sassoulas sure! Please consider https://github.com/PyCQA/pylint/issues/7371.

Thanks!

Created at 4 weeks ago
opened issue
Provide a --ignore-file option with .gitignore as default

Current problem

When I run pylint, report warning are found on files ignored by .gitignore (vendor, generated file etc...).

Because of that, I have to specify nearly the same configuration as the .gitignore to the --ignore-paths option, but with a different format.

This is config repetition that make project and CI configuration heavier to maintain.

Desired solution

Make pylint considering the .gitignore file for analysis ignorance.

it SHOULD also provide a --ignore-file option to specify an another file than .gitignore to consider.

It MAY also taking into account equivalent of .gitignore for other versioning tools (svn, hg...).

Additional context

Related to https://github.com/PyCQA/pylint/issues/2279.

See comment: https://github.com/PyCQA/pylint/issues/2279#issuecomment-1224016019

Created at 4 weeks ago
issue comment
Testing: document how to mock the t function and access it

Thanks for the sample and the documentation update, I'll test that soon! :+1:

Created at 4 weeks ago
issue comment
Type annotations for default export

@NikolaRHristov Yes, but this works only if you export a function, you are typing its return type.

Created at 4 weeks ago
issue comment
Testing: document how to mock the t function and access it

@adrai I am not, this is the goal of mocking. I will verify my code is indeed calling the t function and is passing the right parameters on it.

I am not verifying the translation result here, only the call.

Created at 1 month ago
opened issue
project list --all command option does not return all the projects anymore

Since version 0.25.0, the --all option of the project list command it not working as expected.

# Expected result, working with 0.24.0
❯ LAB_CORE_HOST="https://gitlab.com" LAB_CORE_TOKEN=${GITLAB_TOKEN} ./lab-0.24.0 project list --member --all | wc -l 
280
# Current result
❯ LAB_CORE_HOST="https://gitlab.com" LAB_CORE_TOKEN=${GITLAB_TOKEN} ./lab-0.25.0 project list --member --all | wc -l
100
Created at 1 month ago
issue comment
Expo upgrade: Skip if up to date option

This issue was closed without any feedback. It would be great to not having stale bot closing that kind of situation which generate nothing else than time loosing frustration.

cc @AdamJNavarro

Created at 1 month ago
issue comment
Expo upgrade: Skip if up to date option

This issue was closed without any feedback. It would be great to not having stale bot closing that kind of situation which generate nothing else than time loosing frustration.

Created at 1 month ago
soullivaneuh delete branch patch-1
Created at 1 month ago
issue comment
GroupHooks support

@jdalrymple I did a specific work for GroupHooks in https://github.com/jdalrymple/gitbeaker/pull/2514.

May it be considered?

Created at 1 month ago
reopened issue
Support PHP 8

Currently the bundle can't be used on PHP 8 because of the version constraint. Please consider supporting PHP 8 as well.

From a quick check your dependencies all support PHP 8, so they won't stop you from upgrading. Not sure about the actual code though.

Created at 1 month ago
issue comment
Support PHP 8

@Algatux I suggest to keep this issue open until some-one propose a solution.

Created at 1 month ago
Unable to automatically configure some email template id of a tenant because of the missing Reactor license

@robotdan Well, this is very limiting, making us having to configure the reactor license key even on development environment just to make the setup script working, event if we do not need to test paid features.

I don't see what is the issue of allowing option configuration without the license, as the feature will not works in any case.

May this be reconsidered?

Created at 1 month ago
issue comment
Add a way to ignore by full path, not basename

@matusvalo @Pierre-Sassoulas the --ignore-paths option does not have the same behavior.

What about the .gitignore style solution?

Created at 1 month ago
issue comment
Add a way to access the request helper

there is a bit of docs in the Readme but it isnt very verbose

May you please point out a link of that? I may be blind, but I didn't find anything illustrating how to use this requester to communicate directly with the raw GitLab API.

Created at 1 month ago
soullivaneuh delete branch dependabot/npm_and_yarn/svelte-3.49.0
Created at 1 month ago