sivchari
Repos
37
Followers
62
Following
29

gotwtr provides Twitter v2 API

52
11

Snowflake emulator written in Rust

11
1

Fast linters Runner for Go

11539
1089

Events

Created at 2 days ago

fix format

Signed-off-by: sivchari shibuuuu5@gmail.com

Created at 2 days ago

fix format

Created at 2 days ago

fix: conflict

Signed-off-by: sivchari shibuuuu5@gmail.com

Created at 3 days ago

docs: Improving Logo (#25)

Signed-off-by: Chris Short cbshort@amazon.com

Issue #, if available: N/A

Description of changes: Updating the logo in the README

Testing done: Local IDE

  • [X] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Chris Short cbshort@amazon.com

fix: error readable by using the right placeholder (#39)

Description of changes:

Logs aren't as readable as they could be, I saw this during finch vm init:

INFO[0009] sudoers file not found: %!w(*fs.PathError=&{open /etc/sudoers.d/finch-lima 2})

From the looks of it, we don't need the %w since the current logging implementation doesn't use fmt.Errorf under the hood anyway, and thus makes the output hard to read without the only potential benefit being utilised (unwrapping). And since the logging interface's methods themselves don't return anything, it's fairly likely unwrapping won't happen in any other implementation (there isn't even a reason for it anyway - the callee will have all the args available to it, so it can introspect the error passed directly).

(Since this Infof call is made right after an errors.Is, the whole %v/%w bit is redundant as it will just say "sudoers file not found: no such file or directory", but I didn't want to change error semantics in this PR.)

Testing done:

make test-unit and using logrus directly to verify none of its *f methods use fmt.Errorf.

  • [x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ondrej Kokes ondrej.kokes@gmail.com Co-authored-by: Weike Qu 47606630+weikequ@users.noreply.github.com

build(deps): Bump github.com/xorcare/pointer from 1.2.1 to 1.2.2 (#42)

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps github.com/xorcare/pointer from 1.2.1 to 1.2.2.

Dependabot compatibility
score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps): Bump golang.org/x/crypto from 0.1.0 to 0.3.0 (#49)

Bumps golang.org/x/crypto from 0.1.0 to 0.3.0.

Dependabot compatibility
score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: conflict

Created at 3 days ago

docs: Improving Logo (#25)

Signed-off-by: Chris Short cbshort@amazon.com

Issue #, if available: N/A

Description of changes: Updating the logo in the README

Testing done: Local IDE

  • [X] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Chris Short cbshort@amazon.com

fix: error readable by using the right placeholder (#39)

Description of changes:

Logs aren't as readable as they could be, I saw this during finch vm init:

INFO[0009] sudoers file not found: %!w(*fs.PathError=&{open /etc/sudoers.d/finch-lima 2})

From the looks of it, we don't need the %w since the current logging implementation doesn't use fmt.Errorf under the hood anyway, and thus makes the output hard to read without the only potential benefit being utilised (unwrapping). And since the logging interface's methods themselves don't return anything, it's fairly likely unwrapping won't happen in any other implementation (there isn't even a reason for it anyway - the callee will have all the args available to it, so it can introspect the error passed directly).

(Since this Infof call is made right after an errors.Is, the whole %v/%w bit is redundant as it will just say "sudoers file not found: no such file or directory", but I didn't want to change error semantics in this PR.)

Testing done:

make test-unit and using logrus directly to verify none of its *f methods use fmt.Errorf.

  • [x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ondrej Kokes ondrej.kokes@gmail.com Co-authored-by: Weike Qu 47606630+weikequ@users.noreply.github.com

build(deps): Bump github.com/xorcare/pointer from 1.2.1 to 1.2.2 (#42)

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps github.com/xorcare/pointer from 1.2.1 to 1.2.2.

Dependabot compatibility
score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps): Bump golang.org/x/crypto from 0.1.0 to 0.3.0 (#49)

Bumps golang.org/x/crypto from 0.1.0 to 0.3.0.

Dependabot compatibility
score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Created at 3 days ago

fix: log format

Signed-off-by: sivchari shibuuuu5@gmail.com

Created at 3 days ago
pull request opened
fix: log format

Issue #, if available:

Description of changes:

I fixed log format. It's failed on purpose to confirm the logs.

DEBU[0000] Creating limactl command: ARGUMENTS: [ls -f {{.Status}} finch], LIMA_HOME: /user/workspace/finch/lima/data 
DEBU[0000] Status of virtual machine:                   
INFO[0000] dependency socket_vmnet file not found: open /user/workspace/finch/dependencies/lima-socket_vmnet/opt/finch/bin/socket_vmnet: no such file or directory 
INFO[0000] Requesting root access to finish network dependency configuration 
Password:
DEBU[0004] Creating limactl command: ARGUMENTS: [sudoers], LIMA_HOME: /user/workspace/finch/lima/data 
DEBU[0004] config file not found: %!w(*fs.PathError=&{open /user/workspace/finch/lima/data/_config/override.yaml 2}) 
INFO[0004] dependency socket_vmnet file not found: open /user/workspace/finch/dependencies/lima-socket_vmnet/opt/finch/bin/socket_vmnet: no such file or directory 
ERRO[0004] Dependency error: failed to install dependencies: [Failed to finish installing rootful dependencies which are needed for external network access within the guest OS. Boot will continue, but container exposed ports will not be accessible from macOS.: [error copying files to directory /opt/finch, err: exit status 1, stderr: cp: /user/workspace/finch/dependencies/lima-socket_vmnet/opt/finch: No such file or directory
 skipping installation of network configuration because pre-requisites are missing]] 
FATA[0004] failed to load the lima config file: open /user/workspace/finch/lima/data/_config/override.yaml: no such file or directory

logrus finally call (*Entry).Logf. The function uses fmt.Sprintf to format. So, %w cannot use to format.

Testing done:

  • [x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Created at 3 days ago
create branch
sivchari create branch fix-log-fmt
Created at 3 days ago
started
Created at 3 days ago
Created at 3 days ago
issue comment
feat: improve naming

/remove-lifecycle stale

Created at 4 days ago
issue comment
feat: improve naming

/remove lifecycle stale

Created at 4 days ago
issue comment
feat: improve naming

/assign @derekwaynecarr

Created at 4 days ago
issue comment
feat: improve naming

/assign @derekwaynecarr

Created at 4 days ago

Feat me api (#157)

  • wip: impl me

  • impl me api

  • delete codecov

Created at 5 days ago
delete branch
sivchari delete branch feat-me-api
Created at 5 days ago
pull request closed
Feat me api

Impl me API.

Created at 5 days ago

delete codecov

Created at 5 days ago
issue comment
fix: pre allocate for composite literal

Thanks @jbardin 😄

Created at 5 days ago
pull request opened
Feat me api

Impl me API.

Created at 5 days ago

impl me api

Created at 5 days ago
opened issue
Add golangci-lint to keep code quality

Terraform Version

Terraform v1.4.0-dev
on darwin_arm64

Use Cases

Go is a very easy language to analyze ast as it has a standard static analysis tool (go vet). There are also tools such as golangci-lint that provide a variety of linters. This is not a minority setting, but one that is also provided by various well-known libraries, including Kubernetes. In fact, even terraform has potential bugs like #32261 that have gone unnoticed until now. And such bugs may still exist. As we develop more features in the future, such bugs could have a significant impact on users and, more importantly, on the company. Therefore, by introducing linter at this time, the quality of the code can be assured at the level of static analysis.

Attempted Solutions

None.

Proposal

Loadmap

  • [ ] Discuss the introduction of golangci-lint
  • [ ] Select which linter to enable
  • [ ] Set the linter setting and fix lint errors
  • [ ] Add a new workflow to check by linter

References

No response

Created at 5 days ago
issue comment
fix: pre allocate for composite literal

Hi @crw, thanks for comments ! I fixed pre allocation for composite literal. A initialization of slices using make can take 3 arguments. If only 2 arguments is passed, the length and the capacity is same of 2nd argument. So, we should use index to assign to the slice. But, the existing codes use append to assign to the slice passed only 2 arguments. This would cause the top of the list to be filled with the zero value of the first argument (e.g. Play Ground)

Created at 6 days ago

fix: pre allocate for composite literal

Created at 6 days ago
pull request opened
fix: pre allocate for composite literal

Fixes #

Target Release

1.3.x

Draft CHANGELOG entry

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

  • BUG FIXES: fix pre allocate for composite literal
Created at 6 days ago