33
128
2
JavaScript diagramming library for interactive flowcharts, org charts, design tools, planning tools, visual languages.
Events
Amend the "nasty hack to silence harmless warnings"...
...to include Error pages too, because when throwing 404s (etc), args[0] can also be:
"<Error> was created with unknown prop 'data'"
And this is not caught by the current regex. Instead, the regex only captures strings containing <Layout> or <Page>.
This is an extremely minor edit, and I anticipate no problems, alas I have not run tests.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
- [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [ ] This message body should clearly illustrate what problems it solves.
- [ ] Ideally, include a test that fails without this PR but passes with it.
Tests
- [ ] Run the tests with
pnpm testand lint the project withpnpm lintandpnpm check
Changesets
- [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.
Fix the nasty hack to silence harmless warnings...
...to include Error pages too, because when throwing 404s (etc), args[0] can also be:
"<Error> was created with unknown prop 'data'"
And this is not caught by the current regex.
baffling that it keeps making me do this
Rename `invalid` to... something else?
glad you picked a verb :D
Resolution of absolute import fails
This is indeed strange behavior since writing
<ComponentName ...
and tabbing to use Svelte's(?) autocomplete in VS Code, it automatically adds
import Border from 'src/components/ComponentName.svelte';
which fails by default.
