@paoliniluis I can easily add tests for the formatting function, but since I am not a frontend dev question from me: is there a test for the View part? Is footer tested anywhere? Some Selenium or something?

@paoliniluis the tab goes away so if you are not looking (e.g. brewing tea) you have no idea for how long it run. Also, on the tab it's shown after 10s so for shorter queries you don't have the data at all.

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Closes https://github.com/metabase/metabase/issues/[29482]

Description

Shows "Running time" in the bottom right corner

How to verify

1. New question -> SQL Query -> bottom right corner

Checklist

• [ ] Tests have been added/updated to cover changes in this PR

Add QuestionRunningTime to QueryBuilder footer

Is your feature request related to a problem? Please describe. Currently, it's almost impossible to tell how long the query run on the database as Metabase does not show any indication anywhere regarding time. I've noticed today in the Dev Tools that actually api/dataset endpoint returns running_time property which from what I see is time in milliseconds. Could we maybe show this data when running raw SQL query in New -> SQL Query window?

Describe the solution you'd like Show elapsed time in seconds/milliseconds in the bottom right corner near the number of returned rows, e.g.

Describe alternatives you've considered Looking in Dev Console for every query

How important is this feature to you? As a developer I am very focused on the performance of my queries so it would be great to get that information

Additional context Screenshot posted above

I had this PHPStan rule specified in my configuration:

parameters:
	disallowedFunctionCalls:
		-
			function: 'env()'
			allowIn:
				- 'src/AllowedIn.php'
			allowExceptParams:
				-
					position: 1
					name: 'key'
					value: 'SOME_ENV'

and it worked perfectly fine until upgrading to version v2.11.3. In the version v2.11.3 and v2.11.4 code snippet from below fails even though it shouldn't:

<?php

class WithProperty {
	/** @var string */
	public string $property;
}

class Test {
	public function __construct() {
		$withProperty = new WithProperty();
		env($withProperty->property . '_OTHER');
	}
}

In this PR additional argument is accepted by linkToCrudAction() that allows the dev to pass additional parameters to generated URL, which simplifies userland code where the dev would have to use the adminUrlGenerator with all specific params (entity ID etc.) instead.

Make params non-nullable