shrikeh
Repos
112
Followers
30
Following
9

Simple PHP library to improve verbosity in HTTP response codes

277
15

A Composer-friendly port of the PEAR-based Template for Jenkins Jobs for PHP Projects (http://jenkins-php.org)

19
5

A simple nginx conf file to allow your backend (Varnish, Apache Traffic Server, etc) to not worry about CSRF tokens and put the onus on the front (nginx) instance

38
9

Interim version of the SPDY sandwich for testing - don't use in prod!

5
0

Role to automatically change your deploy key, therefore ensuring a fresh key every time. For the security-minded, or those who just want to totally forget about the need to setup deploy keys.

7
3

PHP Micro component for event dispatch

1
0

Events

Add .gitattributes with specific files

Created at 1 month ago

Add .gitattributes with specific files

Created at 1 month ago

Add .gitattributes

Created at 1 month ago

Add docs of metrics and coverage

Created at 1 month ago
create branch
shrikeh create branch main
Created at 1 month ago
create repository
shrikeh create repository
Created at 1 month ago
pull request closed
[Finder] Allow Finder filter to be a callable

Allow filter to be a callable, to allow use of more complex filters a…s classes implementing __invoke(\SplFileInfo $file)

| Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #... | License | MIT | Doc PR | There is currently no 6.3 branch but a PR will be ready to go swiftly.

Currently, the Finder component accepts only Closure as an argument to filter(). This PR widens the method to accept callable, which allows classes that implement __invoke(SplFileInfo $file) to be used as custom filters. In the case where a custom filter is necessary beyond those available through the default set of filters built into the Finder component, it would make sense to also test the filter itself. From a unit test perspective, a class is generally more testable, and has advantages in many cases over anonymous functions in having constructor arguments available, etc.

Created at 2 months ago
issue comment
[Finder] Allow Finder filter to be a callable

I see your point on the breaking change.

Created at 2 months ago
pull request opened
Allow Finder filter to be a callable

Allow filter to be a callable, to allow use of more complex filters a…s classes implementing __invoke(\SplFileInfo $file)

| Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #... | License | MIT | Doc PR | There is currently no 6.3 branch but a PR will be ready to go swiftly.

Currently, the Finder component accepts only Closure as an argument to filter(). This PR widens the method to accept callable, which allows classes that implement __invoke(SplFileInfo $file) to be used as custom filters. In the case where a custom filter is necessary beyond those available through the default set of filters built into the Finder component, it would make sense to also test the filter itself. From a unit test perspective, a class is generally more testable, and has advantages in many cases over anonymous functions in having constructor arguments available, etc.

Created at 2 months ago
Created at 2 months ago

Allow filter to be a callable, to allow use of more complex filters as classes implementing __invoke(\SplFileInfo $file)

Created at 2 months ago
Created at 2 months ago

Allow filter to be a callable, to allow use of more complex filters using __invoke()

Created at 2 months ago

Leverage First-class callable syntax

minor #47751 Norgweiang translations (ibonkonesa)

This PR was merged into the 6.2 branch.

Discussion

Norgweiang translations

| Q | A | ------------- | --- | Branch? | 6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes | Bug fix? | yes/no | New feature? | yes/no | Deprecations? | yes/no | Tickets | Fix #... | License | MIT | Doc PR | symfony/symfony-docs#...

Commits

b6998edbd3 Norgweiang translations

Merge branch '5.4' into 6.0

  • 5.4: [FrameworkBundle] Allow to specify null for exception mapping configuration values Fix BinaryFileResponse content type detection logic [Notifier] [Expo] Throw exception on error-response from expo api Bump Symfony version to 5.4.14 Update VERSION for 5.4.13 Update CHANGELOG for 5.4.13 Bump Symfony version to 4.4.47 Update VERSION for 4.4.46 Update CONTRIBUTORS for 4.4.46 Update CHANGELOG for 4.4.46 [Security] Fix login url matching when app is not run with url rewriting or from a sub folder

fix merge

[Validator] File: add option to check extension

feature #47710 [Validator] File: add option to check extension (dunglas)

This PR was squashed before being merged into the 6.2 branch.

Discussion

[Validator] File: add option to check extension

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | todo

This patch adds an extensions option to the File constraint as an alternative to mimeTypes which checks the mime type of the file, its extension, and the consistency between them.

I have a use case where I want to assert that:

  1. the file is of a given mime type
  2. the file has an extension, the extension is in the allow list, and the extension corresponds with the actual mime type of the content

I added a new extension option to the File constraint to do so.

Usage:

#[File(extensions: 'jpg')] // image.jpg is allowed, image.jpeg isn't, allowed mime types are autodetected, the content of the file is automatically checked
#[File(extensions: ['xml' => ['text/xml', 'application/xml'], 'txt'])] // XML files are allowed as long as the extension is .XML, .txt files are allowed if their mime type is text (allowed mime type are auto-detected)

Commits

1613e55a59 [Validator] File: add option to check extension

bug #47731 [WebProfiler] Fix overflow issue in Forms panel (zolikonta)

This PR was merged into the 4.4 branch.

Discussion

[WebProfiler] Fix overflow issue in Forms panel

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no

Fix overflow issue in WebProfiler Forms panel

Hides overflowing content in the tree view and adds ellipsis to the end. Also adds title attribute with the field names so they get shown fully on hover.

Before: Screenshot 2022-09-29 at 15-49-43 Symfony Profiler After: Screenshot 2022-09-29 at 15-49-44 Symfony Profiler

You might want to consider widening #tree-menu especially in width-full.

This PR applies to 4.4 and 5.4 branch as well not sure about 6.2 though I noticed a redesign but haven't got the chance to check it out.

Thank you

Commits

14712aa947 fix overflow issue in WebPprofiler Forms panel

[WebProfilerBundle] Update the mailer panel

feature #47643 [WebProfilerBundle] Update the mailer panel (javiereguiluz)

This PR was squashed before being merged into the 6.2 branch.

Discussion

[WebProfilerBundle] Update the mailer panel

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Related to #47148, this updates one of the panels which weren't updated in that other PR.

Before - 1 email sent

before-1-email

Before - Multiple emails sent

before-multiple-emails

Before - Email attachments

before-attachment


After - 1 email sent

after-1-email

Comments:

  • All email contents are displayed on the same place, to make debugging quicker
  • All headers are displayed too; this can be long in some cases, but I think it's better to display them all to spot errors easier and quicker
  • Attachments now display file name, file size and a link to download them as files. We no longer display the base64-encoded contents of the file

After - Multiple emails sent

after-multiple-emails

Comments:

  • When there's more than 1 email sent/queued, we display the "Email 1", "Email 2", etc. navigation (which is hidden when there's only 1 email to make design more efficient)

After - MIME parts

after-mime-parts

Comments:

  • This is the same as before

After - Raw message

after-raw-message

Comments:

  • We now include a link to download the raw email as a *.eml file

Commits

eac5aa4f91 [WebProfilerBundle] Update the mailer panel

feature #47460 [Messenger] add dedicated method for disabling instead of passing boolean flags (xabbuh)

This PR was merged into the 6.2 branch.

Discussion

[Messenger] add dedicated method for disabling instead of passing boolean flags

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes (changes #39622) | Deprecations? | no | Tickets | | License | MIT | Doc PR |

Commits

99fac74313 add dedicated method for disabling instead of passing boolean flags

feature #47068 [Messenger] Deprecate MessageHandlerInterface and MessageSubscriberInterface (alamirault)

This PR was merged into the 6.2 branch.

Discussion

[Messenger] Deprecate MessageHandlerInterface and MessageSubscriberInterface

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Fix #43705 | License | MIT | Doc PR | -

Deprecate MessageHandlerInterface and MessageSubscriberInterface, in favor of AsMessageHandler attribute.

Not sure if my work is enough, did I miss something ?

Commits

9b31b9e8ef [Messenger] Deprecate MessageHandlerInterface and MessageSubscriberInterface

feature #47511 [Form][PropertyAccess] Allow optional property accesses (fsoedjede)

This PR was merged into the 6.2 branch.

Discussion

[Form][PropertyAccess] Allow optional property accesses

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | Fix #34483 | License | MIT | Doc PR | symfony/symfony-docs#17288

This PR is basically a copy of #34497 with some minor changes.

I needed it and I have some time now to help advance in implementing it.

TODO

  • [x] Add nullsafe operator usage
  • [x] Update unit test
  • [x] Update documentation

Regards

Commits

6455febec6 feature #34483 - Allow optional property accesses

[FrameworkBundle] Make the Router cache_dir configurable

feature #47496 [FrameworkBundle] Make the Router cache_dir configurable (mpdude)

This PR was squashed before being merged into the 6.2 branch.

Discussion

[FrameworkBundle] Make the Router cache_dir configurable

| Q | A | ------------- | --- | Branch? | 6.2 for features | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#17253

This PR adds a new framework.router.cache_dir configuration setting. It will default to kernel.cache_dir as previously, but makes it possible to easily re-configure the Router's cache directory.

My intended use case is to set it to ~ (null) for the test environment because I need to modify or otherwise dynamically load routes during tests. Another use case I see for it is to have tenant-specific route configurations and caches in multi-tenancy applications.

Commits

dd65d30463 [FrameworkBundle] Make the Router cache_dir configurable

Move the new Security helper to the root of SecurityBundle

Merge branch '6.0' into 6.1

  • 6.0: fix merge [FrameworkBundle] Allow to specify null for exception mapping configuration values Fix BinaryFileResponse content type detection logic [Notifier] [Expo] Throw exception on error-response from expo api Bump Symfony version to 6.0.14 Update VERSION for 6.0.13 Update CHANGELOG for 6.0.13 Bump Symfony version to 5.4.14 Update VERSION for 5.4.13 Update CHANGELOG for 5.4.13 Bump Symfony version to 4.4.47 Update VERSION for 4.4.46 Update CONTRIBUTORS for 4.4.46 Update CHANGELOG for 4.4.46 [Security] Fix login url matching when app is not run with url rewriting or from a sub folder

Merge branch '6.1' into 6.2

  • 6.1: fix merge [FrameworkBundle] Allow to specify null for exception mapping configuration values Fix BinaryFileResponse content type detection logic [Notifier] [Expo] Throw exception on error-response from expo api Bump Symfony version to 6.1.6 Update VERSION for 6.1.5 Update CHANGELOG for 6.1.5 Bump Symfony version to 6.0.14 Update VERSION for 6.0.13 Update CHANGELOG for 6.0.13 Bump Symfony version to 5.4.14 Update VERSION for 5.4.13 Update CHANGELOG for 5.4.13 Bump Symfony version to 4.4.47 Update VERSION for 4.4.46 Update CONTRIBUTORS for 4.4.46 Update CHANGELOG for 4.4.46 [Security] Fix login url matching when app is not run with url rewriting or from a sub folder [symfony/mailjet-mailer] Fix bug #47701

minor #47751 Norgweiang translations (ibonkonesa)

This PR was merged into the 6.2 branch.

Discussion

Norgweiang translations

| Q | A | ------------- | --- | Branch? | 6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes | Bug fix? | yes/no | New feature? | yes/no | Deprecations? | yes/no | Tickets | Fix #... | License | MIT | Doc PR | symfony/symfony-docs#...

Commits

b6998edbd3 Norgweiang translations

skip a test if the mime type detection feature will not work

minor #47762 [HttpFoundation]  skip a test if the mime type detection feature will not work (xabbuh)

This PR was merged into the 4.4 branch.

Discussion

[HttpFoundation]  skip a test if the mime type detection feature will not work

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR |

Commits

47dedf75c1 skip a test if the mime type detection feature will not work

Created at 2 months ago

fix: package.json & yarn.lock to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:

  • https://snyk.io/vuln/SNYK-JS-DEBUG-3227433
Created at 2 months ago
pull request opened
[Snyk] Security upgrade snyk from 1.359.1 to 1.518.0

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • yarn.lock

Vulnerabilities that will be fixed

With an upgrade:

Severity | Priority Score (*) | Issue | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:------------------------- low severity | 461/1000 Why? Recently disclosed, Has a fix available, CVSS 3.5 | Regular Expression Denial of Service (ReDoS) SNYK-JS-DEBUG-3227433 | No | No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Created at 2 months ago
create branch
shrikeh create branch snyk-fix-d0e5dc422309d98e225e24739ed7f091
Created at 2 months ago