Thanks for your review, @theRealAph and @XiaohongGong ! I don't think the GAH failure, i.e. linux-cross-compile / build(arm), is related to this patch.
/integrate
@theRealAph Could you help take another look at this PR? Thanks in advance.
Whitespace is all messed up. try this:
I have updated the patch based on your example. Would you mind taking another look? Thanks!
Remove empty lines in AD files
Co-Developed-by: aph
Fix the following mismatch between cas.m4 and aarch64.ad.
$ m4 cas.m4 > cas.gen.ad
$ sed '8930,9404!d' aarch64.ad > res.ad
$ diff -uN cas.gen.ad res.ad | cat -A
--- cas.gen.ad^I2023-02-20 04:18:46.624289978 +0000$
+++ res.ad^I2023-02-20 04:19:08.780351888 +0000$
@@ -15,7 +15,7 @@$
// This pattern is generated automatically from cas.m4.$
// DO NOT EDIT ANYTHING IN THIS SECTION OF THE FILE$
instruct compareAndExchangeB(iRegINoSp res, indirect mem, iRegI oldval, iRegI newval, rFlagsReg cr) %{$
- $
+$
match(Set res (CompareAndExchangeB mem (Binary oldval newval)));$
ins_cost(2 * VOLATILE_REF_COST);$
effect(TEMP_DEF res, KILL cr);$
...
Besides, update the comment since "aarch_ad_cas.m4" was renamed to "cas.m4".
8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
Reviewed-by: erikj Backport-of: c8a8388aba3dc121bad04aaa123f6cd7525c3d38
8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes
Reviewed-by: fjiang, shade
8298867: Basics.java fails with SSL handshake exception
Reviewed-by: xuelei, rhalade
8163229: several regression tests have a main method that is never executed
Reviewed-by: vromero
8300084: AquaFileChooserUI.getDefaultButton returns null
Reviewed-by: aivanov, serb
8299213: Bad cast in GrowableArrayWithAllocator<>::grow
Reviewed-by: kbarrett, jsjolen, jwaters
8300227: [macos_aarch64] assert(cpu_has("hw.optional.arm.FEAT_AES")) failed after JDK-8297092
Reviewed-by: dholmes
8299576: Reimplement java.io.Bits using VarHandle access
Reviewed-by: uschindler, alanb
8299673: Simplify object pinning interactions with string deduplication
Co-authored-by: Stefan Karlsson stefank@openjdk.org Co-authored-by: Axel Boldt-Christmas aboldtch@openjdk.org Reviewed-by: kbarrett, stefank, dholmes
8300205: Swing test bug8078268 make latch timeout configurable
Reviewed-by: aivanov, serb
8300168: Typo in AccessibleJTableHeaderEntry javadoc
Reviewed-by: psadhukhan, tr
8299323: Allow extended registers for cmpw
Reviewed-by: sviswanathan, kvn
Merge
8298059: Linked stack watermarks don't support nesting
Reviewed-by: stefank Backport-of: b17c52422c91ad1e7ff35844676f6269a1b87f79
8300125: Serial: Remove unused Generation::reset_saved_marks
Reviewed-by: kbarrett, lkorinth
8300228: ModuleReader.find on exploded module throws if resource name maps to invalid file path
Reviewed-by: jpai, chegar, cstein
8300069: Left shift of negative value in share/adlc/dict2.cpp
Reviewed-by: ihse, kbarrett
8300120: Configure should support different defaults for CI/dev build environments
Reviewed-by: erikj
8300184: Optimize ResourceHashtableBase::iterate_all using _number_of_entries
Reviewed-by: dholmes, rehn
8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows
Reviewed-by: alanb
Thanks for your review and test, @dholmes-ora /integrate
This failure occurs on macOS before xnu-8019 version, mainly because the sysctlbyname string names were not introduced before xnu-8019. Take the source code of xnu-7195 [1] as an example.
In this patch, we remove the assertions for the sake of backward compatibility.
Test: In my local test environment, one Macmini with xnu-8020.140.41 and another Macmini with xnu-7195.141.6, fastdebug build can pass now and the CPU features can be detected as expected.
$ ./jdk/bin/java -XX:+PrintFlagsFinal --version | grep SHA
bool UseSHA = true {product} {default}
bool UseSHA1Intrinsics = true {diagnostic} {default}
bool UseSHA256Intrinsics = true {diagnostic} {default}
bool UseSHA3Intrinsics = true {diagnostic} {default}
bool UseSHA512Intrinsics = true {diagnostic} {default}
[1] https://github.com/apple-oss-distributions/xnu/blob/rel/xnu-7195/bsd/kern/kern_mib.c#L855
Filed JDK-8300227
Oops. Thanks for your report. Let me take a look.
8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
Reviewed-by: weijun
8288204: GVN Crash: assert() failed: correct memory chain
Backport-of: 04591595374e84cfbfe38d92bff4409105b28009
8299395: Remove metaprogramming/removeCV.hpp
Reviewed-by: kbarrett, tschatzl
8299437: Make InetSocketAddressHolder shallowly immutable
Reviewed-by: djelinski, jpai, alanb
8291302: ARM32: nmethod entry barriers support
Reviewed-by: eosterlund, rrich, mdoerr, aph
Merge
8294526: sun/security/provider/SubjectCodeSource.java no longer referenced
Reviewed-by: weijun, xuelei
8299520: TestPrintXML.java output error messages in case compare fails
Reviewed-by: mgronlun
8299235: broken link referencing missing id
Reviewed-by: mullan
8298324: Unable to run shell test with make
Reviewed-by: dholmes
8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
Backport-of: 5b5552ff2a5fccaa9a34886d9df4c0075fc8f5e8
8299378: sprintf is deprecated in Xcode 14
Reviewed-by: kbarrett, dholmes
7030853: JDK 7 Serializable Swing classes not compatible with JDK 6
Reviewed-by: serb, aivanov
8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException: assertTrue: expected true, was false"
Reviewed-by: iwalulya, tschatzl
8298601: Refactor archiving of java.lang.Module objects
Reviewed-by: coleenp, ccheung
8299476: PPC64 Zero build fails after JDK-8286302
Reviewed-by: mdoerr
8189338: JMX RMI Remote Mbean server connection hangs if the server stops responding during a SSL Handshake
Reviewed-by: smarks
8299079: Better interface nmethod oop accesses
Co-authored-by: Axel Boldt-Christmas aboldtch@openjdk.org Reviewed-by: kvn, dholmes
8299326: LinkResolver::resolve_field resolved_klass cannot be null
Reviewed-by: iklam, fparain
8299072: java_lang_ref_Reference::clear_referent should be GC agnostic
Co-authored-by: Axel Boldt-Christmas aboldtch@openjdk.org Reviewed-by: dholmes, shade, kbarrett
I don't think the GHA failures are related to the latest commit. Many thanks to all the reviewers! /integrate
Any more comments? Otherwise, I'll integrate later.