salathe
Repos
51
Followers
108
Following
13

User-contributed examples

40
5

PHP Documentation Sources (English)

18
3

Source files and a setup for converting PHP's XML documentation into presentation formats like HTML.

6
2

PHD

0
0

The PHP people system

0
0

Events

push

typofix: interal -> internal

minor changes for internaliterator

  • add final modifier
  • add xi:include for constructor
  • fix interface markup
Created at 1 week ago
pull request closed
Uninstall
Created at 2 weeks ago
issue comment
Use even more &alias; entities

A few more to do:

  • reference/solr/solrdocument/reset.xml: <refpurpose>This is an alias to SolrDocument::clear()</refpurpose>
  • reference/solr/solrparams/add.xml: <refpurpose>This is an alias for SolrParams::addParam</refpurpose>
  • reference/solr/solrparams/get.xml: <refpurpose>This is an alias for SolrParams::getParam</refpurpose>
Created at 3 weeks ago
issue comment
Use the alias entity everywhere

Use the alias entity everywhere

Missed a few in mysqli and xdiff.

Created at 3 weeks ago
issue comment
Client side validation of form-user

That is supposed to be an email address...

If that's the case, maybe change the label (currently "Your email address (or name):") as well, and the server-side validation.
If it's not the case (i.e. can be email or a plain name), thumbs down on this change.

Created at 3 weeks ago
pull request closed
Clarify Exception constructor for PHP 5

See: https://github.com/php/doc-en/issues/1793

Draft for clarifying why the constructor signature doesn't work for PHP 5, and why we're not documenting older versions.

Created at 3 weeks ago
issue comment
Clarify Exception constructor for PHP 5

This constructor signature applies only to PHP 7.0 and higher.

Redundant. The PHP Manual, particularly any "prototypes" and associated descriptions, only applies (at the time of writing this) to PHP 7.0.0 and higher. Any vestiges in the descriptions, examples, etc. are just yet to be tidied up: the last remaining widespread reference to undocumented versions is the "versions list" at the top of many pages where "PHP 5" is still present.

The documentation for unsupported PHP versions has been discontinued.

How, in any way, would this be considered reasonable to add, particularly in the Exception constructor description. (Note: rhetorical question.) Even if it were being added in a reasonable place, it's factually incorrect. The PHP Manual does document unsupported PHP versions, just not all of them, and not forever.

Rejecting this Pull Request as unsuitable. Discussion can, and probably should, continue in Issue #1793.

Created at 3 weeks ago
issue comment
Use CSS variables for some common colors

@salathe What setup are you using to test these changes, btw?

I just checked out web-php and ran the built-in web server (e.g. php -S 127.0.0.1:8080 .router.php).

I decided to add a new variable --medium-magenta-color and rename the previous one --dark-magenta-color.

Cool, fine by me. 👍

Created at 4 weeks ago
issue comment
inconsistency in enum documentation

The same enum is used in the manual as well: https://www.php.net/manual/en/language.enumerations.examples.php

Created at 4 weeks ago
issue comment
Update DateTime format table for easier to read.

I'm :-1: on this change. The examples are supplementary to the other columns (in this case, format and description), and IMO should not be given higher reading priority than the required reading (to clarify: the description column is required reading).

If still planning to go ahead with this change, I have a few requests:

  • Resolve the merge conflicts
  • Have a plan (if not in this PR, then a separate Issue/PR) for changing the columns in other similar tables throughout the manual (I haven't checked, but would guesstimate maybe a dozen or so).
Created at 1 month ago

disable email-note-summaries and event-weekly-email from master

These are done via maintain-main.

Created at 1 month ago
issue comment
Using time() in its own example

See also #1747

Created at 1 month ago
issue comment
[PHP 8.2] Deprecate `utf8_*` functions

It would be good to point readers at the alternatives / replacements.

Created at 1 month ago

redirect php.net/hrtime to function rather than pecl ext (thanks Benjamin)

fix number of ? in IN clause

Bug was introduced in a3dcbf63da.

Created at 1 month ago

autoload path for email-note-summaries

Created at 1 month ago