robbat2
Repos
107
Followers
60
Following
29

Events

Fix parsing of inet[/127.0.0.1:9200]

CLA is signed already, bot is wrong

Created at 6 days ago
pull request opened
Fix parsing of inet[/127.0.0.1:9200]

Detected while upgrading application from elasticsearch-transport-1.0.6 to elastic-transport-8

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 6 days ago

sniffer: fix parsing of inet[hostname/ip:port]

Prior to commit 53f37cb7ef147ab51a04a4562885e234f9e8bbf1, publish_address of the format inet[hostname/ip:port] worked correctly.

When the sniffer code was refactored, this format broke, and is an easy fix to restore.

Fixes: https://github.com/elastic/elastic-transport-ruby/issues/48 Signed-off-by: Robin H. Johnson robbat2@gentoo.org

sniffer: fix empty hostname like inet[/127.0.0.1:9200]

Fixes: https://github.com/elastic/elastic-transport-ruby/issues/48 Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 6 days ago
robbat2 create branch rjohnson/fix-parsing
Created at 6 days ago
publish_address ipv4 is mis-parsed as ipv6, leading to a undefined nil access and failure

```(REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/sniffer.rb:82:in parse_publish_address': undefined method []' for nil:NilClass (NoMethodError)


curl -s http://localhost:9200/_nodes |jq '.nodes|to_entries|first|.value|.http.publish_address'

"inet[/127.0.0.1:9200]"


This leads to a failure in parse_publish_address
 8: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/base.rb:99:in `reload_connections!'
 7: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/sniffer.rb:46:in `hosts'
 6: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/timeout-0.3.2/lib/timeout.rb:196:in `timeout'
 5: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/timeout-0.3.2/lib/timeout.rb:189:in `block in timeout'
 4: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/sniffer.rb:49:in `block in hosts'
 3: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/sniffer.rb:49:in `map'
 2: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/sniffer.rb:49:in `each'
 1: from (REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/sniffer.rb:51:in `block (2 levels) in hosts'

(REDACTED)/vendor/bundle/ruby/2.7.0/gems/elastic-transport-8.2.0/lib/elastic/transport/transport/sniffer.rb:82:in parse_publish_address': undefined method []' for nil:NilClass (NoMethodError)

                                    
Created at 6 days ago
create branch
robbat2 create branch robbat2/workflow-validation
Created at 1 week ago
pull request opened
testSimple: debugging flakey test

Per IRC, tweaks to make it easier to debug flakey behavior in testSimple.

testSimple (portage.tests.emerge.test_simple.SimpleEmergeTestCase.testSimple) ... emerge: superuser access is required

This PR should show:

  1. What user the tests actually run as
  2. Individual parts of testSimple, because there are a LOT of them, despite the name.

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 1 week ago

s4cmd: avoid AttributeError on newer botocore

Newer botocore has removed vendored entirely; try to import carefully. Makes s4cmd work again on botocore-1.29.84.

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.10/s4cmd", line 33, in <module>
    sys.exit(load_entry_point('s4cmd==2.1.0', 'console_scripts', 's4cmd')())
  File "/usr/lib/python-exec/python3.10/s4cmd", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/lib64/python-exec/python3.10/s4cmd.py", line 255, in <module>
    class BotoClient(object):
  File "/usr/lib64/python-exec/python3.10/s4cmd.py", line 274, in BotoClient
    botocore.vendored.requests.packages.urllib3.exceptions.ReadTimeoutError,
AttributeError: module 'botocore' has no attribute 'vendored'

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 1 week ago
pull request opened
s4cmd: avoid AttributeError on newer botocore

Newer botocore has removed vendored entirely; try to import carefully. Makes s4cmd work again on botocore-1.29.84.

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.10/s4cmd", line 33, in <module>
    sys.exit(load_entry_point('s4cmd==2.1.0', 'console_scripts', 's4cmd')())
  File "/usr/lib/python-exec/python3.10/s4cmd", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/lib64/python-exec/python3.10/s4cmd.py", line 255, in <module>
    class BotoClient(object):
  File "/usr/lib64/python-exec/python3.10/s4cmd.py", line 274, in BotoClient
    botocore.vendored.requests.packages.urllib3.exceptions.ReadTimeoutError,
AttributeError: module 'botocore' has no attribute 'vendored'

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 1 week ago
create branch
robbat2 create branch botocore-vendored-fix
Created at 1 week ago
Created at 1 week ago
Created at 1 week ago
started
Created at 1 week ago

tagmail: Support Net::SMTP 0.1.0 shipped with puppetserver:7.9.2

https://hub.docker.com/layers/puppet/puppetserver/7.9.2/images/sha256-1511a483c8b320cefa324fbeede428e0888329bd430f90c689198483dbdd2476?context=explore still ships with Net::SMTP 0.1.0

So support the older way of calling Net::SMTP as well.

Seperate commit, so this can be reverted when a newer Net::SMTP is default.

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 2 weeks ago

Revert "manifests/package: improve emerge command default"

This reverts commit 0534d65d3ef352bc4ca6028e585d209e048f7b42.

portage::package: try another way to avoid undefined warning

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 2 weeks ago

tagmail: Support Net::SMTP 0.1.0 shipped with puppetserver:7.9.2

https://hub.docker.com/layers/puppet/puppetserver/7.9.2/images/sha256-1511a483c8b320cefa324fbeede428e0888329bd430f90c689198483dbdd2476?context=explore still ships with Net::SMTP 0.1.0

So support the older way of calling Net::SMTP as well.

Seperate commit, so this can be reverted when a newer Net::SMTP is default.

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 2 weeks ago
pull request closed
dev-vcs/git: remove unused patches
Created at 2 weeks ago
issue comment
dev-vcs/git: remove unused patches

Similar change already merged

Created at 2 weeks ago
tagmail: implement SMTP TLS & authentication

Deeper testing shows one surprising issue: the method signature of Net::SMTP.start has changed a lot, and puppetserver ships a very old version of it, so the above code is correct for net-snmp:0.3.3, but not older versions. Don't merge it yet.

Created at 2 weeks ago

manifests/package: improve emerge command default

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 2 weeks ago
pull request opened
PMS: Add variables

Change variables to match PMS and extract from $PF

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 3 weeks ago
create branch
robbat2 create branch pms
Created at 3 weeks ago
Created at 3 weeks ago
pull request opened
tagmail: implement SMTP TLS & authentication

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 3 weeks ago

tagmail: implement SMTP TLS & authentication

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 3 weeks ago

tagmail: implement SMTP TLS & authentication

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Created at 3 weeks ago
robbat2 create branch smtpauth
Created at 3 weeks ago

Fix IP6 forwarding test

Commit 17f1828 accidentally inverted the check for IP6 forwarding on Linux – check_ip6_forwarding returns 0 when forwarding is enabled.

Merge pull request #204 from jetomit/fix-ip6-forwarding-check

Fix IP6 forwarding test

Created at 3 weeks ago