ro0NL
Repos
3
Followers
70

Events

pull request reopened
Bump php from 7.4.28-fpm to 8.1.5-fpm

Bumps php from 7.4.28-fpm to 8.1.5-fpm.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Created at 4 hours ago
ro0NL create branch dependabot/docker/php-8.1.5-fpm
Created at 4 hours ago
Undo ignore this dependency

we've ignored php8 when running php7, now that we've updated to php8 we don't get any dependabot alerts still

that ignore should be invalidated automatically once updated IMHO, and is a rather annoying bug currently

Created at 5 hours ago
issue comment
[RFC] Translatable HTTP response payloads

invoking translator service is relatively easy also :+1:

Created at 8 hours ago
issue comment
Edit documentation that splat operator can't be used along with autowiring.

it's probably best to provide a reproducer: https://symfony.com/doc/current/contributing/code/reproducer.html

Created at 3 days ago
closed issue
[RFC] Translatable HTTP exceptions

Description

This would solve #49653 and also play nice with #[WithHttpStatus(4xx)].

The idea is any HttpException can be given a translatable message:

throw new HttpException(400, t('id'));

~Im just not sure if the normalizer should expose any translatable message, or just 4xx ones.~ edit: actually i think translatable messages should always be exposed, even 5xx responses could use some helpful hints for the user :sweat_smile:

but then the line between what's exposed, and what's not becomes super thin, so maybe this needs a new new ExposedHttpException() / new HttpException(expose: true)

Example

No response

Created at 3 days ago
issue comment
[RFC] Translatable HTTP exceptions

closing in favor of #49138, that's sufficient.

see also https://github.com/symfony/symfony/pull/49138#discussion_r1136221587

Created at 3 days ago
issue comment
[RFC] AbstractController::noContent(): Response

i figured 200 + json null / empty string is just fine also :)

Created at 3 days ago
closed issue
[RFC] AbstractController::noContent(): Response

Description

Hi,

in #49518 i realized we have 2 ways of handling null as a controller result

  1. json encode as null + http 200
  2. no content + http 204

i figured having a controller utility builtin creates better autocompletion due the use of $this->... already

considering #49518, this allows doing:

#[Serialize(201)]
endpoint(): mixed {
    if ($someSpecialCase) {
        return $this->noContent(); // 204
    }

    return $someOtherSpecialCase ? ['data' => true] : null; // 201
}

Example

No response

Created at 3 days ago
issue comment
Edit documentation that splat operator can't be used along with autowiring.

just tested 6.2.7 real quick, and i get empty array for variadic arg by default with autowiring ... as expected kinda.

so i believe it works actually :shrug:

Created at 4 days ago
issue comment
[HttpFoundation] Allow Request#request to be ParameterBag

@ddr5292 please open an issue if you believe anything's wrong still.

Created at 4 days ago
issue comment
fix: Add array to return of InputBag::get

But how to test is given key is array or scalar value.

you know what your application expects

getting the raw value is done using all()['key']. Please open a doc PR if it's unclear.

Created at 4 days ago
issue comment
fix: Add array to return of InputBag::get

a deprecation breaks your code?

Created at 4 days ago
issue comment
Edit documentation that splat operator can't be used along with autowiring.

IIUC it should be possible to provide nothing for the variadic arg during autowiring :thinking: https://3v4l.org/rST30

i believe nullable args that cant be autowired are also skipped

Created at 4 days ago

Update README.md

Created at 5 days ago

Update README.md

Created at 5 days ago

Update composer.json

Created at 5 days ago

Delete AsyncBundle

Delete .php_cs

Update composer.json

Update WorkerClass.php

Merge remote-tracking branch 'origin/2.10'

Created at 5 days ago
delete branch
ro0NL delete branch 2.9
Created at 5 days ago
ro0NL create tag v2.10.0
Created at 5 days ago
create branch
ro0NL create branch 2.10
Created at 5 days ago

Update WorkerClass.php

Created at 5 days ago

Update composer.json

Created at 5 days ago

Delete .php_cs

Created at 5 days ago

Delete AsyncBundle

Created at 5 days ago
reopened issue
[RFC] AbstractController::noContent(): Response

Description

Hi,

in #49518 i realized we have 2 ways of handling null as a controller result

  1. json encode as null + http 200
  2. no content + http 204

i figured having a controller utility builtin creates better autocompletion due the use of $this->... already

considering #49518, this allows doing:

#[Serialize(201)]
endpoint(): mixed {
    if ($someSpecialCase) {
        return $this->noContent(); // 204
    }

    return $someOtherSpecialCase ? ['data' => true] : null; // 201
}

Example

No response

Created at 5 days ago
closed issue
[RFC] AbstractController::noContent(): Response

Description

Hi,

in #49518 i realized we have 2 ways of handling null as a controller result

  1. json encode as null + http 200
  2. no content + http 204

i figured having a controller utility builtin creates better autocompletion due the use of $this->... already

considering #49518, this allows doing:

#[Serialize(201)]
endpoint(): mixed {
    if ($someSpecialCase) {
        return $this->noContent(); // 204
    }

    return $someOtherSpecialCase ? ['data' => true] : null; // 201
}

Example

No response

Created at 5 days ago
issue comment
[RFC] AbstractController::noContent(): Response

well, the AbstractController is already a response factory in disguise, and 204 is a relatively common case :shrug:

but i understand we're abusing AbstractController its purpose maybe? though i thought its purpose was to act as a HTTP DSL sort of speak

my idea was self-discovery mostly:

a controller utility builtin creates better autocompletion due the use of $this->... already

Created at 5 days ago