rahul2393
Repos
46
Followers
7

Events

incorporate requested changes

Created at 2 days ago

incorporate review comment

Created at 4 days ago
create branch
rahul2393 create branch add-fgac-samples
Created at 4 days ago
spannertest: column names are case sensitive unlike real cloud spanner

@harshachinta please look into this.

Created at 4 days ago
Spanner: getting the unsupported sampler while keeping the session alive

Client

go-spanner

Environment

GKE

Go Environment

$ go version 1.18.1

Using https://pkg.go.dev/cloud.google.com/go/spanner v1.30.0

Code go library for Spanner suggests that there is no need to handle session on our own and we are not doing any of the thing on our own. It's the HealthCheckWorker which is doing all of the things on it's own.

Expected behavior

There should not be any error while executing Select 1 .

Actual behavior Getting Below error starting span "cloud.google.com/go/spanner.ping": unsupported sampler: 0x9f1c00

Below is the traceback

go.opentelemetry.io/otel.(*delegator).Handle
	/app/vendor/go.opentelemetry.io/otel/handler.go:44
go.opentelemetry.io/otel.Handle
	/app/vendor/go.opentelemetry.io/otel/handler.go:96
go.opentelemetry.io/otel/bridge/opencensus/internal.(*Tracer).StartSpan
	/app/vendor/go.opentelemetry.io/otel/bridge/opencensus/internal/tracer.go:42
go.opencensus.io/trace.StartSpan
	/app/vendor/go.opencensus.io/trace/trace_api.go:56
cloud.google.com/go/spanner.(*session).ping
	/app/vendor/cloud.google.com/go/spanner/session.go:233
cloud.google.com/go/spanner.(*healthChecker).healthCheck
	/app/vendor/cloud.google.com/go/spanner/session.go:1465
cloud.google.com/go/spanner.(*healthChecker).worker
	/app/vendor/cloud.google.com/go/spanner/session.go:1563

Additional context This issue seems to be fixed here but still we are getting this issue.

Created at 4 days ago
Spanner: getting the unsupported sampler while keeping the session alive

This seems like a dupe of https://github.com/googleapis/google-cloud-go/issues/4237 so I will close out this issue. The implementations for most OpenTelemetry services are not yet stable. This is especially true in Go where tracing is currently still in RC, metrics are alpha, and logging does not exist. As the project matures over time we will continue to evaluate if it is right to integrate with it.

Source: https://opentelemetry.io/docs/go/

Created at 1 week ago
Spanner: getting the unsupported sampler while keeping the session alive

@harshit-bci The issue is happening because of OpenTelemetry limitation here https://github.com/open-telemetry/opentelemetry-go/tree/main/bridge/opencensus#incompatibilities to support samplers.

While we are looking into possible solutions out there but it would make more sense if you open a ticket here https://github.com/open-telemetry/opentelemetry-go/issues/new?assignees=&labels=bug&template=bug_report.md&title= because we don't support OpenTelemetry in Go Client libraries yet.

Created at 1 week ago
Spanner: getting the unsupported sampler while keeping the session alive

Back to your question on handling sessions, Go client library is handling the sessions fine in your application, its just not able to trace a specific method using OpenTelemetry, I think the error reported in issue is safe to ignore and should not be impacting any database operations.

Created at 1 week ago
Spanner: getting the unsupported sampler while keeping the session alive

Thanks @harshit-bci for letting us know about this. From initial debugging seems like you are using OpenTelemetry and using bridge to convert from opencensus traces,

Error particularly is coming from the bridge code https://github.com/open-telemetry/opentelemetry-go/blob/1f5e6adbf2ca8fdb394ea07b3370506889a10bfa/bridge/opencensus/internal/oc2otel/tracer_start_options.go#L43, Let me try to find the fix to support OpenTelemetry in Spanner.

We already have a open ticket to support OpenTelemetry for traces here https://github.com/googleapis/google-cloud-go/issues/4237.

Created at 1 week ago

fix sample checkstyles

Created at 1 week ago
pull request opened
feat(spanner): add samples for fine grained access control

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Created at 1 week ago
create branch
rahul2393 create branch add-fgac-samples
Created at 1 week ago
rahul2393 create branch go-gorm-samples-dev
Created at 1 week ago

add more samples

Created at 1 week ago
create branch
rahul2393 create branch cmek-proto-changes
Created at 1 week ago
spanner: TestOCStats_SessionPool failed

Note: #6801 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 53a0f9dc7e78fdae158794ee79708fbd1ec0bab2 buildURL: Build Status, Sponge status: failed

Created at 1 week ago

feat(spanner): add support for Proto Columns (#6886)

  • feat(spanner): Adding support for Proto Message and Proto Enum

  • feat(spanner): Add license header to new files

  • code refactoring and additional checks

  • nit: code changes

  • go.mod update to prevent failing builds

  • go.mod update to prevent failing builds

  • go.mod and build_samples.sh update to prevent failing builds

  • revert back grpc version

  • revert back changes

  • Using standard Singers example, refactoring redundant code

  • code and proto refactoring

  • Add proto_type_fqn for Proto Message and Proto Enum

  • code refactoring

  • go mod tidy: go.mod and go.sum version updates

  • add changes to support compatibility between Int64 and Enum & compatibility between Bytes and Proto

  • Revert "go mod tidy: go.mod and go.sum version updates"

This reverts commit 484b00c15967bc9697be5bdea7c0d83cadf323c2.

  • add Integration Tests for Proto Message, Proto Enum, compatibility tests

  • code refactoring

  • code refactoring

  • add unit tests for nil proto types

  • Add error when nil proto message or nil enum is passed

feat(spanner): add support for handling null value in Proto columns (#6954)

  • feat(spanner): add support for handling null value in Proto columns

  • code refactor: get protoTypeFqn from user defined nil types

  • code refactoring

  • code refactoring

  • code refactoring

  • code refactoring

  • Add tests for MarshalJSON and UnmarshalJSON methods

  • refactoring test file

  • code refactoring

feat(spanner): add support for Array of Proto columns (#7014)

  • feat(spanner): add support for array of proto columns

  • refactoring comments and added negative test cases while reading array of protos

  • change decoding logic of handling array of proto columns

feat(spanner): add support for handling null values in array of proto columns (#7042)

  • feat(spanner): add support for handling null values in Array of Proto Columns

  • add comments for code readability

  • nit: change in error message

feat(spanner): Modify configuration for integration test and add license header (#7059)

Merge branch 'proto-column-enhancement-alpha'

Conflicts:

spanner/go.sum

spanner/value_test.go

Created at 2 weeks ago

test(storage): split out some of the object tests (#7000)

  • test(storage): split out some of the object tests

  • add uuids to objects

Co-authored-by: Chris Cotter cjcotter@google.com

feat(maps/routing): start generating apiv2 (#7056)

chore: release main (#7020)

test(storage): fix flaky grpc tests (#7057)

Fixes #6910, #6963, #6859

Created at 2 weeks ago

feat(spanner): add support for Proto Columns (#6886)

  • feat(spanner): Adding support for Proto Message and Proto Enum

  • feat(spanner): Add license header to new files

  • code refactoring and additional checks

  • nit: code changes

  • go.mod update to prevent failing builds

  • go.mod update to prevent failing builds

  • go.mod and build_samples.sh update to prevent failing builds

  • revert back grpc version

  • revert back changes

  • Using standard Singers example, refactoring redundant code

  • code and proto refactoring

  • Add proto_type_fqn for Proto Message and Proto Enum

  • code refactoring

  • go mod tidy: go.mod and go.sum version updates

  • add changes to support compatibility between Int64 and Enum & compatibility between Bytes and Proto

  • Revert "go mod tidy: go.mod and go.sum version updates"

This reverts commit 484b00c15967bc9697be5bdea7c0d83cadf323c2.

  • add Integration Tests for Proto Message, Proto Enum, compatibility tests

  • code refactoring

  • code refactoring

  • add unit tests for nil proto types

  • Add error when nil proto message or nil enum is passed

feat(spanner): add support for handling null value in Proto columns (#6954)

  • feat(spanner): add support for handling null value in Proto columns

  • code refactor: get protoTypeFqn from user defined nil types

  • code refactoring

  • code refactoring

  • code refactoring

  • code refactoring

  • Add tests for MarshalJSON and UnmarshalJSON methods

  • refactoring test file

  • code refactoring

feat(spanner): add support for Array of Proto columns (#7014)

  • feat(spanner): add support for array of proto columns

  • refactoring comments and added negative test cases while reading array of protos

  • change decoding logic of handling array of proto columns

Merge branch 'proto-column-enhancement-alpha'

Conflicts:

spanner/go.sum

spanner/value_test.go

Created at 2 weeks ago