petertseng
Repos
69
Followers
143
Following
2

Events

issue comment
cargo running dotests by default causes error

I also only have one version of rustc/cargo installed, so the cause of having two instances of rustc/cargo installed cannot possibly apply to me either.

Created at 2 hours ago
issue comment
cargo running dotests by default causes error

That is a good idea! I see that the latest Cargo and rustc version are 1.67.0 so I installed those:

[pt@concept/resistor-color]$ cargo --version
cargo 1.67.0
[pt@concept/resistor-color]$ rustc --version
rustc 1.67.0 (fc594f156 2023-01-24)

Now I will run the tests.

[pt@concept/resistor-color]$ cargo test -- --include-ignored
   Compiling proc-macro2 v1.0.46
   Compiling unicode-ident v1.0.5
   Compiling quote v1.0.21
   Compiling syn v1.0.102
   Compiling serde v1.0.145
   Compiling thiserror v1.0.37
   Compiling once_cell v1.15.0
   Compiling toml v0.5.9
   Compiling thiserror-impl v1.0.37
   Compiling enum-iterator-derive v1.1.0
   Compiling enum-iterator v1.2.0
   Compiling proc-macro-crate v1.2.1
   Compiling int-enum-impl v0.5.0
   Compiling int-enum v0.5.0
   Compiling resistor-color v1.0.0 (/home/pt/src/exercism/rust/exercises/concept/resistor-color)
    Finished test [unoptimized + debuginfo] target(s) in 28.49s
     Running unittests src/lib.rs (target/debug/deps/resistor_color-665f3046ff950ed0)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/resistor-color.rs (target/debug/deps/resistor_color-93f77d07f408f253)

running 8 tests
test test_2 ... ok
test test_11_out_of_range ... ok
test test_8 ... ok
test test_6 ... ok
test test_orange ... ok
test test_white ... ok
test test_black ... ok
test test_all_colors ... ok

test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests resistor-color

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Okay, so it looks like the problem is fixed with Cargo 1.67.0.

If we can figure out the cause of the issue, then we can put in a fix. Any information is valuable in helping figuring out the cause.

Created at 2 hours ago
issue comment
Intention behind not updating a Queen Attack test

Honestly though that means that one of the two cases (2, 2), (0, 4) or (2, 2), (3, 1) should be changed too, since they are obviously going to be testing the same diagonal as well (since they both contain (2, 2). That should also get submitted to problem-specifications.

Created at 4 hours ago
issue comment
Intention behind not updating a Queen Attack test

(For those who aren't following along, the mathematics behind it is that a rising diagonal is expressed as y = x + b, and a falling diagonal is expressed as y = -x + b)

Created at 4 hours ago
issue comment
Intention behind not updating a Queen Attack test

I must have had a different idea of what constitutes "different diagonals" than the submitter of https://github.com/exercism/problem-specifications/pull/1504. If we look at (2, 2) in relation to the four different values it's being compared against: (0, 4), (3, 1), (1, 1), (5, 5), we have: (LT, GT), (GT, LT), (LT, LT), (GT, GT). But if it were changed to (1, 7) vs (0, 6), well that's a (LT, LT) and then we don't have a (GT, GT) case, and that doesn't make sense to me.

But I see from reading https://github.com/exercism/problem-specifications/pull/1504 this allows a different problem, because the important part isn't really their relative positions; it's about testing two different rising/falling diagonals. However I think if the Haskell track takes this case, we should use (0, 6) vs (1, 7) instead of (1, 7) vs (0, 6), so that we still have a (GT, GT) case.

Created at 4 hours ago
issue comment
test: add unit test for sum-of-multiples

When community contributions are reopened these tests should be submitted to https://github.com/exercism/problem-specifications/blob/main/exercises/sum-of-multiples/canonical-data.json instead of only to the Rust track. The reason is we do not want to gain a reputation for being selfish and hogging improvements only to ourselves. We give back to others and share with others.

Created at 5 hours ago
Add book-store test case

~~Reminder to merge this when https://github.com/exercism/problem-specifications/pull/2181 is merged.~~ Oops, that doesn't make sense, This IS #2181. I made a mistake when posting the above comment. Please ignore it.

Created at 5 hours ago
Add book-store test case

Reminder to merge this when https://github.com/exercism/problem-specifications/pull/2181 is merged.

Created at 5 hours ago

hello-world: Show how to run the tests in the instructions (#1618)

The track never introduces how to run tests to the student.

It is described in the HELP file but I believe that file is meant for you to check when you get lost solving the exercise.

It should continue to contain the more detailed information on how to run tests IMO but the basic command I believe should be a part of the README.

Created at 5 hours ago
pull request closed
hello-world: Show how to run the tests in the instructions

Hi, this is an update to the Hello World exercise of the Rust track. The track never introduces how to run tests to the user. It is described in the HELP file but I believe that file is meant for you to check when you get lost solving the exercise? It should continue to contain the more detailed information on how to run tests IMO but the basic command I believe should be a part of the README.

Created at 5 hours ago
issue comment
Say states max value of u64 is 9 quintillion when it should be 18 quintillion

We are awaiting anyone to open a pull request fixing this.

Created at 5 hours ago

hello-world: Show how to run the tests in the instructions

The track never introduces how to run tests to the student.

It is described in the HELP file but I believe that file is meant for you to check when you get lost solving the exercise.

It should continue to contain the more detailed information on how to run tests IMO but the basic command I believe should be a part of the README.

Created at 5 hours ago
pull request reopened
Show how to run the tests in the exercise readme

Hi, this is an update to the Hello World exercise of the Rust track. The track never introduces how to run tests to the user. It is described in the HELP file but I believe that file is meant for you to check when you get lost solving the exercise? It should continue to contain the more detailed information on how to run tests IMO but the basic command I believe should be a part of the README.

Created at 5 hours ago
issue comment
Show how to run the tests in the exercise readme

Since instructions.md has to be the exact same text as https://github.com/exercism/problem-specifications/blob/main/exercises/hello-world/description.md, it won't be possible to include language-specific instruction like cargo test in here, but I think it would be appropriate to instead create the file exercises/practice/hello-world/.docs/instructions.append.md saying something like the following:

In the Rust track, tests are run using the command cargo test.

That will get these instructions to appear on the instructions page, and not violate the rule about instructions.md have to be exactly the same as problem-specifications!

Created at 5 hours ago

tuples: Fix broken link (#1596)

Created at 5 hours ago
pull request closed
tuples: Fix broken link
Created at 5 hours ago
pull request reopened
tuples: Fix broken link
Created at 5 hours ago
issue comment
tuples: Fix broken link

I may be able to get the tests to run by closing and reopening the pull request.

Created at 5 hours ago
pull request closed
tuples: Fix broken link
Created at 5 hours ago

build(deps): update actions/checkout from 3.1.0 to 3.3.0

Update actions/checkout from 3.1.0 to 3.3.0.


updated-dependencies:

  • dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

tests: Label all actions/checkout with their version

Merge pull request #1617 from exercism/dependabot/github_actions/actions/checkout-3.3.0

build(deps): update actions/checkout from 3.1.0 to 3.3.0

Created at 5 hours ago
delete branch
petertseng delete branch dependabot/github_actions/actions/checkout-3.3.0
Created at 5 hours ago
pull request closed
build(deps): update actions/checkout from 3.1.0 to 3.3.0

Bumps actions/checkout from 3.1.0 to 3.3.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Created at 5 hours ago

Update introduction.md

grains approaches: fix incorrect exponent (#1619)

Fix the wrong power of two that gives us 8.

Was 2 to the power of 4 = 8 Changed to 2 to the power of 3 = 8

ocr-numbers: Fix broken source url (#1613)

build(deps): update actions/checkout from 3.1.0 to 3.3.0

Update actions/checkout from 3.1.0 to 3.3.0.


updated-dependencies:

  • dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

tests: Label all actions/checkout with their version

Created at 5 hours ago