peakle
Repos
43
Followers
4

Delivery club go linter

33
1

Lightweight worker pool for go

5
1

Go group ratelimiter

2
1

Events

revert slice preallocation limited by break

Created at 17 hours ago

add another one prealloc

Created at 1 day ago
pull request opened
Perfomance: add preallocation for some slices

What is this feature?

Add preallocations for slices to decrease number of calls to the go allocator / OS api and thereby reduce the program execution time. It's little part of https://github.com/grafana/grafana/pull/59118 PR.

Why do we need this feature?

It's perfomance improvement.

Who is this feature for?

-

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Created at 1 day ago

add preallocation for some slices

Created at 1 day ago
Created at 2 days ago

Plugins: Make the Plugin Details page reusable (#58741)

  • refactor(PluginDetails): use react-router hooks instead of props

  • Wip

  • refactor: remove unnecessary constant

  • feat: use the original plugin details page under connections

  • chore: use better wording in the not-found warning

Co-authored-by: Jack Westbrook jack.westbrook@gmail.com

  • chore: use the renderer utility everywhere in the test

  • chore: don't show a title while loading a plugin

Co-authored-by: Jack Westbrook jack.westbrook@gmail.com

Merge https://github.com/grafana/grafana into prealloc_part

Created at 2 days ago

Feat: Adding an optional browser config option to e2e test runner (#59076)

Adding an optional browser config option to e2e test runner

Chore: Refactor the packages/jaeger-ui-components/src/model folder to TS (#59233)

Chore: Refactor transform-trace-data.test.js to TS (#59214)

Chore: Remove unused method from sqlstore (#59156)

remove unused method

Azure Monitor: Fix empty/errored responses for Logs variables (#59240)

TraceView: Fix broken rendering when scrolling in Dashboard panel in Firefox (#56642)

SQLStore: Refactor query retries to use exponential backoff (#58559)

PanelChrome: Implementing the new layout on PanelChrome @ grafana/ui (#57203)

  • Use newPanelChromeUI feature flag in DashboardPanel panel rendering

  • just render the PanelChromeUI instead of the PanelChrome

  • add new props to PanelChrome; have ChromePanel from grafana/ui in DashboardPanel for testing (will remove before finished);

  • put icons next to the title of PanelChrome header space

  • arrange PanelChrome's title icons into view/edit/status sections

  • icons next to title in PanelChrome are surrounded by square focusable space

  • items to be render in Header in PanelChrome come in as props

  • PanelChrome accepts items next to title from the outside; currently them being ordered in the left side is okay, right side not so much

  • revert local changes to DashboardPanel

  • cleanup unused imports

  • simple PanelChrome render without any header props

  • CSS function

  • add test PanelChrome prop padding

  • add icons next to title if they are passed to PanelChrome

  • fixed PanelChrome header: hoverHeader, having a menu prop;

  • only show icons with correct icon names; show menu icon only on hover over panel container; minor other fixes

  • attempt to resolve hovering in an RTL test for the menu icon to work as expected

  • menu opens in a Dropdown if provided as prop

  • fixing tooltips and aria-labels

  • Fixed issue with light theme in storybook

  • comment out props and tests that are not yet used

  • Fixed issue where content was overflowing the boundaries

Co-authored-by: Torkel Ödegaard torkel@grafana.com

PostgreSQL: Fix missing CA field from configuration (#59280)

  • PostgreSQL: Fix missing CA field from configuration

CI: Remove npm steps from enterprise pipelines (#59108)

Remove npm steps from enterprise pipelines

Logs: Fix misalignment of LogRows (#59279)

  • add default display flex

  • changed to text-align: left

GrafanaUI: Add disabled option for menu items (#58980)

TimeseriesPanel: Preserve string fields for data link interpolation (#58424)

  • TimeseriesPanel: Preserve string fields for data link interpolation

  • clean code

  • Modify tests so that string fields are allowed only when a valid time/number dataframe exists

  • performance mods

  • fix wrong length

  • remove console.log

  • Check if aligned dataframe has links

Scenes: Add support for Datasource variables (#59147)

Nested Folders: Some API fixes (#59298)

  • Nested Folders: Fix API responses

  • Fix panic during deletions

  • Add test

Update jest monorepo to v29 (#58261)

  • Update jest monorepo to v29

  • update snapshots + wrap test in act

  • fix linting errors: jest.mocked now defaults to deep mocking

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison ashley.harrison@grafana.com

Storage: Add system users service (#57767)

  • Storage: Add access for reporting

  • reporting upload user per org

  • add some basic comments

  • Move reporting storage to enterprise

  • add comments

Co-authored-by: Artur Wierzbicki artur.wierzbicki@grafana.com

CI: Make the downstream enterprise test a check instead of comments (#59071)

Navigation: Support rbac for new dashboard, import dashboard and new folder (#59303)

RBAC: Support rbac for new dashboard, import dashboard and new folder page

Access Control: Clear user's permission cache after resource creation (#59101)

  • refresh user's permission cache after resource creation

  • clear the cache instead of reloading the permissions

  • don't error if can't clear cache

  • fix tests

  • fix tests again

Created at 2 days ago

LDAP: Make LDAP attribute mapping case-insensitive (#58992)

  • Make LDAP attribute mapping case-insensitive

  • Add test case with attribute name different from schema's

  • Add fix to getArrayAttribute also and add test with mismatched letter case.

  • Update pkg/services/ldap/helpers.go

Co-authored-by: Misi mgyongyosi@users.noreply.github.com

yarn: commit files to make yarn-install reproducible (#55979)

Loki: Add gzip compression to resource calls (#59059)

  • Loki: Add compression to callResource

  • add missing tests

  • fix formatting

DataSourceWithBackend - Set postResource method to POST (#59114)

Set postResource method to POST

codegen: Refactor core jennies for reusability, add version-picking metajennies (#58995)

  • Add each-major jenny, refactor TS jenny for it

  • Introduce LatestJenny, refactor GoTypesJenny for it

Chore: Document theme toggle keybinding (#59031)

  • make theme toggle keybinding dev only

  • fix bug + add support for theme change keybinding

Chore: Fix status codes for nested folders (#59087)

  • check for errutil errors first

  • a better fix

Chore: Refactor UiFindInput.test.js to TypeScript (#59063)

Chore: Refactor CopyIcon.test.js to TS (#59024)

CloudWatch: fix custom namespace for listing dimension keys, refactor to non-pointer types, add test assertions, rename packages (#59106)

Co-authored-by: Erik Sundell erik.sundell87@gmail.com

Scenes: Add custom variable support (#59057)

Azure Monitor: Fix namespace selection for storageaccounts (#56449)

Azure Monitor: Fix resource picker selection for subresources (#56392)

Preferences: Add confirmation modal when saving org preferences (#59119)

Explore: Skip flaky query history test (#59135)

Skip flaky query history test

Alerting: Enable interpolation for notification policies in file provisioning (#58956)

Build: Add command to publish to AWS Marketplace through the pipeline (#59068)

  • Remove generic variables from publish github action

  • Create publish aws cmd to automate aws releases

  • Add tests to publish aws cmd

  • Replace fmt with log for prints

  • Remove unnecessary type assertions

  • Readd mistakenly removed go package

  • Replace log with fmt for prints due to conflicts

  • Update github tests to conform with casing

Chore: add some unique keys to prevent warnings (#59143)

add some unique keys to prevent warnings

Navigation: share logic between buildBreadcrumbs and usePageTitle (#58819)

  • simplify usePageTitle logic a bit

  • use buildBreadcrumbs logic in usePageTitle

  • always add home item to navTree, fix some tests

  • fix remaining unit tests

Server: Switch from separate server & cli to a unified grafana binary (#58286)

  • avoid the need for a second bulky binary for grafana-cli

  • look for grafana-server in $PATH as well as same directory

  • implement unified "grafana" command

  • update dockerfiles, fix grafana-cli -v

  • update packaging to work with single binary

  • add wrapper scripts for grafana and grafana-server
  • update and sync package files
  • implement --sign flag of build package command
  • stop packaging scripts folder, they are not useful for end users
  • add support for --configOverrides in server command
  • remove unused nfpm.yaml config file
  • windows support
Created at 3 days ago
pull request opened
Perfomance: add preallocation for some slices

What is this feature?

Add preallocations for slices to decrease number of calls to the go allocator / OS api and thereby reduce the program execution time. It's little part of https://github.com/grafana/grafana/pull/59118 PR.

Why do we need this feature?

It's perfomance improvement.

Who is this feature for?

-

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Created at 1 week ago
create branch
peakle create branch prealloc_part
Created at 1 week ago

revert prealloc for azure monitoring

Created at 1 week ago

revert preallocation checked in test for nil

Created at 1 week ago
issue comment
Add prealloc linter and fix related allocation issues

i see that TestAlertManagers_buildRedactedAMs test failed because it have check for nil, should i revert code changes or update test?

Created at 1 week ago
issue comment
Add prealloc linter and fix related allocation issues

i can slice changes in few parts, if it difficult to read

Created at 1 week ago

revert difficult place

Created at 1 week ago
pull request opened
Add prealloc linter and fix related allocation issues

What is this feature?

Added prealloc linter for find preallocation issues on ci. Fix related allocation issues for slice/maps. This change allows us to reduce number of comments to PRs and write better codebase. Preallocations - decrease number of calls to the go allocator / OS api and thereby reduce the program execution time.

Why do we need this feature?

It will reduce number of comments to PRs and increase perfomance.

Who is this feature for?

It's perfomance improvement.

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Created at 1 week ago

add prealloc linter and fix related allocation issues

Created at 1 week ago

Docs: Add step for custom labels in alert form (#59027)

LoginAttempt: Move logic around login attempts into the service (#58962)

  • LoginAttemps: Remove from sqlstore mock

  • LoginAttemps: Move from models package to service package

  • LoginAttemps: Implement functionallity from brute force login in service

  • LoginAttemps: Call service

  • LoginAttempts: Update name and remove internal functions

  • LoginAttempts: Add tests

  • LoginAttempt: Add service fake

  • LoginAttempt: Register service as a background_services and remove job from cleanup service

  • LoginAttemps: Remove result from command struct

  • LoginAttempt: No longer pass pointers

Accessibility: Improve keyboard accessibility in Collapse (#59022)

fix keyboard accessibility in Collapse

Alerting: add group name validation in alert rule form (#59095)

Add group name validation in alert rule form

Docs: adds workaround for editing provisioned rules using the HTTP API (#59094)

  • Docs: adds workaround for editing provisioned rules using api

  • updates text

  • updates text take two

Nested Folder: Include URL into the GET response (#59099)

Internationalization: Change locale preference to language (#58359)

  • backend locale -> language

  • frontend locale -> language

  • sample.ini and tests

  • fix few last locale -> language

  • fix few last locale -> language

Performance: add preallocation for some slice/map (#57860)

This change preallocates slices and maps where the size of the data is known before the object is created.

Co-authored-by: Joe Blubaugh joe.blubaugh@grafana.com

Created at 1 week ago

revert failing issue

Created at 1 week ago

build(deps): bump github.com/kyoh86/exportloopref from 0.1.8 to 0.1.9 (#3317)

build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.20.0 to 1.21.1 (#3318)

Co-authored-by: Fernandez Ludovic ldez@users.noreply.github.com

chore: add changelog

build(deps): bump golangci/golangci-lint-action from 3.2.0 to 3.3.0 (#3323)

build(deps): bump github.com/daixiang0/gci from 0.8.1 to 0.8.2 (#3330)

build(deps): bump github.com/sivchari/tenv from 1.7.0 to 1.7.1 (#3331)

build(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.1 (#3332)

build(deps): bump github.com/Abirdcfly/dupword from 0.0.7 to 0.0.8 (#3333)

build(deps): bump github.com/spf13/cobra from 1.6.0 to 1.6.1 (#3334)

build(deps): bump postcss from 8.4.16 to 8.4.18 in /docs (#3340)

build(deps): bump gatsby-plugin-emotion from 7.21.0 to 7.24.0 in /docs (#3341)

build(deps): bump gatsby-plugin-sitemap from 5.21.0 to 5.24.0 in /docs (#3342)

build(deps): bump gatsby-plugin-sharp from 4.19.0 to 4.24.0 in /docs (#3343)

docs: fix typo in nolint (#3345)

build(deps): bump ansi-regex from 4.1.0 to 5.0.1 in /docs (#3344)

doc: improve Editor Integration section (#3307)

build(deps): bump github.com/shirou/gopsutil/v3 from 3.22.9 to 3.22.10 (#3347)

build(deps): bump github.com/sourcegraph/go-diff to HEAD (#3350)

build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 in /docs (#3352)

chore: Add a clarifying note to the bug report template (#3355)

Co-authored-by: Fernandez Ludovic ldez@users.noreply.github.com

Created at 1 week ago

Variables: SceneVariable update process (#57784)

  • First baby steps

  • First baby steps

  • No progress really

  • Updates

  • no progress

  • refactoring

  • Progress on sub menu and value selectors

  • Some more tweaks

  • Lots of progress

  • Progress

  • Updates

  • Progress

  • Tweaks

  • Updates

  • Updates to variable system

  • Cleaner tests

  • Update

  • Some cleanup

  • correct test name

  • Renames and moves

  • prop rename

  • Fixed scene template interpolator

  • More tests for SceneObjectBase and fixed issue in EventBus

  • Updates

  • More tweaks

  • More refinements

  • Fixed test

  • Added test to EventBus

  • Clone all scene object arrays

  • Simplify

  • tried to merge issue

  • Update

  • added more comments to interface

  • temp progress

  • Trying to simplify things, but struggling a bit

  • Updated

  • Tweaks

  • Progress on fixing the select componenet and typing, and sharing code in a base class

  • Updated

  • Multi select

  • Simpler loading state

  • Update

  • removed failOnConsole

  • Removed old funcs

  • Moved logic from update manage to MultiValueVariable

  • Added tests for MultiValueVariable logic

  • Made value a more abstract concept to support object values

  • renamed func to getValueText

  • Refactored and moved logic to VariableSet

  • Added test for deactivation and query cancelling

  • Tweaks

  • Fixed lint issues

GoogleCloudMonitoring: use typed struct in newInstanceSettings (#58440)

Navigation: Expose new props to extend Page/PluginPage (#58465)

  • add extensions and customisation to Page

  • adjust alignment

Alerting: Reorder tests in classic_test.go (#58425)

Scene: ObjectVariable for supporting the built in system variables and object scoped variables (__data for example) (#58291)

  • Scene: Adds ObjectVariable to support the built-in/system variables

  • fixed lint issue

Loki: Rename log browser to label browser (#58416)

  • rename loki log browser to label browser

  • rename loki log browser to label browser

Alerting: Small improvements to staleResultsHandler (#58007)

feat(loki-monaco-editor): update e2e test with autocomplete steps (#58455)

  • feat(loki-monaco-editor): update e2e test with autocomplete steps

  • Chore: replace typing method

  • Test simpler POC test

  • Chore: refactor test

  • Chore: use selector to get the editor value

Echo: Add config option to prevent duplicate page views for GA4 (#57619)

Elasticsearch: fix typo (#58519)

Docs: Replace toolkit command to scaffold plugins with create-plugin (#58462)

  • Replace command to scaffold plugin with create-plugin

  • Change link text

Navigation: Convert PluginDetails page to use new Page extensions (#58509)

  • Added labels

  • App page fixes

  • Switch to switch

  • wip

  • Updates

  • I am stuck

  • Minor tweak

  • This props interface could work

  • removed change

  • use new page extensions in plugin details page

  • add link separator, fix action button spacing

  • some renaming

  • Move PageInfo into it's own folder + add tests

  • add support for new props in old page header

  • remove PluginDetailsHeader as it's no longer used

  • Fix unit tests

  • fix some badge alignments

  • center align actions

  • badge alignment + only show downloads for community/commercial plugins

  • better link alignment

  • conditionally render description

  • move install control warnings to below subtitle + refactor

Co-authored-by: Torkel Ödegaard torkel@grafana.com

Plugins: CallResource: Use canonical MIME headers when writing response (#58506)

  • Plugins: CallResource: use canonical MIME headers when writing response

  • Plugins: add tests for canonical mime headers and Set-Cookie filter

  • Removed extra new line

Alerting: Change TestConditionsCmd to assert on mathexp.Results (#58434)

Docs: adjusts topics to align with task templates (#58478)

  • updates topic to align with multiple task template

  • updates goal intro

  • aligns formatting with single task topic template

  • Update docs/sources/administration/team-management/index.md

Co-authored-by: Kim Nylander 104772500+knylander-grafana@users.noreply.github.com

  • adds permissions requirements to two tasks

Co-authored-by: Kim Nylander 104772500+knylander-grafana@users.noreply.github.com

Chore: Use strings.ReplaceAll and preallocate containers (#58483)

Alerting: Improve debug logs in image service (#58507)

Alerting: Fix images cached on rule instead of dashboard panel signature (#58510)

adjusts the stem sentence (#58538)

Chore: Retry queries by default in tests (#58535)

Created at 1 week ago
issue comment
fix: use first issue without inline on mergeLineIssues on multiplie issues

@ldez ping

Created at 2 weeks ago
issue comment
Perfomance: add preallocation for some slice/map

@joeblubaugh do i need to rollback this places?

Created at 3 weeks ago
issue comment
Perfomance: add preallocation for some slice/map

@joeblubaugh any updates?

Created at 3 weeks ago
issue comment
fix: use first issue without inline on mergeLineIssues on multiplie issues

@ldez , @alexandear any updates?

Created at 3 weeks ago
pull request closed
add install.sh for download release binaries
Created at 1 month ago