Primary source of truth for the Docker "Official Images" program
Private PaaS built on native AWS services for maximum privacy and minimum upkeep
This breaks the typescript return type. I need to do some further digging on this fix. Making it draft for now.
Thanks for the historic info @jason-vault I've only installed this into our app yesterday and hadn't looked through the previous PRs. This seems like a pretty big bug to get into production, a little worrying on first install! 😅 Although, I'm happy my approach was the same as the original. I'll patch it too for now. Hopefully it's fixed soon. Thanks again.
When calling remove()
on the listener added via Intercom.addEventListener()
a recursion error was being thrown.
useEffect(() => {
const { remove } = Intercom.addEventListener(IntercomEvents.IntercomUnreadCountDidChange, ({ count }) => {
setUnreadIntercomMessageCount(count);
});
return remove;
}, []);
Fix maximum call stack size exceeded
When calling remove() on the listener added via Intercom.addEventListener() a recursion error was being thrown
Thanks @Kudo for the fix, and thanks @timhooker for filing the bug report. This has been a blocker for me upgrading to 48. 👍🏻
Match cast field name to migration
This looks like an oversight.
Use subDays to determine what should be pruned
I've been using this fork for over a year, it works well.
Support Laravel 10
This is using laravel shift's upgrade branch of graham-campbell/manager until it has been merged
In Laravel 9 it is possible to use a DB::raw()
expression for the column (as below). In Laravel 10 this results in an error as DB::raw()
can no longer be parsed as a string using __toString()
it must now go through the database grammar ie. DB::raw()->getValue(DB::connection()->getQueryGrammar())
// Worked in L9
public function getCustomPaths()
{
return [
[
'name' => 'alias_path',
'column' => DB::raw(
'COALESCE(asset.assetName, (select alias from material where id = asset.material_id))'
),
'separator' => ' » ',
],
];
}
This results in PHP str_contains
throwing an error
str_contains(): Argument #1 ($haystack) must be of type string, Illuminate\Database\Query\Expression given
at vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:568
564▕ * @return string
565▕ */
566▕ public function qualifyColumn($column)
567▕ {
➜ 568▕ if (str_contains($column, '.')) {
569▕ return $column;
570▕ }
571▕
572▕ return $this->getTable().'.'.$column;
Using ->getValue(DB::connection()->getQueryGrammar())
as the column
value, then creates a column not found
error.
Any ideas on how to get around this? I'm trying to stay away from creating a dynamic column on the table if I can.
Fantastic work @staudenmeir! Thanks so much
Hi @staudenmeir, thanks for the quick reply.
I've altered the code like this
In Laravel 9 it is possible to use a DB::raw()
expression for the column (as below). In Laravel 10 this results in an error as DB::raw()
can no longer be parsed as a string using __toString()
it must now go through the database grammar ie. DB::raw()->getValue(DB::connection()->getQueryGrammar())
// Worked in L9
public function getCustomPaths()
{
return [
[
'name' => 'alias_path',
'column' => DB::raw(
'COALESCE(user.name (select title from company where id = user.company_id))'
),
'separator' => ' » ',
],
];
}
This results in PHP str_contains
throwing an error
str_contains(): Argument #1 ($haystack) must be of type string, Illuminate\Database\Query\Expression given
at vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:568
564▕ * @return string
565▕ */
566▕ public function qualifyColumn($column)
567▕ {
➜ 568▕ if (str_contains($column, '.')) {
569▕ return $column;
570▕ }
571▕
572▕ return $this->getTable().'.'.$column;
Using ->getValue(DB::connection()->getQueryGrammar())
as the column
value, then creates a column not found
.
Any ideas on how to get around this? I'm trying to stay away from creating a dynamic column on user if I can.
I've added PHP 8.2 to the test matrix, and added back in the stability of lowest and stable
All test are now passing https://github.com/patrickomeara/php-stemmer/actions/runs/4129148443
Test both lowest and stable dependencies