oh-my-fish
Repos
159

The Fish Shell Framework

8806
742

A Powerline-style, Git-aware fish theme optimized for awesome.

1312
194

Run foreign bash scripts and capture exported environment variables

163
10

Provides interactive word expansions in real-time

48
6

Primary Oh My Fish package repository.

184
120

Events

Created at 5 hours ago

Fix cutting of paths with equals signs

Cut splits by equals sign and takes the second field. This ignores path contents after a second equals sign. Currently this prevents the installation on NixOS as the nix store path automatically contains a "=".

This PR instead selects all but the first field and equals sign, leaving the passed paths as intended.

Created at 9 hours ago
pull request closed
Fix cutting of paths with equals signs

Description

In the install script paths containing equals signs (e.g. as argument to the --offline flag) are truncated. cut is set to split by equals sign and take the second field. This ignores path contents after a second equals sign. Currently this prevents the installation on NixOS as the nix store path automatically contains a "=" and is used as offline source.

This PR instead selects all but the first field and equals sign, leaving the passed paths as intended.

Note: It also fixes similar errors caused by path arguments containing an equals sign.

Environment report

Oh My Fish version:   7
OS type:              Linux
Fish version:         fish, version 3.4.1
Git version:          git version 2.36.0
Git core.autocrlf:    no
Checking for a sane environment...
Your shell is ready to swim.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] New and existing tests pass locally with my changes
  • [x] I have updated the SHA256 checksum for the install script
Created at 9 hours ago
Created at 10 hours ago
Created at 10 hours ago
Created at 13 hours ago
Created at 14 hours ago
Created at 15 hours ago
Created at 16 hours ago
Created at 18 hours ago
Created at 18 hours ago
Created at 1 day ago
Created at 1 day ago
closed issue
Slack status badge not shown properly in Readme.md

Slack status badge not shown properly in Readme.md on Github, see screenshot:

Created at 1 day ago
issue comment
Slack status badge not shown properly in Readme.md

Fixed in #883

Created at 1 day ago
pull request closed
fix: Remove broken link/badge to Slack

Description

Remove broken link to Slack app/badge

Fixes #839

Created at 1 day ago
issue comment
fix: Remove broken link/badge to Slack

Solved by #883.

Created at 1 day ago
pull request closed
workflow: Include macos-12 to the matrix
Created at 1 day ago

workflow: Include macos-12 to the matrix

Created at 1 day ago
pull request opened
workflow: Include macos-12 to the matrix
Created at 1 day ago
delete branch
scorphus delete branch fix-pacakges-name-regex
Created at 1 day ago
pull request closed
omf.packages.name: Fix regex by escaping a dot

Description

With this change, omf.packages.name escapes a dot that was matching any character and extracting partial names from names or URLs.

Fixes #901

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] ~~I have commented my code, particularly in hard-to-understand areas~~
  • [ ] ~~I have made corresponding changes to the documentation~~
  • [ ] New and existing tests pass locally with my changes
  • [ ] ~~I have updated the SHA256 checksum for the install script~~
Created at 1 day ago
closed issue
omf remove doesn't remove non omf plugins

I installed a custom plugin omf install https://github.com/wfxr/forgit works fine. I installed grc omf install grc grc now has some conflicts.

type -a grc                                                                                                                Sun May 22 12:04:51 2022
grc is a function with definition
# Defined via `source`
function grc --wraps=forgit::revert::commit --description 'alias grc forgit::revert::commit'
  forgit::revert::commit $argv;
end
grc is /usr/local/bin/grc

this is fine, I could just remove the forgit grc function. However I decided to not use forgit, so I wanted to uninstall it.

 ~ omf remove forgit                                                                                                              forgit could not be found.
 ~ omf remove https://github.com/wfxr/forgit                                                                                  https://github.com/wfxr/forgit is not a valid package/theme name

I uninstalled it manually and removed it from bundle.

I don't know if this is a bug or working as intended, I'd assumed that omf would be able to uninstall a non-omf plugin.

Environment report

Sun May 22 12:01:53 2022
Oh My Fish version:   7
OS type:              Darwin
Fish version:         fish, version 3.4.1
Git version:          git version 2.36.1
Git core.autocrlf:    no
Checking for a sane environment...
Your shell is ready to swim.
Created at 1 day ago

omf.packages.name: Fix regex by escaping a dot

Fix #901

Created at 1 day ago

workflow: Add brew to path for Ubuntu

workflow: Add ubuntu-20.04 to OS group

workflow: Use actions/checkout@3

Create OMF_PATH when installing offline

Fix #787

Remove leading path element when extracting tarball

Ref.: #787

omf.packages.name: Fix regex by escaping a dot

Fix #901

Created at 1 day ago
pull request closed
Install offline

Fixes #787

Created at 1 day ago
closed issue
Installation from tarball failed

Hi,

I'm trying to make offline installation to work for my offline environment. I decided to install omf from tarball. It looks like your script cannot open archive for whatever reason:


root@snd01pc00:/home/snd01-admin/shares/repository/packages/oh-my-fish# fish install --offline=oh-my-fish-7.tar.gz --path=~/.local/share/omf --config=~/.config/omf --noninteractive --verbose
DEBUG: verbose turned on
Checking for a sane environment...
DEBUG: Command 'awk' is /usr/bin/gawk
DEBUG: Command 'basename' is /usr/bin/basename
DEBUG: Command 'cp' is /bin/cp
DEBUG: Command 'cut' is /usr/bin/cut
DEBUG: Command 'date' is /bin/date
DEBUG: Command 'dirname' is /usr/bin/dirname
DEBUG: Command 'env' is /usr/bin/env
DEBUG: Command 'fish' is /usr/bin/fish
DEBUG: Command 'fold' is /usr/bin/fold
DEBUG: Command 'head' is /usr/bin/head
DEBUG: Command 'mkdir' is /bin/mkdir
DEBUG: Command 'mv' is /bin/mv
DEBUG: Command 'readlink' is /bin/readlink
DEBUG: Command 'rm' is /bin/rm
DEBUG: Command 'sed' is /bin/sed
DEBUG: Command 'sort' is /usr/bin/sort
DEBUG: Command 'tar' is /bin/tar
DEBUG: Command 'tr' is /usr/bin/tr
DEBUG: Command 'which' is /bin/which
DEBUG: Checking for a sane 'head' implementation
DEBUG: Checking for a sane 'sort' implementation
DEBUG: Checking for a working AWK interpreter
DEBUG: Verifying Git implementation is not buggy Git for Windows
DEBUG: Verifying Git autocrlf is not enabled
Installing Oh My Fish to /root/.local/share/omf...
Offline path is a file, assuming tar archive...
tar: /root/.local/share/omf: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
Install aborted: Could not extract tar file oh-my-fish-7.tar.gz

Oh My Fish installation failed.

If you think that it's a bug, please open an
issue with the complete installation log here:

http://github.com/oh-my-fish/oh-my-fish/issues


Could you please help me debug this problem?

Created at 1 day ago

Create OMF_PATH when installing offline

Fix #787

Remove leading path element when extracting tarball

Ref.: #787

Created at 1 day ago
pull request closed
Fix workflow
Created at 1 day ago