obetomuniz
Repos
13
Followers
588
Following
12

A pluggable, simple, and powerful web scraper.

62
3

Semantic Web Autocomplete for Atom Editor

47
1

A curated list of awesome Web Components tools, articles and resources.

553
43

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.

53753
9990

Events

opened issue
Allow renaming the Query Editor button "Run queries"

What happened:

I am instancing a single Prometheus Query Editor in my plugin using dataSource.components.QueryEditor, but its built-in button label to run a query is hardcoded to "Run queries". Since I am instancing only one Query Editor, I would like to label it as "Run query" to be semantically aligned with the usage.

What you expected to happen:

Add a new property to allow renaming the built-in button that runs a query in the Query Editor to something like:

Or any other value.

How to reproduce it (as minimally and precisely as possible):

Instance a Prometheus Query Editor (e.g. dataSource.components.QueryEditor) to see the proper button. You will see a "Run queries" button, but you can't change its label.

Anything else we need to know?:

Environment: MacOS

  • Grafana version: v9.4.0-pre
  • Data source type & version: Prometheus
  • OS Grafana is installed on: MacOS / Docker
  • User OS & Browser: Chrome
  • Grafana plugins:
  • Others:
Created at 3 weeks ago

Fix redirect rule

Created at 1 month ago

Fix sitemap generator

Created at 1 month ago

Fix styling heading

Created at 1 month ago

Improve alignments

Created at 1 month ago

Apply CSS tweaks

Created at 1 month ago

Add AWC as project

Created at 1 month ago

Improve grammar

Created at 1 month ago

Remove unnecessary ENV VARS

Fix regex in vercel.json redirects

Created at 1 month ago

Update README.md

Created at 1 month ago

Update README.md

Created at 1 month ago

Update website

Created at 1 month ago

Remove Twitter

Use Mastodon as Main microblogging

Created at 1 month ago

Remove Newsletter since Revue is being closed

Created at 1 month ago

Replace Protocolo Alterado to Ei! DEV

Created at 1 month ago

Add Mastodon Social

Created at 1 month ago

Update README.md

Created at 1 month ago

Update README.md

Created at 1 month ago

Update README.md

Created at 2 months ago
Created at 2 months ago
delete branch
obetomuniz delete branch betomuniz/fix-graphite-builder-toggler-with-metric-name-boolean
Created at 2 months ago

Graphite: Allow metric name to use true/false as name (#57996)

Created at 2 months ago
closed issue
A boolean in a metric name breaks toggle edit mode

@itsmylife update September 20, 2022 Description: In Graphite datasource, when you have true/false as metric you cannot toggle between editor mode and visual mode. Acceptance Criteria: Even if you have metrics with name false/true both editors should keep working. Toggling between editors should be working. Status: It is kind of a feature request to me. The parser is responsible for parsing the query. I believe on line #71 we can add || this.match('bool') and it will work. But there must be some changes for the visual editor to show false/true as segments. Which is being handled here: https://github.com/grafana/grafana/blob/main/public/app/plugins/datasource/graphite/state/helpers.ts#L32-L42 Also, the assignee of this task should consider the outcome of this change and also investigate why in the first place this wasn't added.


What happened: When a segment of a metric name is a boolean true or false, toggle edit mode does not work (in the direction from unstructured to structured query). No network queries or JS errors when this happens. See video repro: https://www.dropbox.com/s/jndtdhfsiv9vn14/Grafana-bug.mp4?dl=0

What you expected to happen: Having a boolean as part of a metric name would not affect anything.

How to reproduce it (as minimally and precisely as possible): Try to render an existing Graphite metric metric.test.false. Try toggling edit mode back and forth.

Anything else we need to know?: Nope.

Environment:

  • Grafana version: v6.3.4 (a557646)
  • Data source type & version: Graphite, included in Grafana image
  • OS Grafana is installed on: official Docker image grafana/grafana:6.3.4
  • User OS & Browser: MacOS 10.14.6 (18G103), Chrome Version 78.0.3904.97 (Official Build) (64-bit)
  • Grafana plugins: grafana-piechart-panel
Created at 2 months ago
pull request closed
Graphite: Allow metric name to use true/false as name

What is this feature?

This PR fixes the query builder toggler flow to work when a metric name uses boolean values (e.g. true or false) as the name.

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/grafana/issues/20349

Special notes for your reviewer:

Before this change, some segments were being arbitrarily removed in the Visual Mode when no queries were being returned or "unexpected" values like the matric names using boolean values as the name. It creates confusion for the users, since in the Code Mode segments present all values, even the ones unnecessarily removed in Visual Mode.

https://user-images.githubusercontent.com/1680157/199263857-b8cea215-413f-4500-a1a3-5db1e4e3f72e.mov

Created at 2 months ago
started
Created at 3 months ago