noahdietz
Repos
83
Followers
67
Following
3

Generate Go API client libraries from Protocol Buffers.

184
38

A lightweight proxy that connects gRPC to HTTP/1.1

52
10

An API that demonstrates Generated API Client (GAPIC) features and common API patterns used by Google.

131
38

Google Cloud Client Libraries for Go.

3112
1018

API Improvement Proposals. https://aip.dev/

715
275

A linter for APIs defined in protocol buffers.

401
97

Events

closed issue
Verify that resource referenced in request field has pattern(s) present in google.api.http annotations

When an RPC has a resource name in its request, the name is often used as part of the HTTP binding. For example:

service FooService {
  rpc GetFoo(GetFooRequest) returns (Foo) {
    option (google.api.http) = {
      get: "v1/{name=projects/*/foos/*}"
    };
  };
}

message GetFooRequest {
  // Format: projects/{project}/foos/{foo}
  string name = 1 [(google.api.resource_reference).type = "foo.googleapis.com/Foo"];
}

message Foo {
  option (google.api.resource) = {
    type: "foo.googleapis.com/Foo"
    pattern: "projects/{project}/foos/{foo}"
  };

  string name = 1;
}

Here, GetFooRequest.name field is used to populate a section of the HTTP Request path. That field references a resource definition that defines a resource name pattern. The linter should enforce that the expected pattern(s) present in the google.api.http path can be found in the google.api.resource annotation for the referenced resource.

Created at 1 day ago
issue comment
Verify that resource referenced in request field has pattern(s) present in google.api.http annotations

Fixed by #1045. Will be in the next release. Closing this as the other case of child_type references in the google.api.http annotation is covered by #1047. Thank you @acamadeo

Created at 1 day ago

feat(AIP-127): HTTP variable templates must match resource pattern (#1045)

Created at 1 day ago
pull request closed
feat: Validate that HTTP variable templates match resource pattern definitions (AIP-127)

Part of #972

Created at 1 day ago
issue comment
feat: Validate that HTTP variable templates match resource pattern definitions (AIP-127)

Great job @acamadeo thank you for your hard work on this.

Created at 1 day ago
delete branch
noahdietz delete branch require-descriptor
Created at 2 days ago

feat: require Problem to have Descriptor (#1046)

Created at 2 days ago
pull request closed
feat: require Problem to have Descriptor

The lint framework depends on each Problem reporting the Descriptor that created the Problem for information such as source code location and leading comments (e.g. for local rule exceptions). Parts of the framework work on the assumption that Descriptor will always be present on the Problem. This is a fair assumption to make and we should enforce it, returning an error if a Problem is reported without a Descriptor. There is no reason not to include the Descriptor.

Created at 2 days ago

feat(internal/gapicgen): summarize regapic tool

Created at 2 days ago
noahdietz create branch sumregapic
Created at 2 days ago

chore(httpreplay): specify localhost for proxy listener (#7088)

closes: #7087

fix(logging): fix stdout log http request format (#7083)

feat(vmwareengine): start generating apiv1 (#7093)

test(pubsublite): fix flaky TestIntegration_PublishSubscribeSinglePartition (#7098)

feat(bigquery): add default partition expiration to Dataset (#7096)

Resolves #7021

Created at 2 days ago
pull request opened
feat: require Problem to have Descriptor

The lint framework depends on each Problem reporting the Descriptor that created the Problem for information such as source code location and leading comments (i.e. for local rule exceptions). Parts of the framework work on the assumption that Descriptor will always be present on the Problem. This is a fair assumption to make and we should enforce it, returning an error if a Problem is reported without a Descriptor. There is no reason not to include the Descriptor.

Created at 2 days ago
create branch
noahdietz create branch require-descriptor
Created at 2 days ago
pull request closed
feat: generate call descriptors and use startApiCall

This refactors the generated client implementation to use the startApiCall invoker from gax. This also includes generation of extra call descriptors in the config files that described the call type and all properties.

This is an entirely internal refactor and does not affect the public surface.

Created at 2 days ago
feat: generate call descriptors and use startApiCall

Closing this PR as we've decided to move these changes to the separate v2 client. @dwsupplee will be migrating the work.

Created at 2 days ago
pull request closed
feat: refactor resource helpers into trait
Created at 2 days ago