nmarulo
Repos
21
Followers
53
Following
41

Sistema de gestión de contenidos

22
6

Generador de facturas en pdf

1
3

Utilidades php

0
0

NPedidos es una aplicación que permite la gestión simple de pedidos de menús de comidas, por fechas.

0
3

Despensa-app es una aplicación que te permite gestionar productos que compras de forma habitual.

1
0

Events

Correcciones menores

Nuevo: Clases base para los test de los Service

Nuevo: Test básico de la clase "FoodDishService"

Created at 15 hours ago
closed issue
Crear representación del fichero properties

Crear una clase llama AppProperties en el paquete red.softn.npedidos.configuration que represente las propiedades que empiezan por app del fichero application.properties.

Luego reemplazar las propiedades usadas en las clases WebSecurityConfig y AppConfig.

Created at 19 hours ago

🌟Added a new configuration property file to allow quick access to application properties inside code.

♻️Using application properties bean to apply OpenAPI initial configuration.

♻️Using application properties bean to apply Spring security config including JWT OAuth2 settings.

🏗Added comments in application property file to group properties by type.

🔍Imported AppProperties config inside tests.

🔍Imported AppProperties config only in abstract controller test case.

Merge branch 'master' of https://github.com/juanguirp/rest-api into feature/fix_issue_1

Merge pull request #6 from juanguirp/feature/fix_issue_1

Feature/fix issue 1

Created at 19 hours ago
pull request closed
Feature/fix issue 1

Fixed: #1 - Added new configuration class to access to application properties in code, refactoring two classes to use it.

In this PR you will find this changes:

  • feature: New AppProperties configuration class with property values.
  • refactor: Use new config class inside OpenAPI settings instead of own values in the AppConfig class.
  • refactor: Use new config class inside Security settings instead of own values in the WebSecurityConfig class.
  • config: Properties are grouped in application.properties file using comments (TODO: Validate this change before merge).
Created at 19 hours ago
issue comment
Feature/fix issue 1

@juanguirp

Al revisarlo es mejor agregar la clase AppProperties al @Import de la clase AControllerTest.

Puedes hacer ese cambio, por favor.

También, subí una corrección para que actualices tu rama, ya que tengo un error CI.

Created at 20 hours ago

Correcciones: github workflows

  • Se agrega un workflow para los Pull Request.
  • maven.yml => build.yml
  • Se elimina el evento pull_request del fichero build.yml
Created at 20 hours ago
issue comment
Crear representación del fichero properties

Lo he visto brevemente y se ve correcto. 👏 En cuanto tenga un momento lo reviso bien.

Y sobre los comentarios del fichero application.properties, me parece genial, muchas gracias. 😄

Created at 1 day ago
Created at 1 day ago
issue comment
Crear representación del fichero properties

Hola @juanguirp, todo tuyo. 👍

Created at 1 day ago

Eliminado: carpeta .mvn

  • Y se quita del gitignore

Cambios menores

Actualizado: README.md

  • Agregado badge de deepsource.
  • Se agrega información básica para trabajar con el proyecto.
Created at 1 day ago

Se habilita test-coverage en deepsource

Formateo de código

Actualizado: .editorconfig

  • Se modifica la indentación para ficheros "toml".
  • Otros cambios agregados por IntelliJ automáticamente.
Created at 1 day ago
issue comment
Add English translation

Hello 👋, thanks for your suggestion. I have yet to finish writing the readme, after that, if I could consider adding a translation. If you are interested, I could notify you when it is ready to translate.

Created at 1 day ago
issue comment
Error en el encoding al leer un valor del fichero properties

Thanks to you for your interest and help. 😄

Created at 1 day ago

up

up

Merge remote-tracking branch 'origin/master'

Created at 2 days ago

Update maven.yml

Created at 2 days ago

Update maven.yml

Created at 2 days ago

Create maven.yml

Created at 2 days ago
create branch
nmarulo create branch master
Created at 2 days ago
create repository
nmarulo create repository
Created at 2 days ago
issue comment
Error en el encoding al leer un valor del fichero properties

Hello @chinmaym07, thank you for your help on issue #3. 😄 As this project is small, I don't have many tasks to delegate, even so, I am creating these issues to help those who are doing the event. If this week nobody shows up and you are still interested in this issue I will notify you.

Created at 2 days ago

Update maven.yml

Fix: El ejemplo tenia un error en el "uses: actions/checkout", empezaba por un guion

Created at 2 days ago

Update maven.yml

Fix: indentación

Created at 2 days ago

Github Actions configured for creating a test report & uploading it

Signed-off-by: chinmaym07 b418020@iiit-bh.ac.in

Merge pull request #4 from chinmaym07/configure-github-actions

Github Actions configured for creating a test report & uploading it

Created at 2 days ago
closed issue
Configurar Github Action

Crear la carpeta .github/workflows/ y el fichero maven.yml con la siguiente información:

name: Java CI with Maven

on:
  push:
    branches: [ "master" ]
  pull_request:
    branches: [ "master" ]

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - name: Checkout repository
    - uses: actions/checkout@v3
    
    - name: Set up JDK 17
      uses: actions/setup-java@v3
      with:
        java-version: '17'
        distribution: 'temurin'
        cache: 'maven'
        
    - name: Compile with Maven
      run: mvn -B compile --file pom.xml
      
    - name: Test
      run: mvn -B test --file pom.xml

Además, agregar la configuración de deepsource para que se suba el reporte de cobertura de los test.

  • Agregar la dependencia para generar el reporte: https://deepsource.io/docs/analyzer/test-coverage/#java
  • Agregar la configuración de deepsource: https://deepsource.io/docs/analyzer/test-coverage/#with-github-actions-3
    • La variable de entorno DEEPSOURCE_DSN ya esta creada.
Created at 2 days ago
pull request closed
Github Actions configured for creating a test report & uploading it

fixes: #3

Created at 2 days ago
issue comment
Github Actions configured for creating a test report & uploading it

Great, thank you very much. It looks good

Created at 2 days ago
Created at 2 days ago
issue comment
Github Actions configured for creating a test report & uploading it

please could you also check why you have so many modified lines in the pom.xml file, if you have only added 20 lines, it should not be like that:

image

Created at 2 days ago
issue comment
Github Actions configured for creating a test report & uploading it

Please set the latest version of Jacoco, the current one does not work in java 17, which causes it not to compile the project.

Also correct the report path (the value after --value-file), to ./target/site/jacoco/jacoco.xml as this is the file it generates and it is the same name of the file indicated in the deepsource docs.

Created at 2 days ago
issue comment
Configurar Github Action

Hello @chinmaym07 Yes, of course.

Now, about your question, there is no new file to create, it would be on the same maven.yml file. And about the url (https://deepsource.io/docs/analyzer/test-coverage/#with-github-actions-3), there are 3 steps, but steps 1 and 2 are already done, you only need to configure step 3 to maven.yml but for this you need the library that generates the report, for example jacoco which is mentioned in the above url https://deepsource.io/docs/analyzer/test-coverage/#java.

Created at 2 days ago