this is be solved (sorta) by PR #659

but yeah, if we could make it work with axios@^1 it would be better for DX

Is there an existing issue that is already proposing this?

• [X] I have searched the existing issues

Is your feature request related to a problem? Please describe it

The issue appears when the axios 1.2.3+ is explicitly installed in the project. Then, code like this isn't working:

import { HttpService } from '@nestjs/axios';
import { Injectable } from '@nestjs/common';
import { AxiosInstance } from 'axios';

@Injectable()
export class MyService {
  private http: AxiosInstance;

  constructor(private readonly httpService: HttpService) {
    this.http = httpService.axiosRef;
  }
}

The reason is that typings and structure for AxiosInstance starting from 1.2.3 and higher is different from what goes with @nestjs/axios right now.

Describe the solution you'd like

The internal dependency for Axios is 1.3.0

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

Typically you grab instances from Axios directly - not from sub-dependences of install packages (@nestjs/axios in this case).

@roggervalf Unfortunately, the nestjs @Processor decorator does not allow metrics param.

chore(deps): update typescript-eslint monorepo to v5.50.0

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | @typescript-eslint/eslint-plugin | 5.49.0 -> 5.50.0 | | | | | | @typescript-eslint/parser | 5.49.0 -> 5.50.0 | | | | |

Release Notes

v5.50.0

Compare Source

Bug Fixes

• eslint-plugin: [ban-ts-comment] counts graphemes instead of String.prototype.length (#​5704) (09d57ce)
• eslint-plugin: [prefer-optional-chain] fix ThisExpression and PrivateIdentifier errors (#​6028) (85e783c)
• eslint-plugin: [prefer-optional-chain] fixer produces wrong logic (#​5919) (b0f6c8e), closes #​1438

Features

• eslint-plugin: add key-spacing rule extension for interface & type declarations (#​6211) (67706e7)

v5.50.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

chore(deps-dev): bump class-validator from 0.13.2 to 0.14.0

Bumps class-validator from 0.13.2 to 0.14.0.

• Release notes
• Changelog
• Commits

updated-dependencies:

• dependency-name: class-validator dependency-type: direct:development ...

Signed-off-by: dependabot[bot] support@github.com

chore(deps): update dependency typescript to v4.9.5

chore(deps): update typescript-eslint monorepo to v5.50.0

chore(deps-dev): bump class-validator from 0.13.2 to 0.14.0

Bumps class-validator from 0.13.2 to 0.14.0.

• Release notes
• Changelog
• Commits

updated-dependencies:

• dependency-name: class-validator dependency-type: direct:development ...

Signed-off-by: dependabot[bot] support@github.com

chore(deps): update typescript-eslint monorepo to v5.50.0

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | @typescript-eslint/eslint-plugin | 5.49.0 -> 5.50.0 | | | | | | @typescript-eslint/parser | 5.49.0 -> 5.50.0 | | | | |

Release Notes

v5.50.0

Compare Source

Bug Fixes

• eslint-plugin: [ban-ts-comment] counts graphemes instead of String.prototype.length (#​5704) (09d57ce)
• eslint-plugin: [prefer-optional-chain] fix ThisExpression and PrivateIdentifier errors (#​6028) (85e783c)
• eslint-plugin: [prefer-optional-chain] fixer produces wrong logic (#​5919) (b0f6c8e), closes #​1438

Features

• eslint-plugin: add key-spacing rule extension for interface & type declarations (#​6211) (67706e7)

v5.50.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

this should be fixed by PR #1136

Is there an existing issue for this?

• [X] I have searched the existing issues

Current behavior

The latest version of @nestjs/config package (2.2.0) uses dotenv-expand@8.0.3 library as a dependency with a strict version. This version (8.0.3) is out-of-date and has a prevalent issue raised on Github - https://github.com/motdotla/dotenv-expand/issues/65. Based on that, the error is thrown in case an ENV variable contains an uninterpolated $ sign in it like in the example:

TOKEN ="abcd$1234"

that leads up to:

In a newer version of this library v10.0.0 they changed an interpolation algo that should resolve the $ sign use case above - see details.

Thus the motivation behind this issue is to upgrade dotenv-expand in the @nestjs/config package to the latest version to prevent such an issue and keep all nestjs packages up-to-speed.

Minimum reproduction code

https://github.com/motdotla/dotenv-expand/blob/v8.0.3/lib/main.js

Steps to reproduce

No response

Expected behavior

The @nestjs/config package supports the latest version of dotenv-expand lib and does not fail even tho ENV variables contain uninterpolated dollar signs.

Package version

2.2.0

NestJS version

9.1.4

Node.js version

14.19.0

In which operating systems have you tested?

• [X] macOS
• [X] Windows
• [X] Linux

Other

No response

chore(deps): update typescript-eslint monorepo to v5.50.0

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | @typescript-eslint/eslint-plugin | 5.49.0 -> 5.50.0 | | | | | | @typescript-eslint/parser | 5.49.0 -> 5.50.0 | | | | |

Release Notes

v5.50.0

Compare Source

Bug Fixes

• eslint-plugin: [ban-ts-comment] counts graphemes instead of String.prototype.length (#​5704) (09d57ce)
• eslint-plugin: [prefer-optional-chain] fix ThisExpression and PrivateIdentifier errors (#​6028) (85e783c)
• eslint-plugin: [prefer-optional-chain] fixer produces wrong logic (#​5919) (b0f6c8e), closes #​1438

Features

• eslint-plugin: add key-spacing rule extension for interface & type declarations (#​6211) (67706e7)

v5.50.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

chore(deps): update typescript-eslint monorepo to v5.50.0