neopheus
Repos
62
Followers
2

Events

issue comment
Fix TagsInput Php 8.1 #4229

It's do :)

Created at 6 days ago
pull request opened
Fix TagsInput Php 8.1 #4229

explode(): Passing null to parameter ($string) of type string is deprecated

Created at 6 days ago
create branch
neopheus create branch tags-input-explode-deprecated
Created at 6 days ago
Created at 6 days ago
issue comment
TagsInput : explode(): Passing null to parameter #2 ($string) of type string is deprecated

PR : https://github.com/filamentphp/forms/pull/7

Created at 6 days ago
pull request opened
Fix TagsInput Php 8.1 #4229

explode(): Passing null to parameter #2 ($string) of type string is deprecated

https://github.com/filamentphp/filament/issues/4229

Created at 6 days ago
create branch
neopheus create branch tags-input-explode-deprecated
Created at 6 days ago
opened issue
TagsInput : explode(): Passing null to parameter #2 ($string) of type string is deprecated

Package

filament/forms

Package Version

v2.16.17

Laravel Version

9.x

Livewire Version

No response

PHP Version

PHP 8.1

Problem description

explode(): Passing null to parameter #2 ($string) of type string is deprecated

            if (! ($separator = $component->getSeparator())) {
                $component->state([]);
                return;
            }

            $state = explode($separator, $state); // <-- problem

Expected behavior

no error message

Steps to reproduce

ressource with null parameters

Reproduction repository

https://github.com/neopheus/forms

Relevant log output

No response

Created at 6 days ago
Created at 6 days ago
pull request opened
Add Logs

addition of logs to have more traceability on possible problems

Created at 2 weeks ago
neopheus create branch add-logs
Created at 2 weeks ago
Created at 2 weeks ago
pull request opened
Php 8.1 fix #2290

Description

Fixes #2290 (issue)

Checklist:

  • [x] I have run composer run-script check --timeout=0 and no errors were reported
  • [x] The new code is covered by unit tests (check build/coverage for coverage report)
  • [x] I have updated the documentation to describe the changes
Created at 3 weeks ago

str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated"

Created at 3 weeks ago

Fix : htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated

htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated

Created at 3 weeks ago
pull request closed
Fix #2290

Description

Fixes #2290

Checklist:

  • [x] I have run composer run-script check --timeout=0 and no errors were reported
  • [x] The new code is covered by unit tests (check build/coverage for coverage report)
  • [x] I have updated the documentation to describe the changes
Created at 3 weeks ago
create branch
neopheus create branch php8.1-fix-2290
Created at 3 weeks ago
delete branch
neopheus delete branch php8.1-fix-#2290
Created at 3 weeks ago
pull request opened
Fix #2290

Description

Fixes #2290

Checklist:

  • [x] I have run composer run-script check --timeout=0 and no errors were reported
  • [x] The new code is covered by unit tests (check build/coverage for coverage report)
  • [x] I have updated the documentation to describe the changes
Created at 3 weeks ago
create branch
neopheus create branch php8.1-fix-#2290
Created at 3 weeks ago
opened issue
utf8_encode(): Passing null to parameter #1 ($string) of type string is deprecated

Describe the Bug

utf8_encode(): Passing null to parameter #1 ($string) of type string is deprecated at /vendor/phpoffice/phpword/src/PhpWord/TemplateProcessor.php:261

Context

  • PHP Version: 8.1
  • PHPWord Version: 0.18.3
Created at 3 weeks ago
Created at 3 weeks ago
issue comment
Bug Clip Path Inverted on SVG Export

a proposition : https://jsfiddle.net/avdigital/uw74h10y/178/


fabric.Object.prototype._createBaseSVGMarkup = function (objectMarkup, options) {
            options = options || {};
            var noStyle = options.noStyle, reviver = options.reviver, styleInfo = noStyle ? '' : 'style="' + this.getSvgStyles() + '" ', shadowInfo = options.withShadow ? 'style="' + this.getSvgFilter() + '" ' : '', clipPath = this.clipPath, vectorEffect = this.strokeUniform ? 'vector-effect="non-scaling-stroke" ' : '', absoluteClipPath = clipPath && clipPath.absolutePositioned, stroke = this.stroke, fill = this.fill, shadow = this.shadow, commonPieces, markup = [], clipPathMarkup, 
            // insert commons in the markup, style and svgCommons
            index = objectMarkup.indexOf('COMMON_PARTS'), additionalTransform = options.additionalTransform;
            if (clipPath) {
		            if (clipPath.inverted) {
                  clipPath.clipPathId = 'CLIPPATH_' + fabric.Object.__uid++;
                  console.log(this.width);
                  clipPathMarkup = '<mask id="' + clipPath.clipPathId + '" >\n';
                  clipPathMarkup += '<rect ' +
                    ' fill="white"' +
                    ' x="' +
                    fabric.util.toFixed(-this.width / 2, 2) +
                    '" y="' +
                    fabric.util.toFixed(-this.height / 2, 2) +
                    '" width="' +
                    fabric.util.toFixed(this.width, 2) +
                    '" height="' +
                    fabric.util.toFixed(this.height, 2) +
                    '"></rect>\n';
                  clipPathMarkup += clipPath.toClipPathSVG(reviver) +
                      '</mask>\n';
                } else {
                  clipPath.clipPathId = 'CLIPPATH_' + fabric.Object.__uid++;
                  clipPathMarkup = '<clipPath id="' + clipPath.clipPathId + '" >\n' +
                      clipPath.toClipPathSVG(reviver) +
                      '</clipPath>\n';
                }

            }
            if (absoluteClipPath) {
                markup.push('<g ', shadowInfo, this.getSvgCommons(), ' >\n');
            }
            markup.push('<g ', this.getSvgTransform(false), !absoluteClipPath ? shadowInfo + this.getSvgCommons() : '', ' >\n');
            commonPieces = [
                styleInfo,
                vectorEffect,
                noStyle ? '' : this.addPaintOrder(), ' ',
                additionalTransform ? 'transform="' + additionalTransform + '" ' : '',
            ].join('');
            objectMarkup[index] = commonPieces;
            if (fill && fill.toLive) {
                markup.push(fill.toSVG(this));
            }
            if (stroke && stroke.toLive) {
                markup.push(stroke.toSVG(this));
            }
            if (shadow) {
                markup.push(shadow.toSVG(this));
            }
            if (clipPath) {
                markup.push(clipPathMarkup);
            }
            markup.push(objectMarkup.join(''));
            markup.push('</g>\n');
            absoluteClipPath && markup.push('</g>\n');
            return reviver ? reviver(markup.join('')) : markup.join('');
};

fabric.Object.prototype.getSvgCommons = function() {
			var typeClipPath = this.clipPath;
      if (typeClipPath) typeClipPath =  this.clipPath.inverted ? 'mask="url(#' : 'clip-path="url(#';
      return [
        this.id ? 'id="' + this.id + '" ' : '',
        typeClipPath ? typeClipPath + this.clipPath.clipPathId + ')" ' : '',
      ].join('');
    };
Created at 1 month ago
issue comment
Font Position - baseline problem

i have a solution

/**
 * Text Line proportion to font Size (in pixels)
 * @type Number
 * @default
 */
_fontSizeMult:             1.513,

and no problem now

Created at 1 month ago
issue comment
Font Position - baseline problem

New jsfiddle : https://jsfiddle.net/avdigital/uw74h10y/138/

I found something

I made the code with a textbox to test

but if I change a part of the text, the custom font is not used, but a default font

it seems that the calculation of the positions are done with this default font and not the custom font

Created at 1 month ago
issue comment
Font Position - baseline problem

I came across this old wiki that mentions #44 (comment)

might be helpful

i try :)

thx

Created at 1 month ago
issue comment
Font Position - baseline problem

If plain canvas can render it correctly probably we can do it too, the issue could be that for this font the advanced text metrics are required. Since many browser didn't support those at the time we skipped them, but later we may introduce them since new version won't support ie and legacy edge

it would be perfect :)

Created at 1 month ago
Created at 1 month ago
issue comment
Bug Clip Path Inverted on SVG Export

I don't understand Ahh to the eraser Yes A brush brcomes a path Look into the code

ok

i try

Created at 1 month ago