necolas
Repos
77
Followers
10145
Following
28

Cross-platform React UI packages

20637
1655

A modern alternative to CSS resets

49988
10390

Events

issue comment
Feat: Move `FlatList`s to `@react-native/flat-lists` package

They both also have the section list variant

Created at 2 days ago

Fix path to ISSUE_TEMPLATE in labels config

Created at 3 days ago

Update documentation to match API changes

Created at 3 days ago
issue comment
Scroll speed is faster when FlatList is inverted

I think all issues related to Animated and FlatList should be directed towards this RN issue https://github.com/facebook/react-native/issues/35263

Once RNWeb can import those modules from npm, they can be kept in sync across native and web, and any issues can be managed out of the RN repo only. This should make it a lot simpler going forward.

Created at 3 days ago
issue comment
☂️ npm packages for react-native-web

There are a number of significant stakeholders, like Expensify, who depend on RN for their cross-platform product. And it seems to be an ongoing source of issues for them that these major modules are not kept in sync across native and web. I think we really need to get these modules into installable packages and published as compiled JS ASAP.

Created at 3 days ago
Compatibility with expo-asset - AssetRegistry is expected inside Image, not a separate Library

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the issue

In trying to upgrade our project to Expo 48 / React Native 0.71.4 we came across a build error with expo-asset.

It is trying to import AssetRegistry from react-native/Libraries/Image/AssetRegistry.

Looking at the react-native repository, this file has not been recently moved into the Image package. Referencing 0.60-stable to show that the version bundled into 0.18 of RNW also had the file under Image https://github.com/facebook/react-native/tree/0.60-stable/Libraries/Image

Expected behavior

Imports for react-native/Libraries/Image/AssetRegistry resolve when aliased to react-native-web.

Steps to reproduce

Include expo 48.0.7 in a build and import expo-assets, or attempt importing import { getAssetByID } from 'react-native/Libraries/Image/AssetRegistry'; directly

Test case

Unable to use this specific import line in sandbox.

Additional comments

I believe the AssetManager package should be merged inside Image, or if it can't be moved, aliases should be made under Image.

Created at 3 days ago
issue comment
Compatibility with expo-asset - AssetRegistry is expected inside Image, not a separate Library

Reaching into intervals is not supported. If expo is doing that you should open an issue against expo, and they can import the path in RNW if they must

Created at 3 days ago
issue comment
[w3c] ☂️ Web Styles (Part 1) umbrella issue

We'll close this issue once the last aliases for logical border properties are implemented. Thanks!

Created at 4 days ago
issue comment
Ui behaves inconsistently across platforms. Some are against RN spec.

Thanks for the clear issue and your attention to detail in finding these issues.

1 & 3 should be fixed by the latest canary release: https://codesandbox.io/s/muddy-frog-o4pkid

Please let me know if you encounter any more issues

Created at 4 days ago
issue comment
0.19 dev

Latest / late anticipated canary: 0.0.0-47671ca4

Planning to get 0.19 out this week barring any unexpected issues

Created at 4 days ago

Bump luxon from 2.4.0 to 2.5.2

Bumps luxon from 2.4.0 to 2.5.2.


updated-dependencies:

  • dependency-name: luxon dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Bump json5 from 2.2.1 to 2.2.3

Bumps json5 from 2.2.1 to 2.2.3.


updated-dependencies:

  • dependency-name: json5 dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Bump engine.io from 6.2.0 to 6.2.1

Bumps engine.io from 6.2.0 to 6.2.1.


updated-dependencies:

  • dependency-name: engine.io dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Bump loader-utils from 2.0.0 to 2.0.4

Bumps loader-utils from 2.0.0 to 2.0.4.


updated-dependencies:

  • dependency-name: loader-utils dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Bump socket.io-parser from 4.0.4 to 4.0.5

Bumps socket.io-parser from 4.0.4 to 4.0.5.


updated-dependencies:

  • dependency-name: socket.io-parser dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

[fix] 'accessibilityRequired' sets correct 'required' value

Fix #2451

0.18.11

[fix] iOS not firing resize event when keyboard opens/closes

The workaround is listening to window.visualViewport 'resize' event.

Fix #2430 Close #2438

[fix] Avoid setting focus tabIndex on

Also don't modify the tabIndex on contenteditable elements when using programmatic focus APIs.

Fix #2473 Close #2468

0.18.12

Bump ua-parser-js from 0.7.31 to 0.7.33

Bumps ua-parser-js from 0.7.31 to 0.7.33.


updated-dependencies:

  • dependency-name: ua-parser-js dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Fix actions used in workflows

Close #2461

Fix label workflow actions

Bump webpack from 5.73.0 to 5.76.0

Bumps webpack from 5.73.0 to 5.76.0.


updated-dependencies:

  • dependency-name: webpack dependency-type: direct:development ...

Signed-off-by: dependabot[bot] support@github.com

[change] Remove platform-specific exports

[change] React 18 support

  • Support React 18 concurrency and constraints.
  • Add new render / hydrate functions.
  • Remove uses of findNodeHandle.
  • Expose ability to unmount an application once ran.

Fix #1529 Close #2330

[change] StyleSheet.compose() deprecation

Encourage use of existing array syntax for multiple styles. Eventually we'll want to remove the compose() API to simplify the overall styling API.

[change] Update Animated to support React 18

And remove deprecated AppState.removeListener API

Fix #2378

[change] Remove setNativeProps API

Previously deprecated, and not supported in the React Native Fabric architecture.

Close #1935

[fix] Animated works with compiled styles

Animated should now work with compiled and extracted styles. The original styles are passed to components, rather than being flattened into a new object that cannot be used by the style runtime to either lookup the results of StyleSheet.create calls or consume extracted styles. Inline styles that use AnimatedValue are moved into a seperate object that is appended to the original styles.

Fix #2387

Created at 4 days ago

Bump webpack from 5.73.0 to 5.76.0

Bumps webpack from 5.73.0 to 5.76.0.


updated-dependencies:

  • dependency-name: webpack dependency-type: direct:development ...

Signed-off-by: dependabot[bot] support@github.com

Created at 4 days ago
pull request closed
Bump webpack from 5.73.0 to 5.76.0

Bumps webpack from 5.73.0 to 5.76.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Created at 4 days ago
FlatList not displaying anything in web but works fine in mobile

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the issue

I'm using Flatlist to render a simple list of items.

It works fine on iOS and Android. But does not show anything on web.

Expected behavior

Flatlist displays a list of items in web the same way it does on mobile.

Steps to reproduce

See test case

Test case

https://snack.expo.dev/@avionmission/flatlist-on-web

Additional comments

I'm still a newbie to RN and RNW, so any help is appreciated.

Created at 4 days ago
issue comment
Allow `.focus()` to take standard options. (`preventScroll`, `focusVisible`)

This should have be reported as a bug an included a reproducible test case

Created at 4 days ago
issue comment
Ui behaves inconsistently across platforms. Some are against RN spec.

The docs are out of date / missing info https://snack.expo.dev/5Lpci2KAd

Created at 4 days ago
issue comment
Ui behaves inconsistently across platforms. Some are against RN spec.

2 is a bug in React Native not web.

3 is only true for text-align, not all text style inheritance.

And 1 is easy to change. But you're incorrect in saying static is not supported in RN because it is.

Created at 4 days ago
issue comment
[TextInput] Add numberOfLines and maximumNumberOfLines props on iOS

Thanks for working through the feedback so far. We'll need someone from the RN team to review the native code and import the PR

Created at 2 weeks ago
issue comment
Linking API: Support for New Tab

You're complaining that 1) you wanted this feature and it was added, and 2) that you want contributor PRs to be merged and a contributor PR was merged? What you're implying is not supported by facts.

This project has dozens of contributor PRs merged every release. If people submit good PRs with explanations, tests, etc., (as requested in the contributing guidelines) then it makes it a lot easier to review and merge. Unfortunately a lot of PRs lack context, change too many things for prompt review, and have little to no tests. And the person who improves (e.g., add the unit tests you didn't) and then maintains those contributor patches "forever" is me, not you.

The only reason this project is still going is because I keep it going. There's little to no support from Meta engineering. This project has to dance between supporting RN APIs that frequently had no thought for web, and what web devs want to do via React DOM with little thought for compat with React Native. Not to mention that I've put a lot of work into landing changes to React Native so more web code works out-of-the-box on React Native in the future.

Keep that in mind next time you feel like venting. Thanks in advance!

Created at 2 weeks ago
jest-preset.js was removed in version 18

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the issue

As of version 18.0, jest-preset.js was removed from react-native-web. Please advise. Was this intentional? If not, can we please add it back?

Expected behavior

Jest expects a jest-preset.js file if the node_module is defined as a jest preset. My understanding, is we are supposed to use react-native-web as the preset.

Steps to reproduce

Install 18.0 or above and set jest preset to react-native-web.

Test case

NA

Additional comments

No response

Created at 2 weeks ago
issue comment
jest-preset.js was removed in version 18

It was intentional and mentioned in the release notes. The preset is no longer needed. https://necolas.github.io/react-native-web/docs/setup/#jest

Created at 2 weeks ago