necolas
Repos
77
Followers
9832
Following
28

Development monorepo for "React Native for Web"

20255
1629

A modern alternative to CSS resets

48766
10267

Events

issue comment
[w3c] ☂️ Web Props umbrella issue

I think role support is missing from Text (which appears to support accessibilityRole): https://github.com/facebook/react-native/blob/main/Libraries/Text/TextProps.js

This logic in View may need to be moved to a shared place so it can be used in Text too

Created at 11 hours ago
issue comment
[w3c] ☂️ Web Styles umbrella issue

I like this idea. inset-inline and inset-block would also be useful. I'll add a bunch more logical properties too once we have an idea of how to support them

Created at 14 hours ago
issue comment
feat: added `textShadow` property in `TextStyleProps`

Splitting with a comma will not work when the shadow color is in rgb or hsl format.

Good point! I think eventually a lot of this stuff will move into native code. Note that CSS Color 4 allows space separated rgb values, which would make things easier if we didn't also have comma-separated. Ideas for another day.

Created at 14 hours ago
issue comment
feat: added `textShadow` property in `TextStyleProps`

so the following are valid values: '1, 1,1, red', 1,1, 1,rgb(1,1,0)

No, multiple shadows are separated by commas. You can split on comma to detect multiple shadows and print a warning that only the first shadow will be supported by RN. The trickier part will be detecting which part of the shadow is a color. Best to refer to the spec for details about the syntax

Created at 1 day ago
issue comment
How can I add a custom prefix to generated css classNames?

I don't understand the request

Created at 5 days ago
issue comment
Dimensions.get calls `change` listeners the first time

Yeah maybe. Not much context was provided by the PR author

Created at 5 days ago
issue comment
Dimensions.get calls `change` listeners the first time

https://github.com/necolas/react-native-web/commit/59af091fdb4dd91118b105596a28c093426978b0

Created at 6 days ago
issue comment
feat: Add alt prop to Image component

The TS types are already out of sync with the Flow types, as they don't have props from the other merged Web PRs

Created at 1 week ago
issue comment
[w3c] ☂️ Web Props umbrella issue

Good idea

Created at 1 week ago