neclimdul
Repos
128
Followers
23
Following
22

Events

Add missed double type removal

Created at 2 weeks ago
issue comment
dns/ddclient: add AWS Route53

LOL no I get that. There's only so many hours in the day to contribute though

Created at 2 weeks ago
issue comment
dns/ddclient: add AWS Route53

I see. That does mitigate things but it means if I have to rebuild or upgrade my opnsense machine I'll be stranded without the feature or a long night of hacking to manually add it back.

Created at 2 weeks ago
issue comment
dns/ddclient: add AWS Route53

also just realized that says "before 22.7 is released" which happened and the plugin still exists so I guess this is actually on someone's radar preventing the plugin's removal :laughing:

Created at 2 weeks ago
issue comment
dns/ddclient: add AWS Route53

Ok, I think I understand what you're saying but there's still a disconnect somewhere. Users currently see this: image

But there is no upgrade path which in my reading of things is a bug. Maybe the bug is in the legacy message, hopefully for me the "bug" is that the feature is pending... Somewhere there's a bug though.

Created at 2 weeks ago

Remove double handling in enum

Created at 2 weeks ago
[BUG][php-symfony] Issue with double type in model

I see you changed the enum code. I'll include that too. I hadn't been able to figure out if that was the native type or the spec type.

Created at 2 weeks ago
pull request opened
Fix php generators treating double as a native type

Fixes #13335

Fixes inconsistent treating of double as a native type in php. Removes type from native primitives and consistently fixes the map in the AbstractPhpCodegen class

References: https://docs.phpdoc.org/3.0/guide/guides/types.html#primitives http://php.net/manual/en/language.types.intro.php https://www.php.net/manual/en/language.types.float.php

@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon

PR checklist

  • [x] Read the contribution guidelines.
  • [X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Created at 2 weeks ago

Fix php generators treating double as a native type

Fixes #13335

Created at 2 weeks ago

Fix php generators treating double as a native type

Fixes #13335

Created at 2 weeks ago

Fix php generators treating double as a native type

Fixes #13335

Created at 2 weeks ago
neclimdul create branch 13335-php-double
Created at 2 weeks ago
[BUG][php-symfony] Issue with double type in model

@wing328 oh... I'm in the process of posting it right now...

Created at 2 weeks ago
[BUG][php-symfony] Issue with double type in model

Yeah, I confirmed it exists in master. Working on the pull request.

I think its basically that plus removing it from the primitive list plus cleaning up some of the other generators that already had this

Created at 2 weeks ago
opened issue
dns/ddclient: add AWS Route53

Important notices Before you add a new report, we ask you kindly to acknowledge the following:

  • [x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
  • [x] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
  • [x] The title contains the plugin to which this issue belongs

Describe the bug re-opening #2892 because its still a bug despite the bot's opinion on the subject.

Original summary: Is your feature request related to a problem? Please describe. Legacy plugin set to be deprecated has Route53 as a provider option, but replacement plugin does not.

Describe the solution you'd like Add Route53 as a provider in the GUI.

Describe alternatives you've considered Use the legacy plugin but would like to switch to non-deprecated plugin.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'ui/dyndns'
  2. Click on add button
  3. Service dropdown.

Expected behavior See Route53 or compatible option.

Screenshots image

Environment OPNsense 22.7.2-amd64 FreeBSD 13.1-RELEASE-p1 OpenSSL 1.1.1q 5 Jul 2022

Created at 2 weeks ago
[BUG][php-symfony] Issue with double type in model

This seems to be a problem with all the PHP generators. There seem to be two related problems.

  1. The primitive list includes double(as well as number) which is not a valid language or phpdoc primitive.
  2. The map for double assumes double is a primitive which is not.

So the fix is mostly correct but should be applied to all the PHP generators.

References: https://docs.phpdoc.org/3.0/guide/guides/types.html#primitives http://php.net/manual/en/language.types.intro.php https://www.php.net/manual/en/language.types.float.php

Created at 2 weeks ago

Fix duplicated Authorization headers when renewing a token on a retry (#11513)

Add a leeway time to avoid a skew in the local clock

Fix ClassCastException if expected type is Object (#11510)

The currently generated code will throw a ClassCastException if type is Object. I'm not quite sure why isAssignableFrom is used here but I tried to keep the change minimal - in my understanding, the result would be the same if the line was

if(Types.getRawType(type).equals(ApiResponse.class)) {

because the ApiResponse only extends Object and implements no interfaces. Maybe it was meant to be ApiResponse.class.isAssignableFrom(Types.getRawType(type))? This would also permit subclasses of ApiResponse, but then it would be more complicated to determine the actual type parameter (because type itself may not be parameterized) and to create the object to return (because it would have to be an instance of the subclass).

update samples

fix javadoc warnings in feign client (#11527)

Update __init__model.mustache (#11474)

fix a error in the template

update samples

[Bug][Java/Spring] OAS3 related bugfixes and enhancements (#11526)

  • Content mediatype is hardcoded in api.mustache #11511

  • Generate Samples

  • OAS3 incorrect data type when providing a default value #11367

  • Generate Samples

  • Fix JsonTypeName annotation handling in Java and JavaSpring

  • Generate Samples

  • getIsClassnameSanitized: use null safe equals

[csharp-netcore] Add generichost samples (#11451)

  • added generichost samples

  • build samples

  • added guid

  • build samples

Add cycle detection (#7532) (#11500)

  • Add cycle detection (#7532)

  • Review feedback

  • Including ContextAwareNodes to detect cycles more accurately.

  • Add test

  • Add forest to test.

  • No longer need ContextAwareNode

  • Review feedback

  • Update samples

fix float literals in C++ Pistache codegen (#11483)

[csharp-nancyfx] Delete NancyFX (#11438)

  • removed all nancyfx references

  • didnt save one file

  • removed two more nancyfx files

tidy [csharp-netcore]: Remove unused UrlEncode method. Possible breaking change: Method is public so upstream consumer may of used it, but library does not. (#11453)

add numary as bronze sponsor of the project (#11539)

update readme

Merge branch 'master' of https://github.com/OpenAPITools/openapi-generator

[java][Okhttp] replace okhttp-gson with okhttp-gson-nextgen (#11538)

  • replace okhttp-gson with okhttp-gson-nextgen

  • add new files

  • update doc

  • clean up pom

  • update test

  • restore error handling in doc

  • add back changes

  • uncomment tests

  • update samples

update build.gradle, build.sbt in java okhttp-gson client (#11543)

[C#] test .net6 projects in Github actions (#11544)

  • test .net 6 in github workflow

  • trigger workflow

  • fix run

  • fix test

  • trigger build

  • update samples

update swagger core, jackson to newer version (#11545)

Upgrade sttp generator to sttp3 (#11260)

Remove CIRCE_VERSION from generator because it is taken in as a transitive dependency of "com.softwaremill.sttp.client3" %% "json4s" % "3.3.18"

Co-authored-by: boris borissmidt@hotmail.com

Created at 2 weeks ago
neclimdul create tag v2.0.0-beta4
Created at 4 weeks ago

Update cache interface

This allows marketo to work with psr-cache 2.0 and 3.0

Support psr/cache 2.0 and 3.0

Fix typing and correctly support 2.0 and 3.0

Fix spacing style

Created at 4 weeks ago
issue comment
Codecept upgrade

Is there a problem or concern with my code? I tried to keep it to the bare minimum to make the different pieces work so feel to use it as a starting point for your work. Its free under your MIT license.

Created at 1 month ago
neclimdul delete branch coverage-fix
Created at 1 month ago
Created at 1 month ago
delete branch
neclimdul delete branch logger-format
Created at 1 month ago
issue comment
Request::create can trigger deprecated array conversion in 8.1 with bad values

If the suggested solution sounds good I think I can make that happen.

Created at 2 months ago
opened issue
Request::create can trigger deprecated array conversion in 8.1 with bad values

Symfony version(s) affected

<=6.2

Description

If you provide a bad value to Request::create, its possible parse_url will fail to parse it settings $components to false. Later code doesn't handle the false condition which "works" because the last bit assigns a value to the variable converting it to an array. In PHP 8.1+ however this conversion behavior is deprecated.

How to reproduce

Request::create('/foo:123');

Outputs something like:

Deprecated function: Automatic conversion of false to array is deprecated in Symfony\Component\HttpFoundation\Request::create() (line 372 of /app/vendor/symfony/http-foundation/Request.php).
Symfony\Component\HttpFoundation\Request::create('/foo:123') ....

Possible Solution

The url isn't valid so it would probably be good to provide developer feedback but throwing an exception would be pretty disruptive.

Seems like the best approach might be:

  1. Explicitly handle the false condition preserving the current behavior. Include deprecation.
  2. Throw a InvalidArgument exception or similar in some future version.

Additional Context

No response

Created at 2 months ago
issue comment
Add rules to check @covers and @coversDefaultClass for methods and classes.

Yeah, didn't expect you did. I don't have any intention of causing problems but seems like someone could be malicious with licensing if their code was committed as authored by someone else. Also just doesn't feel great to loose credit, but that's more a weakness in github only really capturing credit as the author.

Created at 2 months ago
issue comment
Add rules to check @covers and @coversDefaultClass for methods and classes.

Ouch, those are clearly my tests. Also, looks like you lost one of the test cases.

/**
 * @covers \PHPUnit\Framework\TestCase
 */
class CoversShouldExistTestCase3 extends \PHPUnit\Framework\TestCase
{

	/**
	 * @covers \PHPUnit\Framework\TestCase
	 */
	public function testBadCoversDefault() {}

}
Created at 2 months ago
issue comment
Validate coverage tags point to real classes

@mad-briller still interested but might be a while before I can finish it so if you've got some time to bring it home that would be awesome.

Created at 2 months ago