mvriel
Repos
57
Followers
135
Following
7

Events

issue comment
Open for discussion: design updates

The sidebar text and background contrast isn't high enough, at least I think. I did not plug it into an accessibility checker.

Just checked it using the webaim contract checker and it at least passes the WCAG AA standard for regular text; it is were semi-bold or bold it even passes the stricter WCAG AAA test.

image

As for all other points, due to a death in the family, 2 holidays and some chats between other people I will wait with responding

Created at 1 month ago
issue comment
Open for discussion: design updates

And after that whole wall of text, the latest iteration is landing page - version 2

Even though there might be details that we can discuss, I am moving forward now to expanding the number of designs to include mobile/tablet sizes and the other parts of the website. Any tweaks discussed here can be carried across these designs

Created at 1 month ago
issue comment
Open for discussion: design updates

@morrisonlevi thank you for that feedback and advice, it is much appreciated!

At current, @dragoonis and I have been discussing back and forth and he will be doing the implementation and I am helping the UX/UI part of the equation. Thus even though I am well-versed in how to approach this technically; I am unable to comment on implementation details.

As for the design goals that I have in mind, I can elaborate:

  1. the main goal is to make the PHP more attractive as a brand and radiate: this is a modern language that needs to be taken seriously
  2. Aside from the above, the visual language is sometimes confusing -for example, the sidebar in the homepage- and by taking stock of the currently used elements and providing a consistent language it would be more usable.
  3. Introducing a design system that easily carries across the other pages to make future maintenance and improvements easier; and supporting the first goal through that
  4. Introduce a design update that re-uses the same elements as are currently present so that when implemented, this could be done in iterations or with small improvements towards a final point. By having a design up front, you should end up with coherency

Aside from the broad goals above, when designing

  • I am taking (image) sizes into account (the latest version only uses SVGs at this point)
  • contrast and legibility are more important than a nice design :)
  • Taking into account how the distribution of colours and components can easily be themed into darkmode or in the future to a newer look and feel (design updates happen every few years)

Although all screenshots so far use the homepage as an example, this is done to gain a bit of consensus so that I can then make a design for the other parts of php.net. From my perspective, the documentation is the most important part of the site to give a lift; the homepage is a vehicle to setup an initial design system.

Disclaimer: as core contributor of phpDocumentor I am biased on the importance of documentation ;)

What I explicitly do not include as a goal:

  1. Changing the homepage with new elements to be more relevant - there is a lot to gain here, but to limit scope I am sticking to existing elements for now.
  2. Changing the UX / Navigation structure - I see options to improve the site structure but the same as the previous point, one thing at a time
  3. The technology / build system behind the website, I am a geek/nerd/dev and would love to have nice things as the other person but it is not the point and would not support the goals above; if @dragoonis were to pick something, I am perfectly fine with that but tech is not the goal

As a closing note, my initial (re)design work was an experiment and I never dreamt it would catch on. From that point onward I have set out not to redesign the PHP website as much as providing a design update. I hope that as a next step, we will be able to build consensus on which elements would enrich the homepage or what site structure would benefit the ecosystem.

Created at 1 month ago
issue comment
Open for discussion: design updates

how do you feel about combining these two?

Looks awesome to me. It manages to apply the design improvements that @mvriel brought (taller navbar with higher contrast, cleaner body content) while staying clean and improving upon the current design.

If we all agree to proceed with the combination suggested by @pronskiy, I believe the next steps would be:

  • Bring this design back to Figma and finish the remaining details, if any.
  • Mock the other layouts we have with the new navbar and body background color: single column, two column, documentation, release page.
  • Adapt the design for mobile screens.
  • Start the implementation using the Figma project as reference.

@mvriel I would love to collaborate with you here, count me in!

Just for public record, I have reached out to you through e-mail with a link to the Figma board. I am working on a new iteration that combines some of the elements of my earlier iteration and @pronskiy's as I think there is something to gain in the header by separating the release information from the rest. And I really would like to introduce an elephpant somewhere to increase brand recognition there.

I also believe this is a good opportunity to update our CSS foundations. We still use Bootstrap 2 and its float based column system. I would be happy to work on this task if we agree that it is a good time for it (upgrade to a flexbox based column system, CSS variables, spacing utility classes, etc).

I'm looking forward to contribute and work with you guys to give PHP website the modern look it deserves.

As mentioned by @dragoonis, let's focus on getting the Figma design and designs for the various pages proper so that he can implement it and make sure it gets carried across all php.net properties.

Created at 1 month ago
issue comment
Modernize top half of Thanks page

I'm more asking myself whether there is a possibility to randomize an unordered list via CSS.

FWIW, that could be done on the server.

Would be a nice followup contribution to keep scope for this PR limited :)

Created at 1 month ago
issue comment
Open for discussion: design updates

Having the search on the hero block does not make sense to me because there is always one on top anyway. I think it adds visual noise to the page.

I used Android (https://developer.android.com/) and MDN (https://developer.mozilla.org/en-US/) as examples where this was used. One of my main reasons for this is that the PHP homepage does not have any other function than being a launchpad into the docs or showing release information.

I'll do a bit more experimentation later on (now at work) but I do believe that it would be nice to consider having more branding related content on the homepage; yet I am not picking up that scope at this point to limit the impact

Created at 1 month ago
issue comment
Open for discussion: design updates

Addendum: I forgot to mention that one of the reasons to avoid the dark background together with light articles (sort of blended light and dark mode) is because it might be advantageous to have more content on the frontpage -at a later stage- aside from release information and having a separate light and dark mode makes that easier to design.

As I see it, the current blended mode will make it harder to introduce different types of components above the articles and nav

Created at 1 month ago
issue comment
Open for discussion: design updates

A quick, and somewhat rough, version could be this.

landing page - Coloured background instead of white

I did keep a bit of the playfulness (the skewed background behind the logo and the elephant) in the hero as -I think- it adds interesting elements and puts a bit more emphasis on these things. The article background is now pure white and the page background a 98% lightness blue tint -similar to your own version-.

I do believe the search bar needs to be fully rounded to be consistent with the CTA buttons; and for the 'light' version I chose to keep the sidebar with a light background to make it a bit more modern and with the intent that the darkmode would feature darker sides again.

The three releases buttons are still separated from the hero to make the content of the hero more focused, and to make these elements stand more out for those who want it. Ideally, I would love a "Getting Started" CTA in the hero; but I am not sure there is pre-existing content to link to.

@lhsazevedo what do you think?

Created at 1 month ago
issue comment
Open for discussion: design updates

Oempf, @lhsazevedo. Thanks for that contribution to the discussion, what I like about your suggestion is how it better incorporates the current branding. I still believe the search bar needs to be in the hero as well as it emphasizes how people use the site.

The "oempf" is because I really needed to take a step back as I had gotten invested in the latest iteration I had done; though I do see a lot of merit in being a bit more conservative while applying modern practices. Gimme a moment to let me see if I can mix and match a bit more with the pieces I enjoy most and come back with another variant that incorporates both elements.

Created at 1 month ago
issue comment
Modernize top half of Thanks page

Desktop

image

Tablet (Portrait) image

Mobile image

As for mobile, I am a bit on the fence if the cards aren't too big. Feedback is appreciated, to show it nicely with logo's is a bit of a thing on mobile if you want to keep it small :)

Created at 1 month ago
pull request opened
Modernize top half of Thanks page

In issue #682 it was requested to modernize the thanks page; as a first step in this effort I have given the top half of the page with current sponsors a brush up, including responsive behaviour.

Unfortunately I could not find a logo for ServerCentral; so I left that empty.

The improvements in this PR does use CSS Grids, meaning it won't show up exactly the same way in IE11 compared to other browsers. I have taken this as a given and unfortunate thing, but I do not know whether this is an issue as I do not know the browserlist.

If the above is an issue, let me know and I'll invest more time on how it looks on IE11.

Created at 1 month ago
create branch
mvriel create branch modernize-thanks-page-pt1
Created at 1 month ago
issue comment
Improve the thanks.php page

During implementation, I discovered that when using 2 columns, some of the texts would become 3 lines high and make the mock above look messy. This is a screenshot of the current implementation image

There are one or two alignment issues to iron out, and I'll be issuing a PR of this without changing the 'Thanks Emiritus' section. I can attack that issue in a subsequent PR to keep things small and incremental

Created at 1 month ago
issue comment
Open for discussion: design updates

@MetalArend when the huge searchbar in the hero is not visible (thus when scrolled past or on another page), I had described the search bar being in the header. It's just when the hero is visible that it is not there, see https://github.com/php/web-php/pull/602#issuecomment-1206254155. Though I could come back on that decision, I am still comparing a sources to see what a common pattern is instead of just trusting my gut ;)

Created at 1 month ago
issue comment
Improve the thanks.php page

Unless someone else beats me to it, I can find some time during the weekend to make a PR for this

Created at 1 month ago
issue comment
Improve the thanks.php page

I just did a very mock -or quick design- as to how the -current- sponsors section could look like; perhaps divided into 2 columns as the number of sponsors is significant enough and the screen real estate allows for it.

Would something like this be interesting?

image

As for the legacy sponsors, it may be interesting to only show their logo and perhaps a caption with their support method as this is secondary information and to focus on current sponsors?

Created at 2 months ago
issue comment
Open for discussion: design updates

@pronskiy As I envisioned it, the search bar in the hero is only when you haven't scrolled yet to to help people as I expect the main case for visiting the site is to find something in the docs. However, as soon as you scroll (and on non-landing pages such as the docs), the search bar should appear in the header again.

This is an early WIP of what I have been working on earlier this week that illustrates that

Desktop - 8

Created at 2 months ago
issue comment
Open for discussion: design updates

More feedback needed, which is better?

A: Homepage Header A

B: Homepage Header B

Created at 2 months ago
issue comment
Open for discussion: design updates

Desktop - 6 (7)

I could use a little feedback; the elephpant in each news article's heading; is it too much or actually a fun touch? I'm a bit in doubt whether it is too much :)

Created at 2 months ago
Some ignore elements in configuration ignored

@asmecher you are right, cleaning the build folder is, by-design, not done by phpDocumentor. This is similar to how other tools manage their build folders and was implemented this way the application does not know whether files in the build folder were intentionally added prior to phpDocumentor -for example: PDFs- or not.

Since phpDocumentor also does not keep a record of previously created files; we simply do not know whether it is safe to delete a file.

Created at 2 months ago
issue comment
Open for discussion: design updates

At the moment, I am working things out in Figma mostly; so there is little code to be helped on. (the code in this PR is throwaway POC code).

Feedback is immensely valuable, especially the type where people point out that I made a mess of a bit of padding, margins and soforth. Or whether something is unclear in the design (such as icons that miss the mark), or people with visual impairments pointing out where I forgot to factor in colour blindness.

For example, Frank de Jonge was so kind on Twitter to point out I missed the mark on the grid, so I got to fix that and really tighten it up.

Created at 2 months ago
issue comment
Open for discussion: design updates

I am in contact with @dragoonis on this and it looks promising. Yesterday I did some extra iterations on the original design:

image

There's quite some more legwork involved; and new responsive designs are needed and there are more pages than the homepage. But there seems to be progress :)

Created at 2 months ago

Add used-by resolving

one of the missing features in phpDocumentor was the automatic generation of used-by tags. By now a new compiler pass will create the used-by tags for all uses tags. The references are resolved by the linker first, after this step we will create the counter tags.

Add used-by tag support

Bump symfony/console from 5.4.7 to 5.4.10

Bumps symfony/console from 5.4.7 to 5.4.10.


updated-dependencies:

  • dependency-name: symfony/console dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Bump symfony/finder from 5.4.3 to 5.4.8

Bumps symfony/finder from 5.4.3 to 5.4.8.


updated-dependencies:

  • dependency-name: symfony/finder dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Bump symfony/yaml from 5.4.3 to 5.4.10

Bumps symfony/yaml from 5.4.3 to 5.4.10.


updated-dependencies:

  • dependency-name: symfony/yaml dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Bump symfony/event-dispatcher from 5.4.3 to 5.4.9

Bumps symfony/event-dispatcher from 5.4.3 to 5.4.9.


updated-dependencies:

  • dependency-name: symfony/event-dispatcher dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Bump league/tactician-bundle from 1.3.2 to 1.4.0

Bumps league/tactician-bundle from 1.3.2 to 1.4.0.


updated-dependencies:

  • dependency-name: league/tactician-bundle dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Bump psalm/phar from 4.22.0 to 4.24.0

Bumps psalm/phar from 4.22.0 to 4.24.0.


updated-dependencies:

  • dependency-name: psalm/phar dependency-type: direct:development update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Bump symfony/config from 5.4.3 to 5.4.9

Bumps symfony/config from 5.4.3 to 5.4.9.


updated-dependencies:

  • dependency-name: symfony/config dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Bump symfony/dom-crawler from 5.4.6 to 5.4.9

Bumps symfony/dom-crawler from 5.4.6 to 5.4.9.


updated-dependencies:

  • dependency-name: symfony/dom-crawler dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Merge pull request #3255 from phpDocumentor/dependabot/composer/symfony/console-5.4.10

Bump symfony/console from 5.4.7 to 5.4.10

Bump symfony/monolog-bundle from 3.7.1 to 3.8.0

Bumps symfony/monolog-bundle from 3.7.1 to 3.8.0.


updated-dependencies:

  • dependency-name: symfony/monolog-bundle dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Merge pull request #3256 from phpDocumentor/dependabot/composer/symfony/finder-5.4.8

Bump symfony/finder from 5.4.3 to 5.4.8

Bump symfony/http-foundation from 5.4.6 to 5.4.10

Bumps symfony/http-foundation from 5.4.6 to 5.4.10.


updated-dependencies:

  • dependency-name: symfony/http-foundation dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Do Phpstan 7 changes

Signed-off-by: Mike van Riel me@mikevanriel.com

Support Location attribute on templates

In this commit, I have added handling, tests and documentation for the 'location' attribute in the template configuration entry. This should now work and attempt to load the template from the given directory on the host's filesystem.

Because I kept running into issues with how phpstan and psalm interpret the configuration array shape; I have also cleaned that part up and used psalm-type definitions to provide a reusable shape. I chose not to use phpstan-type annotations because phpstan understands the psalm annotations but not vice versa.

Unfortunately, I discovered that we are using an antiquated version of phpstan that does not like array-shape type aliases. This is fixed in a newer version but I need @jaapio his input whether we version locked for a reason.

Signed-off-by: Mike van Riel me@mikevanriel.com

Introduce newer phpstan version

It is still throwing errors, I am giving up for now. I need to continue this later as for some reason the imported type in ApiSpecification.php is not picked up

Tightening the configuration interfaces

The work done in this commit is partly to satisfy Psalm 1.8. Not that it is wrong, but there were quite a few improvements to be had as the configuration section of phpDocumentor is quite dynamic. This could use some tightening in the future, but for now these changes will help a great deal already.

Bump league/commonmark from 2.2.3 to 2.3.4

Bumps league/commonmark from 2.2.3 to 2.3.4.


updated-dependencies:

  • dependency-name: league/commonmark dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Resolve remaining phpstan, phpcs and unit testing issues

Created at 2 months ago
mvriel delete branch fix/make-windows-tests-run-again
Created at 2 months ago

Windows tests keep failing

I have removed phive from the build pipeline because it keeps giving timeouts when running the windows tests. This is a combination of phive having too strict a timeout apparently and the Windows runners of Github Action being slow.

Even though it would be nice to keep Phive in the pipeline, I just cannot keep the windows tests failing much longer and the only surefire fix is to replace phive with oldschool tooling

At the end of this change, the windows build still fails. But now it is due to a legitimate failure. As such, I have kept the setting on that will allow failures on windows; this way I can fix those failures in a subsequent commit

Created at 2 months ago
pull request closed
Windows tests keep failing

I have removed phive from the build pipeline because it keeps giving timeouts when running the windows tests. This is a combination of phive having too strict a timeout apparently and the Windows runners of Github Action being slow.

Even though it would be nice to keep Phive in the pipeline, I just cannot keep the windows tests failing much longer and the only surefire fix is to replace phive with oldschool tooling

Created at 2 months ago