57
140
7
Events
Fix phpunit warnings
Changed code coverage check to 64 because pipeline is weird
For a reason that I do not know, the pipeline shows a far lower coverage than running it locally. This now breaks the pipeline for this PR, and the only way to fix that would be to write extra unrelated tests, or change the number temporarily.
Merge branch 'transform-per-documentation-set' into introduce-views-to-make-sure-templates-keep-working
Migrate twig rendering to use ViewSet
Change writers to be performed on a per-documentation-set basis
Converted back to draft because I am not sure I did not introduce a bug when rendering guides. I want to check that first
Changed code coverage check to 64 because pipeline is weird
For a reason that I do not know, the pipeline shows a far lower coverage than running it locally. This now breaks the pipeline for this PR, and the only way to fix that would be to write extra unrelated tests, or change the number temporarily.
Introduce views to make sure templates keep working
Note: depends on https://github.com/phpDocumentor/phpDocumentor/pull/3496; merge that first
mvriel create branch introduce-views-to-make-sure-templates-keep-working
Refactor away last uses in writers and tests
Add more restrictions to prevent unwanted side-effects
Change writers to be performed on a per-documentation-set basis
In draft because I want to perform a review myself of these changes first
Change writers to be performed on a per-documentation-set basis
We are inching closer to supporting the whole documentation pipeline per documentation set instead of a per-project level.
This is one of the final steps to make the architecture work in this way.
Once this is solved, we can start experimenting with enabling multi-documentation-set rendering and discovering the issues stemming from that.
Elements offset is required
When building documentation, the elements offset is required and as such I have moved the initialization to the front of the compiler.
A question could be whether this is really needed, but I have postponed that question for later; so that the effort to support Documentation Sets progresses.
Ensure elements index builder only runs on api sets
Refactor all compilers to work on a DocumentationSet
I'm missing some checks on ApiSetDescriptor in some of the compiler passes. Did I overlook something?
I have explicitly not added these and tried to keep it as generic as possible. At the moment, guides do not use files and indexes; but I would love to have this a generic mechanism across all Documentation Sets.
At this point, because only API Sets populate these indexes, I have limited the checks on API Sets only where it really is about API Sets. You can find a few of these in the compiler passes themselves
PHP Fatal error
As for the deprecations, these are upstream issues as far as I can determine right now. When we were to upgrade box, they may be resolved but at the moment our focus is not yet on these deprecation messages.
Guides: references to API documentation resolve to the wrong directory
When I use the :php:class: or any of the other :php: references, then a correct path seems be rendered but I and up on the path file://wsl%24/classes/ instead of the correct file location.
Guides: references to API documentation resolve to the wrong directory
I believe this issue is resolved now
Unable to parse file "xxx.php", an error was detected: An array can have only integers or strings as keys
I have just attempted to reproduce the scenario but was unable to:
I know about this issue, but I believe it is resolved with the latest version of the TypeResolver library.
Can you pull the latest version of phpDocumentor's docker image (docker pull phpdoc/phpdoc) and try again?
