mussbach
Repos
2

Events

feature (refs T30254): add a makeAddonCollection() method to get the $transformerName of the class instead of the interface. Add a getInstance() method to the BaseTransformer.php to get the instance in the addon.

Created at 13 hours ago

chore: use current demos-europe/demosplan-addon

Created at 14 hours ago

feat: provide link to external identity provider

  • feat: provide link to external identity provider

  • style: Apply php-cs-fixer


Co-authored-by: Demos-CI devops-system+github@demos-deutschland.de

Created at 14 hours ago
mussbach delete branch f_testlink_to_external_idp
Created at 14 hours ago
pull request closed
feat: provide link to external identity provider

This PR adds a possibility to login via external identity provider in development environments on top on login via form.

How to review/test

set gateway_url to something like /connect/keycloak_ozg and find a (unstyled) link to the external idp

Linked PRs (optional)

Tasks (optional)

PR Checklist

Delete the checkbox if it doesn't apply/isn't necessary.

  • [ ] Tests updated/created
  • [ ] Update documentation
  • [ ] Link all relevant tickets
  • [ ] Move the tickets on the board accordingly
Created at 14 hours ago
pull request opened
feat: provide link to external identity provider

This PR adds a possibility to login via external identity provider in development environments on top on login via form.

How to review/test

set gateway_url to something like /connect/keycloak_ozg and find a (unstyled) link to the external idp

Linked PRs (optional)

Tasks (optional)

PR Checklist

Delete the checkbox if it doesn't apply/isn't necessary.

  • [ ] Tests updated/created
  • [ ] Update documentation
  • [ ] Link all relevant tickets
  • [ ] Move the tickets on the board accordingly
Created at 14 hours ago
mussbach delete branch f_improve_mail_handling
Created at 14 hours ago

chore: do not report mails as sent in case of an error

chore: do not report mails as send in case of an error

Moreover, do not delete mail attachments, when mail could not be sent

Created at 14 hours ago
pull request closed
chore: do not report mails as sent in case of an error

Moreover, do not delete mail attachments, when mail could not be sent

How to review/test

code review might be best

Linked PRs (optional)

Tasks (optional)

PR Checklist

Delete the checkbox if it doesn't apply/isn't necessary.

  • [ ] Tests updated/created
  • [ ] Update documentation
  • [ ] Link all relevant tickets
  • [ ] Move the tickets on the board accordingly
Created at 14 hours ago
mussbach create branch f_testlink_to_external_idp
Created at 14 hours ago

fix (refs T16953): handle missing username in report entry

In case a user was deleted we use a translation that implies this.

In case the user has no name, which is the case for the anonymous user (aka "system" user) we use a translation that implies this.

fix (refs T16953): adjust maintenance task exception handling

If one of the tasks fails the others should still be attempted to be done.

fix (refs T16953): use correct if condition

style: Apply php-cs-fixer

fix (refs T16953): adjust exception message wording

Merge remote-tracking branch 'origin/b_T16953_user_name_report' into b_T16953_user_name_report

fix (refs T16953): avoid exception in maintenance task (#1000)

feature (refs T31261): fix import of docx paragraph-elements. fix deletion of imported docx file after processing.

(cherry picked from commit 1303c7da8a79475fbabe8e0f982171b67444f9b4)

fix (refs T31722): skip deleted files when copied from blueprint (#988)

  • fix (refs T31722): skip deleted files when copied from blueprint

  • chore (refs T31722): split long comment line

bug(refs T31795): add slots for boilerplate (#969)

  • bug(refs T31795): Add slot for boilerplate in twig

DpEditor was refactored and now there is a slot for the boilerplateModal needed. Also renamed the event for inserting boilerplates, because camelCase does not work in html.

  • bug(refs T31795): Rename event for inserting boilerplates

  • bug(refs T31795): Remove link

(cherry picked from commit 80b0251673cabdd1b1b73333a28070bd41e269ce)

chore (refs T31795): fix component imports (#1017)

  • chore (refs T31795): fix component imports

Webpack could not find the 2 changed components as they need to be loaded from demosplan-ui now.

  • bug(refs: T31795): load components from core instead of ui
  • Since these files were moved from the ui to core, these adjustements had to be reverted to move the files to their final destination.
  • bug(refs: T31795): move DpBoilerplate.vue to core
  • Since this is the place to be for this component
  • style: Update license header

  • bug(refs: T31795): move DpRecommendationModal.vue to core

  • Since this is the place to be for this component
  • Also needed to move DpInserttableRecommendation since DpRecommendationModal requires it
  • bug(refs: T31795): fix license header duplication

Co-authored-by: Velimir Müller velimir@demos-deutschland.de Co-authored-by: Demos-CI devops-system+github@demos-deutschland.de

chore (refs T31795): fix component imports

Webpack could not find the 2 changed components as they need to be loaded from demosplan-ui now.

fix (refs T31622, T16953): fix user id in report entry (#1030)

The user id is not nullable for report entries. So even if we don't really have a user and use the default fallback name, we still have to set the user id to at least empty string.

fix(refs T32058): Make check for maxExtent do what's suppose to do (#1111)

  • chore (refs T31116): rename prop to make that clear, because prop as function. (cherry picked from commit 15442a10727670e8d741872f55453307846cb4b7)
  • fix(refs T32058): Check against length for Arrays
  • refactor(refs T32058): Refactor usage of maxExtent

Co-authored-by: Ahmad Alahrashi alahrashi@demos-deutschland.de Co-authored-by: AlexMenschoid meyer-schlichtmann@demos-deutschland.de

Merge branch 'release_bobsh' into m_m_r

Conflicts:

client/js/bundles/news/newsAdminEdit.js

client/js/bundles/news/newsAdminNew.js

client/js/bundles/procedure/administrationSendEmail.js

client/js/bundles/procedure/administrationUnregisteredPublicagencyEmail.js

client/js/bundles/statement/assessmentStatement.js

client/js/bundles/user/customersettingsmail.js

client/js/components/map/map/DpOlMap.vue

client/js/components/map/publicdetail/Map.vue

client/js/components/procedure/SegmentsBulkEdit/SegmentsBulkEdit.vue

client/js/components/procedure/StatementSegmentsList/StatementSegment.vue

client/js/components/statement/DpBoilerPlate.vue

client/js/components/statement/assessmentTable/DpBulkEditFragment.vue

client/js/components/statement/assessmentTable/DpBulkEditStatement.vue

client/js/components/statement/assessmentTable/TiptapEditText.vue

demosplan/DemosPlanDocumentBundle/Tools/ServiceImporter.php

demosplan/DemosPlanProcedureBundle/Logic/PrepareReportFromProcedureService.php

package.json

yarn.lock

Created at 15 hours ago

feat: add init container tasks

refs Ado 2286

Merge branch 'main' into f_provide_init_container

fix: migrate database before populating

Merge branch 'release' into f_provide_init_container

style: Apply php-cs-fixer

feat: send logs to stdout/stderr

chore: Update messed up yarn.lock

Merge pull request #463 from demos-europe/b_update_yarn_

chore: Update yarn.lock

Merge pull request #427 from demos-europe/f_provide_init_container

refs T28839: provide database init command

fix: ExportFieldsConfiguration needs to be set on new procedures

Merge branch 'release_diplanbau' into m_m_r

Conflicts:

composer.lock

demosplan/DemosPlanCoreBundle/Command/ContainerInitCommand.php

yarn.lock

chore: update php vendors after merge

Merge remote-tracking branch 'origin/main'

Created at 16 hours ago
mussbach delete branch dependabot/composer/phpstan/phpstan-symfony-1.2.24
Created at 16 hours ago

chore(deps-dev): bump phpstan/phpstan-symfony from 1.2.23 to 1.2.24

Bumps phpstan/phpstan-symfony from 1.2.23 to 1.2.24.


updated-dependencies:

  • dependency-name: phpstan/phpstan-symfony dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Created at 16 hours ago
pull request closed
chore(deps-dev): bump phpstan/phpstan-symfony from 1.2.23 to 1.2.24

Bumps phpstan/phpstan-symfony from 1.2.23 to 1.2.24.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Created at 16 hours ago

F_T31511 use RpcMethodAddonSolverInterface instead RpcMethodSolverInterface to autoconfigurate services.

F_T31511 make statement splitting possible (#1094)

feature (refs T30254): update composer.lock (#1101)

due to changes in demosplan-addon

F adjust lock method return type

F adjust return type (#1104)

Merge branch 'release'

Created at 16 hours ago

F t30835 adjusted keycloak data mapping AB#3112

  • feat (refs T30835): Using Interface to allow different specific implementations for different use cases.

Rename properties to improve readability Enhance documentation to improve readability

  • feat (refs T30835): improve/adjust logging to make cases visible in log-files.

  • feat (refs T30835): fix typo

  • feat (refs T30835): Rename properties to improve readability

Roles needs to be client and customer specific. That will specification will be handled in each specific implementation of OzgKeycloakResponseInterface.php

  • feat (refs T30835): Use Interface to allow implementation of different specification responses of different clients/customers.

  • feat (refs T30835): Enhance documentation

  • feat (refs T30835): Adjust mapping to given example

  • feat (refs T30835): simplify by remove unnecessary variable

  • feat (refs T30835): Remove unnecessary parameter, because this one is already part of the object

  • feat (refs T30835): Fix check of existingOrga, because it can be an object or null.

Using this by checking it like a bool makes no sense to me. Also compare UUID of an Entity instead of the entire object, to avoid false positives.

  • feat (refs T30835): Fix check of existingOrga, because it can be an object or null.

Using this by checking it like a bool makes no sense to me. Also compare UUID of an Entity instead of the entire object, to avoid false positives.

  • feat (refs T30835): Keep valueObject simple and just define and use a mapping here.

Incoming is a customer - role relation. This is how it will be mapped but interpreted later on.

  • feat (refs T30835): Fix previously implemented bug. Because $ozgKeycloakResponse is needed as parameter here.

  • feat (refs T30835): Fix previously implemented bug. Because $ozgKeycloakResponse is needed as parameter here.

  • feat (refs T30835): Only allow roles of current customer.

  • feat (refs T30835): rename method to improve readability

  • feat (refs T30835): WIP Test to cover conversion/mapping of token to BasicKeycloakResponse.

  • feat (refs T30835): WIP: create test to cover mapping BasicKeycloakResponse to demosplan-user.

  • feat (refs T30835): Renaming to improve readability.

KeycloakResponse -> KeycloakUserData BasicKeycloakResponse -> BasicKeycloakUserData

  • feat (refs T30835): Renaming to improve readability.

  • feat (refs T30835): minor: documentation

  • feat (refs T30835): Renaming to improve readability.

  • feat (refs T30835): use typed parameter to improve DX

  • feat (refs T30835): Renaming to improve readability.

  • feat (refs T30835): Enhance test-coverage to improve stability, maintainability and extensibility

  • feat (refs T30835): WIP prepare additional test of mapping a user.

  • feat (refs T30835): minor: improve DX by avoid usage of additional variable

  • feat (refs T30835): Use customer::subdomain instead of customer::name, because that's the value which is currently normally used as identifier.

Enhance logging to improve maintainability Implement magic toString() to allow easy usage in logger.

  • style: Apply php-cs-fixer

  • feat (refs T30835): add magic toString to interface to ensure existence

  • feat (refs T30835): remove leftover comment

  • feat (refs T30835): remove unnecessary variable

  • feat (refs T30835): Use actually existing name fields of dplan-user because these can be mapped easily 1:1 and therefore improve the dx and maintainability

  • feat (refs T30835): Use actually existing name fields of dplan-user because these can be mapped easily 1:1 and therefore improve the dx and maintainability

  • feat (refs T30835): remove leftover todo

  • feat (refs T30835): remove unnecessary/duplicated logic

  • feat (refs T30835): improve DX by sorting parameters alphabetically

  • feat (refs T30835): Renaming and documentation to improve readability

  • style: Apply php-cs-fixer

  • feat (refs T30835): Add example of data in docblock to improve readability

  • style: Apply php-cs-fixer

  • feat (refs T30835): Avoid overwrite $customerRoleRelationString on every loop iteration

  • feat (refs T30835): Remove non workable tests, because I'm not able to fix them doe to lack of working local test environment.

  • feat (refs T30835): Rename VO-class to fit actual use case


Co-authored-by: Demos-CI devops-system+github@demos-deutschland.de

fix(refs T31998): restore setActiveTabId (#1079)

Somehow the invoking of setActiveTabId got lost during the refactoring of the component. Anyhow, here we go again.

feature (refs T31926): use new Response instance to prevent null value (#1081)

feature (refs T31926): use new Response instance for method processRequestParameters instead of null

feature (refs T31926): change method of EventSubscriber from private to public. (#1082)

  • feature (refs T31926): change method of EventSubscriber from private to public.

  • style: Apply php-cs-fixer


Co-authored-by: Demos-CI devops-system+github@demos-deutschland.de

refactor: set gateway_url to keycloak as default

refactor: set gateway_url to keycloak as default (#1084)

Feat ref 30254 related addon adjustements (#667)

  • Feat (ref:30254) : remove the table statement_import_email_processed_attachments
  • the property processedAttachments was removed for now from the StatementImportEmail entity : this was made for The attachments of an email that are currently being processed by the PDF importer or have been finished processing. This has to be redone when this fonctionality is needed

ADO: 1740

  • Feat (ref:30254) : implement EmailAddressInterface

ADO: 1740

  • Feat (ref:30254) : adjust use statements
  • passing event name when dispatching

ADO: 1740

  • Feat (ref:30254) : implements IsOriginalStatementAvailableEventInterface
  • passing event name when dispatching

ADO: 1740

  • Feat (ref:30254) : implements PostNewProcedureCreatedEventInterface and PostProcedureDeletedEventInterface
  • passing event name when dispatching

ADO: 1740

  • Feat (ref:30254) : implements OriginalStatementResourceTypeInterface

ADO: 1740

  • Feat (ref:30254) : implements EmailAddressRepositoryInterface

ADO: 1740

  • Feat (ref:30254) : implements UserServiceInterface

ADO: 1740

  • Feat (ref:30254) : move JsonApiClient to demosplan addon
  • this class is only used by maillane which is not anymore in core, that's why it will be moved to demosplan addon.

ADO: 1740

  • Feat (ref:30254) : implements UserResourceTypeInterface

ADO: 1740

  • style: Apply php-cs-fixer

  • style: Apply php-cs-fixer

  • F (ref:T30530): adjust use statement

  • F (ref:T30530): adjust service yaml

  • F (ref:T30530): add HandleEmailAddressSubscriber

  • the logic in this subscriber was in maillane addon, since we handle here data from the database (get or persist Emailaddreses) and use other entities repository which are in core, it's better to moved to core where i think it is the right place to do it.
  • F (ref:F_T30254): mount email import vue

  • style: Apply php-cs-fixer

  • F (ref:F_T30254): add use statement

  • feat(refs: T30254): enable saving of extraEmailAdresses for addon

  • The child component DpEmailList emits the vlaue of an added email address to its parent.
  • With this implementation the functionality of DpEmailList remains untouched but enables the parent component DpAllowedSenderEmailList to save the value by using the api
  • This was needed because the old way of submitting a symfony form was not possible anymore hence the decision was made to use the api instead
  • feat(refs: T30254): enable updating of extraEmailAdresses for addon
  • The child component DpEmailList emits the vlaue of an added email address and the index to its parent.
  • With this implementation the functionality of DpEmailList remains untouched but enables the parent component DpAllowedSenderEmailList to update the value by using the api
  • This was needed because the old way of submitting a symfony form was not possible anymore hence the decision was made to use the api instead
  • F (ref:F_T30254): add missing parameter

  • F (ref:F_T30254): set correct template parameter

  • F (ref:F_T30254): add missing Templates parameters

  • style: Apply php-cs-fixer

  • F_T32025 use script fron pakage.json instead the raw command

  • fix(refs: T30254): resolve merge conflicts


Co-authored-by: Demos-CI devops-system+github@demos-deutschland.de Co-authored-by: Velimir Müller velimir@demos-deutschland.de Co-authored-by: muellerdemos mueller+github@demos-deutschland.de

fix (refs T32007): avoid type error

feature (refs T29882): alter path to json schemas

feature (refs T31936): adjust path to JsonSchema

fix (refs T32003): disable permissions for institution tagging

fix (refs T32003): enable permissions for institution tagging only for DiPlanBau

T31993 fix statement exporter

  • fix (refs T31993): fix call to not existing method

  • fix (refs T32007): check whether key exists before using it

feature (refs T32008): add orgaName to ReportEntries

  • feature (refs T32008): add orgaName to ReportEntry

  • fix(refs: T32008): Display OrgaName

  • if protocoll entry was triggered by DataInputOrga
  • feature (refs T32008): add createdByDataInputOrga flag to reportEntries

  • style: Apply php-cs-fixer


Co-authored-by: Florian Salis salis@demos-deutschland.de Co-authored-by: Demos-CI devops-system+github@demos-deutschland.de

Remove pattern validation for city (#1088)

It does not add value for users to restrict the input for the "city" field based on assumptions that can prove wrong anytime. It will do little harm to remove the restriction (which will eventually lead to a typo going unnoticed) but it will cause massive trouble for users failing for a too-restrictive validation.

F T32013 submitters of the same statement are not saved

  • F_T32013 adjust SimilarStatementSubmitterResourceType
  • adjust isDirectlyAccessible : set on true
  • add getAccessCondition
  • F_T32013 adjust createPersonAndAddToStatementWithResourceType
  • addEntitiesToPersist need an array as parameter, an object was given

Update demosplan-ui to v0.0.18 (#1090)

This updates to the latest version which fixes DpUpload.

feature (refs T30254): update composer.lock

due to changes in demosplan-addon

Merge branch 'release'

Conflicts:

client/js/components/procedure/AdministrationImport/AdministrationImport.vue

yarn.lock

Created at 2 days ago
mussbach delete branch f_T30254_push_composer_lock
Created at 2 days ago

feature (refs T30254): update composer.lock

due to changes in demosplan-addon

Created at 2 days ago
pull request closed
feature (refs T30254): update composer.lock

Ticket: https://yaits.demos-deutschland.de/T30254

Description: update composer.lock due to changes in demosplan-addon

  • [ ] Tests updated/created
  • [ ] Update documentation
  • [x] Link all relevant tickets
  • [ ] Move the tickets on the board accordingly
Created at 2 days ago

doc: Prepare release

Created at 2 days ago