Probably an error with the core. I did not looked into it yet, but could you reproduce that issue with a go binary instead of using the python wrapper?
In theory, it is a breaking change as this changes the API. But as this is only the result of a typo, I would say it is a fix and would approve it as a fix commit.
Why shouldn't it?
Isn't *.vue
just a normal text file format?
You can ignore .vue
files, i.e. --exclude '*.vue$'
.
I do not think we should implement ESLint rules into editorconfig-checker, these are totally different responsibilities.
Could be some kind of race condition if editorconfig-checker tries to read the file while it's not present anymore I think.
That's a great suggestion! Pull Requests are appreciated, I'm not sure when and if I find the time to implement this.
Would be great if you could confirm this, and if this is the case. Additionally, if that is the case it would be great if you could provide some steps to reproduce it, even if it only happens occasionally.
What do you mean by sometimes? What's the difference when it fails and when not?
fix: set paranthesis
feat: read arbitrary keys
I did not plan it yet. If someone is willing to provide a PR I will sure have a look at it and merge it if it's good.
Would be good to have some kind of release automation. i.e. push a tag and do an npm publish and create a github release + automatic change log generation.
Feel free to provide a PR if you feel comfortable doing this.
Hey, what advantages do we have when using GitHub releases for this package? Wouldn't everyone install this via npm anyway?
https://github.com/editorconfig/editorconfig-core-test/issues/50
I'm currently implementing a rust version of the core and when running and digging into the test suite I see that
mostly key=value
is used.
Whereas editorconfig specification specifies which key-value pairs are allowed.
Is there some reason for this?
Why don't we use options from the specification? That means every core needs to handle key-value pairs (key=value
) which are not really defined in the spec.