As per the man page,
setenv
requires _POSIX_C_SOURCE
>= 200112L to be defined
before including the appropriate header file (stdlib.h
). As the
other included header files include some standard headers
transitively, this needs to go above all includes.
When using the TEST_FLTEQ
macro, pass float literals for the
comparision argument, to avoid errors of the form:
error: absolute value function 'fabsf' given an argument of
type 'double' but has parameter of type 'float' which may cause
truncation of value [-Werror,-Wabsolute-value]
It looks like fread_and_discard
acts the same as fseek
. If so, this will replace calls to fread_and_discard
with equivalent calls to fseek
✌️
Properly re-read the chunk ID when iterating through subsequent
chunks. This avoids an infinite loop in the case where the data
chunk doesn't immediately follow the fmt
chunk.
Iterate over multiple arguments
Prefix errors with appropriate filename
Move optional helpers into namespace
Add clean
target
Add fseek_opt
implementation
Split out rom_t
and provide some optional IO helpers
Formatting
weird though, the CI logs claims it's using Clang 13.1.6 build 1316, and I didn't have to pass any custom switches to support it at least on 13.0.1 (on Linux)
As per https://en.wikipedia.org/wiki/Xcode#Toolchain_versions Clang bundled with the Apple toolchain reports different versions, so (presuming the brew CI parses what c++ --version
says) the actual version of Clang is likely around 12.0.0 which may not default to C++14 ✌️
To address:
https://github.com/raboof/nethogs/issues/225
add the -std=c++14
flag when building the application.
This then compiles properly with the Apple version of the Clang compiler:
Apple clang version 11.0.0 (clang-1100.0.33.17)
Additionally, this removed some warning noise regarding C++11
extensions used without the appropriate -std=c++11
(or greater)
flag:
./process.h:38:26: warning: alias declarations are a C++11 extension [-Wc++11-extensions] connection.cpp:107:3: warning: 'auto' type specifier is a C++11 extension [-Wc++11-extensions] connection.cpp:108:8: warning: 'auto' type specifier is a C++11 extension [-Wc++11-extensions] connection.cpp:162:3: warning: 'auto' type specifier is a C++11 extension [-Wc++11-extensions] connection.cpp:187:3: warning: 'auto' type specifier is a C++11 extension [-Wc++11-extensions]
Provide output directory as argument
Expect and use a third argument as the output directory
Update file handling
Check for existence of already downloaded message, and use hardlinks if the same message ID is found in a different folder
Rearrange
Track items to consider
Make note of additional support in description
Support 6-button controllers
Dependency updates
Transitive dependencies:
Merge pull request #9 from msbit/bundle-updates-1653262752
Dependency updates