Fix to more recent scssphp/scssphp to prevent 8.x compat warnings

CS fixes

Hi @cweiske. The .phar file for 2.x will not be modified. Archive_Tar should be present in the 3.0 .phar file.

Describe the bug When using the phar version of phing 2.17.4 to build a project, I get an error:

[PHP Error] include_once(Archive/Tar.php): Failed to open stream: No such file or directory [line 75 of phar:///home/cweiske/bin/phing/classes/phing/tasks/ext/TarTask.php]

I expected all required dependencies to be bundled in the phar file.

Steps To Reproduce

  <fileset id="fs.zip" dir=".">
   <include name="data/**"/>
  </fileset>
  <target name="zip" depends="preparedirs">
    <tar compression="bzip2" destfile="out.tar.bz2"
         prefix="myproject-1.2.3/"
    >
     <fileset refid="fs.zip"/>
    </tar>
  </target>

Expected behavior No error because Archive_Tar should be bundled.

Move namespaces and tasks around

Bump deps

Fix all component composer.json files

Initial commit

Initial commit

Type hints

Initial commit

Fixed stability issue

Initial commit

Initial commit

Initial commit

Added test files

Initial commit

Initial commit

Fixed namespace

Initial commit

Initial commit

namespace issues

Small fixes

ci issues

ci issues

Initial commit

Added composer.json

Fixes #1692 - Fix XmlPropertyTask

Add qodana scan

Re-arrange jobs a bit so static analysis runs parallel with tests

Update to PHP 8.2 and Composer 2

Add docker build workflow

Update to PHP 8.2 and Composer 2

Add docker build workflow

Our project still works with PHP 7.4, so I need help using the current documentation on the phing website. Are there copies of v2.* documentation available somewhere? I've encountered several issues while writing my build.xml, and I realized that since my version is 2.*, the "issues" with phpcs may not be issues at all.

Hello, the documentation is available here: https://github.com/phingofficial/phing/tree/2.17.4/docs/docbook5/en/output

Re-arrange jobs a bit so static analysis runs parallel with tests

Add qodana scan

Hi, I'm reluctant to do (another) patch update of Phing 2.x. Are you able to use the latest release candidate for 3.0?

Revert a few changes to make tests work again

Convert to in-memory event storage, rebuild trigger

Filter out files that we can't expand

Min phpunit version to fix PDO warnings

Bump dependencies

Enable fileinfo ext

Require fixed version for pear/pear-core-minimal

Bunch of phpstan fixes

PHPCS fixes

Move all tasks to the default lists again

composer.json modifications for monorepo

Fixes #1686 - support union types

Apparently the exclamation mark got dropped

Update SonarTask.php

Fixes #2 - allow SonarQube Scanner and SonarScanner

Update deps

Fixes #1688 - selectors are not mandatory in project/target tags

Update deps

TstampTask with ICU syntax (#1683)

Fixes #1682 - handle ICU syntax in TstampTask

Add RC4 to changelog/version

Add sponsors section with first sponsor

Explicitly set timezone

Upload clover-coverage.xml to artifacts for debugging

Upload clover-coverage.xml to artifacts for debugging

Bump checkout and cache actions to get rid of deprecation notices

Add 8.2 to the matrix, use as default version for coverage/scrutinizer

Drop PHP 7.3, install the zip extension

Scrutinizer is not ready for 8.2 yet

Use codecov action

Disable xdebug for all test jobs except coverage, drop back to 7.4 for coverage job

8.2 seems to run in circles

Scrutinizer config changes

Describe the bug A previously working phing build file no longer works on RC4/php8.2.

Steps To Reproduce Try to read an xml file via

<xmlproperty file="report.xml" required="true" collapseAttributes="true"/>

Example file

<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
  <testsuite name="Magento\FunctionalTestingFramework.functional" tests="2" assertions="0" errors="2" failures="0" skipped="0" time="0.000000">
    <testcase file="/var/www/dev/tests/acceptance/tests/functional/Magento/_generated/AdminOrderPrintActionsTestCest.php" name="AdminOrderPrintActionsTest" class="Magento\AcceptanceTest\Backend\AdminOrderPrintActionsTestCest" feature="admin order print actions test" assertions="0" time="0.000000"/>
    <testcase file="/var/www/dev/tests/acceptance/tests/functional/Magento/_generated/StorefrontGuestCheckoutTestCest.php" name="StorefrontGuestCheckoutTest" class="Magento\AcceptanceTest\Backend\StorefrontGuestCheckoutTestCest" feature="storefront guest checkout test" assertions="0" time="0.000000"/>
  </testsuite>
</testsuites>

Expected behavior Xml file is read (this works with RC3 / php8.1)

Screenshots / terminal output

BUILD FAILED
count(): Argument #1 ($value) must be of type Countable|array, string given

Total time: 0.0334 seconds

Additional context I believe the issue is this line here https://github.com/phingofficial/phing/blob/3.0.0-RC4/src/Phing/Io/XmlFileParser.php#L94 as implode returns a string https://www.php.net/manual/en/function.implode.php maybe strlen could be an option?

The change was introduced via this commit.

Fixes #1692 - Fix XmlPropertyTask

Hello, I found a bug in Phing 3 RC4.

This MR will fix XmlPropertyTask:

PHP Fatal error: Uncaught TypeError: count(): Argument # 1 ($value) must be of type Countable|array, string given in phar:///usr/local/bin/phing/src/Phing/Io/XmlFileParser.php:94

I also added a small test. Please let me know if I have to change anything.

The current multi-repo setup is causing more trouble than it is solving. There is a significant maintenance burden to keep individual task packages up-to-date, release new versions, and debuga/test task packages.

I've therefor made the choice to revert back to a monorepo setup, where individual task packages are published as read-only subtree splits.

Pre-migration:

• [ ] Make all task repos read-only
• [ ] Prepare on-push script for subtree splits (https://github.com/symplify/monorepo-split-github-action)

Migration:

• [ ] Add monorepo-builder dep (https://github.com/symplify/monorepo-builder)
• [ ] Move task source files from Task/XYZ/src/ to Task/XYZ/
• [ ] Fix namespace of SVN tasks
• [ ] Fix composer.json
• [ ] Add all tasks/types back to taskdef.properties / typedef.properties? Or do something with custom properties?
• [ ] Enable on-push script

Artifact no longer necessary