mrdoob
Repos
42
Followers
19466
Following
172

Events

issue comment
Docs italian version

Thanks!

Created at 1 week ago
issue comment
VRMLLoader: Process Anchor node as grouping node.

Thanks!

Created at 1 week ago
started
Created at 1 week ago
issue comment
MeshPhysicalMaterial: Match behavior of attenuationDistance to KHR_materials_volume

Why do we serialize default values sometimes -- and sometimes not?

Oh! That is a good point. The fact that Infinity is default means we can ignore it when de/serializaing it 👍

Created at 1 week ago

Updated builds.

Created at 1 week ago
issue comment
Docs italian version

Thanks!

Created at 1 week ago

Minimize glActiveTexture calls (#24492)

  • Don't set activetexture for textures that won't be bound

  • Fix texture state update of a previously bound texture

  • Combine bindTexture and bindTextureToSlot into a single function

Created at 1 week ago
issue comment
Minimize glActiveTexture calls

Thanks!

Created at 1 week ago
pull request closed
Minimize glActiveTexture calls

Description

When running spector.js captures of a complex scene, I noticed a number of calls to glActiveTexture that were followed immediately by a separate call to glActiveTexture. This change checks to see if a texture will be bound (or uploaded) before calling ActiveTexture, improving performance by removing these useless gl calls.

This contribution is funded by Meta

Created at 1 week ago
issue comment
Minimize glActiveTexture calls

Much nicer!

Created at 1 week ago
issue comment
docs: Fix CapsuleGeometry property label

Thanks!

Created at 1 week ago
issue comment
NodeEditor: UX Updates

Thanks!

Created at 1 week ago
issue comment
Fix jpeg-js properly (override for all packages)

Thanks!

Created at 1 week ago

Fix jpeg-js properly (override for all packages) (#24639)

Created at 1 week ago
pull request closed
Fix jpeg-js properly (override for all packages)

#24638 continued, this time npm audit is green in the test folder.

Created at 1 week ago

Update FUNDING.yml

Created at 1 week ago
issue comment
WebGLState: Fix setting of `NeverDepth`.

Thanks!

Created at 1 week ago
issue comment
GLTFExporter: Remove `truncateDrawRange` option.

/fyi @fernandojsg

Created at 1 week ago
issue comment
GLTFExporter: Remove `truncateDrawRange` option.

Thanks!

Created at 1 week ago
issue comment
Fix jpeg-js vulnerability reported by Dependabot

Let me try running the security check again...

Created at 1 week ago
issue comment
TrackballControls: Fix multi-touch in `onTouchEnd()`.

Thanks!

Created at 1 week ago
issue comment
MeshPhysicalMaterial: Match behavior of attenuationDistance to KHR_materials_volume

I do not think we can use Infinity... JSON doesn't support Infinity so we wouldn't be able to de/serialize the value.

Created at 1 week ago

Fix jpeg-js vulnerability reported by Dependabot (#24638)

Created at 1 week ago
pull request closed
Fix jpeg-js vulnerability reported by Dependabot

Dependabot reports a security alert when run on three.js project:

Known security vulnerabilities detected

Dependency jpeg-js Version < 0.4.4 Upgrade to ~> 0.4.4 Defined in package-lock.json Vulnerabilities CVE-2022-25851 High severity

The vulnerability is for tests only. Package jpeg-js is brough indirectly by jimp, which is declared in test devDependencies. The jimp seems no longer maintained (see https://github.com/oliver-moran/jimp/issues/1088).

A possible workaround should be to use override in the package.json file. I am not aware of any possible negative impact, but I am not much experienced in npm.

Created at 1 week ago
issue comment
Fix jpeg-js vulnerability reported by Dependabot

Thank you! I've tried to run npm audit fix many times but it would never fix it.

Created at 1 week ago
issue comment
VideoTexture updating at 60-90fps

Yes, we now use requestVideoFrameCallback().

Created at 2 weeks ago
issue comment
ShaderChunks: Remove obsolete comment.

Thanks!

Created at 2 weeks ago
issue comment
Shaders: Remove legacy workaround for Adreno bug

Thanks!

Created at 2 weeks ago
issue comment
Docs: SpotLight.html clean up

Thanks!

Created at 2 weeks ago
issue comment
Docs: Honor blendMode in animation pages.

Thanks!

Created at 2 weeks ago