25
212
1
Events
Bump profiling version
Bump profiling version
[BUG] SIGSEGV in 0.86.0
Thank you for the thorough bug report. We are working to release 0.86.1, and we'll continue to investigate your report after that. Sorry for the production outage.
Revert "perf(profiling): speed up stack walking by using function run_time_cache"
Description
This reverts commit 6c541e48682eb9dd0cff92f493140cdba31ba446.
Changes made by this commit are showing up in backtraces in crash dumps: https://github.com/DataDog/dd-trace-php/issues/1993
For now, we'll revert until we can understand the crash. It appears that accesses to thread-local variables are somehow failing.
Readiness checklist
- [ ] Changelog has been added to the release document.
- [x] ~Tests added for this feature/bug.~
Reviewer checklist
- [x] Appropriate labels assigned.
- [x] Milestone is set.
[Feature] Integration customisation utilities
:wave: I work on profiling and don't know the answer about that, @grigi . However, you should be able to drop the span with something like this:
DDTrace\trace_method(PDO::class, 'prepare', fn () => false);
I confirmed it works for at least this basic example:
<?php
if (extension_loaded('ddtrace')) {
var_dump(DDTrace\trace_method(PDO::class, 'prepare', fn () => false));
}
$pdo = new PDO('sqlite:/tmp/mydb.sq3');
$result = $pdo->prepare('SELECT "hello"'); // no span here
$result->execute();
$hello = $result->fetch(PDO::FETCH_NUM);
var_export($hello); echo PHP_EOL;
Sync profiling version number with tracer
Description
Also bump rust version in the Cargo.toml file. We had previously already bumped the version in other places and just missed this one.
Readiness checklist
- [ ] Changelog has been added to the release document.
- [x] ~Tests added for this feature/bug.~
Reviewer checklist
- [x] Appropriate labels assigned.
- [x] Milestone is set.
fix: upgrate colors to modern colors
At the very least, you are going to need to show screenshots of the home page, releases page, and some documentation page to show your changes.
fix: support for timeouts with ZTS on Linux
Thanks for your work on this!
Fix system ini handling of invalid values in zai config
For historical reference, this came up specifically when testing:
; 98-ddtrace.ini
datadog.profiling.log_level=true
; 99-whatever.ini
datadog.profiling.log_level=off
And I got a warning in the profiler:
[2023-03-20T22:54:55.430860Z WARN datadog_php_profiling::config] zval of type 15 encountered when calling config::profiling_log_level(), expected type int (4)
Thanks, @bwoebi, for fixing this so quickly.
test: skip if preloading isn't available
style: prefer INI over ENV
Remove atomic usage
It's not required by the PHP lifecycle model, and Bob prefers it to be not atomic if not required.
