microsoft
Repos
5369

Visual Studio Code

141933
23189

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

88107
10993

Windows system utilities to maximize productivity

85448
4767

The new Windows Terminal and the original Windows console host, all in the same place!

87361
7389

Events

Construct `OpAccessChains` for `RawBufferLoad` properly, or overhaul the API
struct Test {
    float4 mem1;
    float mem2;
    int mem3;
};

Glslang with GL_EXT_buffer_reference

%23 = OpAccessChain %_ptr_Uniform__ptr_PhysicalStorageBuffer_Test_r %_ %int_0
%24 = OpLoad %_ptr_PhysicalStorageBuffer_Test_r %23
%27 = OpAccessChain %_ptr_PhysicalStorageBuffer_float %24 %int_0 %int_1
%28 = OpLoad %float %27 Aligned 4

DXC with vk::RawBufferLoad<Test>(addr).mem2

%36 = OpBitcast %_ptr_PhysicalStorageBuffer_Test %35
%37 = OpLoad %Test %36 Aligned 4
%38 = OpCompositeExtract %float %37 1
    OpStore %30 %38

Now imagine I declared a large array for histogram or something as a member variable.

This is probably a dup of some issue (searched but couldn't find it in the ocean of open SPIR-V issues), since I'm certainly not the first person to discover this.

My suggestion to fix this is

namespace vk
{

namespace impl
{

// you'll need to magically generate and instantiate internally within Clang when you encounter it
extern template<typename T>
struct AccessChain;
/*
{
   // actually emit the OpLoad
   operator T() const;
   
   // all members redeclared but with types exchanged from U to AccessChain<U>
};
*/

}

template<typename T>
AccessChain<T> RawBufferLoad(uint64_t addr);
}
Created at 3 minutes ago
issue comment
Git: .husky/commit-msg: line 2: pnpm: command not found

It's weird. It happens to one project and disabling all extension doesn't help. Not just pnpm not found. npm also not found when I do npm -v in .husky/commit-msg

Created at 3 minutes ago

fix: v8 SplitButton should not reset focus to trigger after opening menu (#26572)

Created at 3 minutes ago
pull request closed
fix: v8 SplitButton should not reset focus to trigger after opening menu

Previous Behavior

We had a timeout that set focus on the button after a touch tap. I'm not sure we actually need that, but one side effect was that for the SplitButton variant, it was re-setting focus to the trigger after the menu was opened with touch and focus set to the first item.

New Behavior

Focus is not called on the trigger after the timeout if the menu is open.

Related Issue(s)

Created at 3 minutes ago
EasyRhinoMSFT delete branch users/cmeyer/bump-3-3-5
Created at 3 minutes ago

Bump version to 3.3.5 (#488)

Created at 3 minutes ago
pull request closed
Bump version to 3.3.5
Created at 3 minutes ago

Fix issues with didOpen synchronization (#10442)

Merge branch 'main' into coleng/update_actions

Created at 3 minutes ago

updated pod

Created at 3 minutes ago
issue comment
Fix Enum Size Validation Bug

Reopened the PR because I realized the PAN_ issue #1420 were not being picked up because there was no corresponding size of type BYTE. After adding that, it was able to properly give an error that the enum is an incorrect size, and I fixed it accordingly.

Like Kenny suggested, I tested it out with other alignment issues that were reported. I tested it out with #1330, another struct enum issue, by removing the byte size and it was able to properly pick up that the enum was an incorrect size.

Created at 4 minutes ago

fix code scanning warnings

fix code scanning warnings

address review feedback

Created at 4 minutes ago

specify codebasename in tsaoptions.json

Created at 6 minutes ago
- code owners cleanup
Created at 7 minutes ago
baywet delete branch feature/owners
Created at 7 minutes ago
  • code owners cleanup

Merge pull request #66 from microsoft/feature/owners

  • code owners cleanup
Created at 7 minutes ago