mhagstrand
Repos
16
Followers
4
Following
3

Events

mhagstrand create branch NewStatusVar
Created at 1 month ago
delete branch
mhagstrand delete branch RedisLensSave
Created at 2 months ago
pull request opened
Fix the Debian package build for 8.0.28-20 when using percona-server-8.0_builder.sh

I was unable to build Debian packages for version 8.0.28-20 using percona-server-8.0_builder.sh. I had no issues building a previous release release-8.0.27-18.

When attempting to build the Debian source package, I would get the following output and the package would not build:

 dpkg-source --before-build .
dpkg-source: warning: unknown information field 'Conflicts' in input data in general section of control info file
 debian/rules clean
dh clean
   dh_clean
	rm -f debian/debhelper-build-stamp
	rm -rf debian/.debhelper/
	rm -f -- debian/percona-server-rocksdb.substvars debian/libperconaserverclient21.substvars debian/libperconaserverclient21-dev.substvars debian/percona-server-common.substvars debian/percona-server-client.substvars debian/percona-server-server.substvars debian/percona-server-test.substvars debian/percona-server-source.substvars debian/percona-server-dbg.substvars debian/percona-mysql-router.substvars debian/files
	rm -fr -- debian/percona-server-rocksdb/ debian/tmp/ debian/libperconaserverclient21/ debian/libperconaserverclient21-dev/ debian/percona-server-common/ debian/percona-server-client/ debian/percona-server-server/ debian/percona-server-test/ debian/percona-server-source/ debian/percona-server-dbg/ debian/percona-mysql-router/
	find .  \( \( \
		\( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
	        \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
		 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
		 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
		 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
		\) -exec rm -f {} + \) -o \
		\( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \) \)
 dpkg-source -b .
dpkg-source: warning: unknown information field 'Conflicts' in input data in general section of control info file
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building percona-server using existing ./percona-server_8.0.28-20.orig.tar.gz
dpkg-source: info: building percona-server in percona-server_8.0.28-20-2.debian.tar.xz
dpkg-source: info: building percona-server in percona-server_8.0.28-20-2.dsc
 dpkg-genbuildinfo --build=source
 dpkg-genchanges --build=source >../percona-server_8.0.28-20-2_source.changes
dpkg-genchanges: warning: unknown information field 'Conflicts' in input data in general section of control info file
dpkg-genchanges: info: including full source code in upload
 dpkg-source --after-build .
dpkg-source: warning: unknown information field 'Conflicts' in input data in general section of control info file
dpkg-buildpackage: info: full upload (original source is included)
RPM will not be created
source deb package will not be created

This was the warning causing the package not to build: dpkg-source: warning: unknown information field 'Conflicts' in input data in general section of control info file

After moving Conflicts: percona-server-tokudb to the Package: percona-server-server section I was able to build the Debian source package.

Also with the removal of TokuDB from Percona Server, the build tool was outputting the following messages. It did not prevent the build but still seems worth fixing. sed: can't read storage/tokudb/CMakeLists.txt: No such file or directory

Created at 2 months ago
mhagstrand create branch Fix8.0.20-20_Build
Created at 2 months ago

Fix conflicts 8.0.28-20 build

Created at 2 months ago

Fix conflicts 8.0.28-20 build

Created at 2 months ago

PS-7779 Document system-wide crypto-policies for RHEL/CentOS (5.7)

Changes to be committed: modified: source/installation/yum_repo.rst

Implemented PS-7947 (Merge MySQL 5.7.36) (no conflicts)

https://jira.percona.com/browse/PS-7947

Merge pull request #4514 from oleksandr-kachan/merge-mysql-5.7.36-part2

PS-7947: Merge MySQL 5.7.36 part 2

PS-1484: Backport of Bug#22591899: FILE HANDLE LEAK WHEN SETTING SLOW LOG IN MULTIPLE CONNECTIONS.

Need this fix in order to properly fix issue with slow log rotation in case default log name is used.

log open function accessed the log-name system variables without holding a lock on sysvars. This could lead to a race condition between a) several threads trying to change the same logging sys-var b) several threads trying to change inter-related logging sys-vars (e.g. slow log file name, and slow log on/off state) c) a thread changing a logging sys-var, and another thread running FLUSH [ERROR] LOGS (which also read the log name sys vars while reopening the log; and without holding a lock on the sys vars) While this case seems somewhat artificial in that it requires SUPER and a lot of pointless waffling with the log settings, it's only proper that we guard against it all the same. New code factors out the part that reads the sys-var, so it is not run during FLUSH, and makes sure that that part of the code is run from sys-var setters while the sys var lock is still held.

(cherry picked from commit 02c845e6cc5c2679bcb429b621164431d06914de)

PS-1484: Fix slow log rotation when default log name is used

https://jira.percona.com/browse/PS-1484

The slow query log rotation didn't work in case default log name is used.

Reimplemented slow query log rotation functionality based on similar fix at https://github.com/facebook/mysql-5.6/commit/30d9e653c71.

In addition:

  • Reverted some changes in sql/binlog back to upstream state as they are not needed now.
  • Removed not implemented method File_query_log::new_file().
  • Removed a couple of duplicating MTR tests as all test cases for slow log rotation are now located in percona_slowlog_size_limits.

PS-7988: Improve BiDiScan Azure job to properly handle empty commits

https://jira.percona.com/browse/PS-7988

It is possible to have PR which doesn't actually change any file (Null merge for example). Improve BiDiScan Azure job to skip actual check in case there are not any files changed in PR.

Merge pull request #4493 from oleksandr-kachan/PS-1484-5.7

PS-1484: Fix slow log rotation when default log name is used

PS-7940 ON DELETE CASCADE with generated column crashes in innobase_get_computed_value https://jira.percona.com/browse/PS-7940

Problem: Virtual column template of child table is not populated when cascade delete happened on parent table. Failing to initliaze it causes a crash when we are trying remove the secondary index rows defined on virtual column .

Analysis: A cascade delete from the parent table triggers delete on the child table. Before a clustered index record is deleted in the child table, a copy of row is built to remove secondary index records. This copy of the row requires virtual columns to be materialized. Hence, if child table has any virtual columns, we have to initialize virtual column template

Fix: As part of fix e5e8c9d1b2e0 MySQL handle case when child virtual column depends on forign key. To extend the fix we are now initliazing virtual column template if child table has any virtual column.

Fixed PS-7990 - mysqldump --single-transaction creates non-consistent backups

https://jira.percona.com/browse/PS-7990

Problem: After 3bc4362 changes, instead of keeping gathering data from GTID in the begining of the backup and only printing it to the end we also wrongly delayed the query to gather GTID information to the end of the backup, causing a mismatch between data and SET @@GLOBAL.GTID_PURGED statement in the end of the backup.

Fix: Continue gathering GTID in the beginning of backup and only delay the action to print this information.

Merge pull request #4524 from rahulmalik87/PS-5.7-7940

PS-7940 ON DELETE CASCADE with generated column crashes in innobase_g…

Merge pull request #4547 from altmannmarcelo/PS-7990-5.7

Fixed PS-7990 - mysqldump --single-transaction creates non-consistent…

Merge pull request #4544 from oleksandr-kachan/PS-7988-5.7

PS-7988: Improve BiDiScan Azure job to properly handle empty commits (5.7)

PS-7988: Fix BiDiScan Azure job to properly handle empty changed files list

https://jira.percona.com/browse/PS-7988

Merge pull request #4554 from oleksandr-kachan/PS-7988-5.7-fix-empty-check

PS-7988: Fix BiDiScan Azure job to properly handle empty changed files list (5.7)

PS-7995: Update macOS version used for Azure builds to latest

https://jira.percona.com/browse/PS-7995

The macOS-10.14 environment is going to be deprecated soon. Use macOS-10.15 instead.

Merge pull request #4562 from oleksandr-kachan/PS-7995-5.7

PS-7995: Update macOS version used for Azure builds to latest (5.7)

PS-7 fix build

Merge pull request #4565 from EvgeniyPatlan/release-5.7.36-39

PS-7 fix build

Merge pull request #4474 from venkatesh-prasad-v/5.7-PS-7792

PS-7792: On replica Master_User should be blank if not storing in slave_master_info

Merge pull request #4573 from percona/release-5.7.36-39

Release 5.7.36 39

Created at 2 months ago

Add a max load factor to ut_lock_free_hash_t class

Created at 2 months ago

Add a max load factor to ut_lock_free_hash_t class

Created at 2 months ago
mhagstrand create branch LoadFactorDebug
Created at 2 months ago
mhagstrand create branch LoadFactor
Created at 2 months ago
Created at 2 months ago