mendaomn
Repos
64
Followers
10
Following
7

Clone of a popular board game

A naive URL shortner

Telegram bot that I use to track expenses using the 6jars method

Events

pull request opened
Fix sign out not working when a cluster is selected

Description

This PR fixes an issue, making the logout button linking to non-existing pages, instead of properly logging out the user.

Changes

  • make the signout link to be relative to the domain instead of relative to the current path
  • add i18n strings

How Has This Been Tested?

  • manually

References

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [x] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [x] I checked that npm run build builds without any error
  • [x] I checked that clusters are listed correctly
  • [ ] I checked that a new cluster can be created (config is produced and dry run passes)
  • [x] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 13 hours ago
mendaomn create branch fix-logout
Created at 13 hours ago
pull request closed
Remove File Upload as a way to create clusters

Description

This PR removes the possibility of creating a cluster by uploading a file

Changes

  • remove file upload from the options of the radio group
  • remove wizard navigation special case related to the file upload user flow

How Has This Been Tested?

  • unit tests
  • e2e tests locally
  • manually, see screenshot

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [x] I checked that npm run build builds without any error
  • [x] I checked that clusters are listed correctly
  • [x] I checked that a new cluster can be created (config is produced and dry run passes)
  • [x] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 1 day ago

Fix typo in FileUploadButton text

Remove File Upload as a way to create clusters

Merge pull request #539 from aws-samples/remove-from-file

Remove File Upload as a way to create clusters

Created at 1 day ago
mendaomn delete branch remove-from-file
Created at 1 day ago
pull request opened
Remove File Upload as a way to create clusters

Description

This PR removes the possibility of creating a cluster by uploading a file

Changes

  • remove file upload from the options of the radio group
  • remove wizard navigation special case related to the file upload user flow

How Has This Been Tested?

  • unit tests
  • e2e tests locally
  • manually, see screenshot

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [x] I checked that npm run build builds without any error
  • [x] I checked that clusters are listed correctly
  • [x] I checked that a new cluster can be created (config is produced and dry run passes)
  • [x] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 1 day ago
mendaomn create branch remove-from-file
Created at 1 day ago
mendaomn delete branch fix-e2e
Created at 2 days ago

Fix e2e tests

Merge pull request #538 from aws-samples/fix-e2e

Fix e2e tests

Created at 2 days ago
pull request closed
Fix e2e tests

Description

This PR fixes e2e tests, failing after #537

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [ ] I checked that npm run build builds without any error
  • [ ] I checked that clusters are listed correctly
  • [ ] I checked that a new cluster can be created (config is produced and dry run passes)
  • [ ] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 2 days ago
pull request opened
Fix e2e tests

Description

This PR fixes e2e tests, failing after #537

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [ ] I checked that npm run build builds without any error
  • [ ] I checked that clusters are listed correctly
  • [ ] I checked that a new cluster can be created (config is produced and dry run passes)
  • [ ] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 2 days ago
mendaomn create branch fix-e2e
Created at 2 days ago

Add HelpPanel to Official Images page

Merge pull request #525 from aws-samples/official-images-help-panel

Add HelpPanel to Official Images page

Created at 2 days ago
mendaomn delete branch official-images-help-panel
Created at 2 days ago
pull request closed
Add HelpPanel to Official Images page

Description

This PR adds the help panel content for the Official Images page

It builds on #521

Changes

How Has This Been Tested?

  • manually

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [x] I checked that npm run build builds without any error
  • [ ] I checked that clusters are listed correctly
  • [ ] I checked that a new cluster can be created (config is produced and dry run passes)
  • [ ] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 2 days ago

Add HelpPanel to Create or Edit review page

Merge pull request #537 from aws-samples/create-cluster-review-page-help-panel

Add HelpPanel to Create or Edit review page

Created at 2 days ago
mendaomn delete branch create-cluster-review-page-help-panel
Created at 2 days ago
pull request closed
Add HelpPanel to Create or Edit review page

Description

This PR adds the help panel content for the Create or Edit review page

Changes

image

How Has This Been Tested?

  • manually

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [ ] I checked that npm run build builds without any error
  • [ ] I checked that clusters are listed correctly
  • [ ] I checked that a new cluster can be created (config is produced and dry run passes)
  • [ ] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 2 days ago

removed EcrRecipeVersion + explicited the expected format for PCUI version and shortversion

Add HelpPanel to Custom Images page

Add custom links to the Help Panel footer

Add help panel for the clusters list

Customize ec2 connect help panel

Align unit test

Extend help panel content to include Build image content

Add i18n strings in DeleteDialog component

Add User type

Users page: move delete button in header and align actions. Display a flashbar in case an invalid email is entered.

Replace Toggle with Checkbox instances everywhere in the wizard

Move actions in header section in cluster instances tab

Merge pull request #524 from aws-samples/custom-images-help-panel

Add HelpPanel to Custom Images page

Add help panel for wizard cluster properties

Replace view configuration button with a link

helppanel implementation for Source wizard step

fix breaking e2e test

Remove SMS and MFA Parameters

  • This commit removes two old parameters EnableMFA, and AdminUserPhone that were used for SMS based MFA. Instead of this we advise users to setup MFA using an authenticator app following the instructions here.

Signed-off-by: Sean Smith seaam@amazon.com

Remove MFA Settings in Code

Signed-off-by: Sean Smith seaam@amazon.com

Use Table component in custom images tags tab

Created at 2 days ago

Add HelpPanel to Custom Images page

Extend help panel content to include Build image content

Merge pull request #524 from aws-samples/custom-images-help-panel

Add HelpPanel to Custom Images page

Add help panel for wizard cluster properties

Replace view configuration button with a link

helppanel implementation for Source wizard step

fix breaking e2e test

Remove SMS and MFA Parameters

  • This commit removes two old parameters EnableMFA, and AdminUserPhone that were used for SMS based MFA. Instead of this we advise users to setup MFA using an authenticator app following the instructions here.

Signed-off-by: Sean Smith seaam@amazon.com

Remove MFA Settings in Code

Signed-off-by: Sean Smith seaam@amazon.com

Use Table component in custom images tags tab

Fixed e2e test

Remove icons in select dropdowns

Add head node help panels

Remove unnecessary paragraph in help panel

Fix an help panel bug causing a wrong re-render

Add HelpPanel to Users page

Created at 2 days ago
pull request opened
Add HelpPanel to Create or Edit review page

Description

This PR adds the help panel content for the Create or Edit review page

Changes

image

How Has This Been Tested?

  • manually

PR Quality Checklist

  • [ ] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • [ ] I checked that infrastructure/update_infrastructure.sh runs without any error
  • [ ] I checked that npm run build builds without any error
  • [ ] I checked that clusters are listed correctly
  • [ ] I checked that a new cluster can be created (config is produced and dry run passes)
  • [ ] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 2 days ago
mendaomn create branch create-cluster-review-page-help-panel
Created at 2 days ago