@BBBmau do you have a sense of when this will land in a tagged release?
Update dependencies for 1.19.4
Bump to 0.1.0
Remove override for renderBackground
This method no longer exists in SliderWidget or superclasses. It was added to make sure that the background of the slider rendered correctly for the wide sliders used for the alert limits, but that is no longer necessary with 1.19.4 (or possibly earlier)
After spending some time trying to track down why my download.default_directory
preference for Chrome was not being honored, I determined that the issue was that I was passing a Pathname
object instead of a String
(via Rails.root.join
). It would be great if the Ruby bindings honored Pathname
objects by automatically calling #to_s
on them. Barring that, it should at least error out instead of silently dropping the preference.
options = Selenium::WebDriver::Chrome::Options.new
options.add_preference(
:download,
prompt_for_download: false,
directory_upgrade: true,
default_directory: Rails.root.join('tmp', 'capybara-downloads')
)
Currently, I have to pass Rails.root.join('tmp', 'capybara-downloads').to_s
to get this to work.
Are you sure that it's
Pathname
used? I've just tried locally and it seems to convert to string correctly
Perhaps not? I was definitely seeing default_directory
omitted when I called options.to_json
and it stopped being an issue when I called #to_s
on the Pathname
, but your test looks valid. The implementation of #as_json
for Pathname
also clearly just calls #to_s
: https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/object/json.rb#L230-L234
That code is unchanged since at least Rails 5.1.0... So I guess I'll close this issue as invalid. There was definitely something weird going on, but I'm not sure anymore what it was.
After spending some time trying to track down why my download.default_directory
preference for Chrome was not being honored, I determined that the issue was that I was passing a Pathname
object instead of a String
(via Rails.root.join
). It would be great if the Ruby bindings honored Pathname
objects by automatically calling #to_s
on them. Barring that, it should at least error out instead of silently dropping the preference.
options = Selenium::WebDriver::Chrome::Options.new
options.add_preference(
:download,
prompt_for_download: false,
directory_upgrade: true,
default_directory: Rails.root.join('tmp', 'capybara-downloads')
)
Currently, I have to pass Rails.root.join('tmp', 'capybara-downloads').to_s
to get this to work.
If this approach looks OK, I can work up some docs
I have created https://github.com/hashicorp/terraform-provider-aws/pull/29978 as a possible next step
This pull request adds an aws_ecs_task_execution
resource to complement data.aws_ecs_task_execution
as added in #29783
Relates #29871
This is almost an exact copy of task_execution_data_source.go
and its tests. The main difference between the resource schemas is that ForceNew
has been added to all non-computed fields in the schema. There are possibly better patterns for making the code between the two more DRY.
I'm unable to run testacc
successfully because a process in our account automatically tags the default security group of any VPC if it has any ingress
or egress
rules. This causes the refresh
to always come back dirty...
If one of the stream-returning methods (doubles, ints, or longs) is called on Random or SecureRandom, don't report that the Random was only used once
Fixes #2370
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.md
if you have changed SpotBugs codeIt feels like there is already a decent amount of control of when you do want an execution to happen using either reference_id
to provide a reference ID that only changes when your logic dictates (perhaps based on an external variable set by a CI pipeline, or based on timestamp()
as in your example if you want it to invoke whenever the other arguments are resolvable, whether during plan
or apply
).
For me, what I really want is to ensure that this does not run during plan
, only during apply
. For that, I feel like the same duality that we currently have between the aws_lambda_function_invocation
data source and the aws_lambda_function_invocation
resource would be helpful. In other words, I would like to see resource "aws_lambda_function_invocation"
introduced alongside data "aws_lambda_function_invocation"
so that I know that the run task invocation will only happen during an apply
.
Ensure that ./run exists for test task
Print copy info for copyToLocalMinecraft
Fix LICENSE renaming in jar file