marcoSven
Repos
42
Followers
8

Stick element to top of screen

Convert state abbreviation to name and vice versa.

CSS3 SpaceBalls inspired animations.

0
0

A book series on JavaScript. @YDKJS on twitter.

Events

fix(ext-link): auto: true when autoLink disabled

avoid the potential confusion of people seeing auto: true in their doc state when they think they have auto linking disabled

https://github.com/remirror/remirror/pull/1741#discussion_r908979336

Created at 3 days ago
issue comment
feature(ext-link): optional link validation function

Thank you @whawker no worries. We are very excited about this project we just switched from Slate to Remirror and love it!

This pr is still a work in progress and will be a minor change. The main changes we want to contribute and block this pr are in https://github.com/remirror/remirror/pull/1743.

Enjoy your summer vacation!

Created at 3 days ago
pull request opened
fix(ext-link): onUpdateLink DOMException

Description

closes #1754

Checklist

  • [x] I have read the contributing document.
  • [x] My code follows the code style of this project and pnpm fix completed successfully.
  • [ ] I have updated the documentation where necessary.
  • [ ] New code is unit tested and all current tests pass when running pnpm test.

Screenshots

see issue #1754

Created at 4 days ago
create branch
marcoSven create branch bug-fix/link-ext-onUpdateLink-DOMException
Created at 4 days ago
opened issue
link ext onUpdateLink DOMException - Failed to execute 'collapse' on 'Selection'

Summary

The issue is with the "onUpdateLink" handler when used with Remirror context. The context has still the previous state. Not 100% sure if this is a bug or if that is intentional.

Steps to reproduce

See code sandbox https://codesandbox.io/s/remirror-update-link-u729f1?file=/src/App.tsx Enter "test.com" and backspace ( delete ) the "m" - "test.co"

Expected results

no error

Actual results

"Failed to execute 'collapse' on 'Selection': The offset 8 is larger than the node's length (7)."

Possible Solution

Push the "onUpdateLink" call to the end of the execution queue

Screenshot(s)

https://user-images.githubusercontent.com/3860298/176131214-eff5c861-6c27-4cbd-b659-aab6cd7c8d77.mov

Created at 4 days ago

refactor

fix(ext-link): lint warning

Created at 4 days ago

refactor & type fixes

Created at 5 days ago

refactor remove leading "/" from url path

perf(ext-link): use regex

Created at 6 days ago

chore: update renovate config (#1736)

chore(deps): update actions/checkout action to v3 (#1738)

Created at 6 days ago

perf(ext-link): use only one validation

reduce possible inks

remove multiple trailing sentence punctuation

fix(ext-link): split links should not unlink

If link is separated by a space only the tail part should be unlinked

fix(ext-link): not detecting complete joining text

Not detecting complete text if appended to path

fix(ext-link): not detecting sentence punctuation

Not detecting sentence punctuation if surrounded by pair punctuation

Created at 6 days ago

fix(ext-link): typo

Created at 1 week ago

Refactor

  • Removed accidental import
  • Created constant for sentence punctuation
  • Removed '<>' from pair punctuation

perf(ext-link): Skip iteration if no valid link is in the match

Created at 1 week ago

fix(ext-link): not auto detecting adjacent text

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in window.confirm

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in window.confirm

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Created at 1 week ago

fix(ext-link): not auto detecting adjacent text

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in window.confirm

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in window.confirm

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Created at 1 week ago
pull request opened
fix(ext-link): not auto detecting adjacent text

Description

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in "window.confirm"

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in "window.confirm"

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Checklist

  • [x] I have read the contributing document.
  • [x] My code follows the code style of this project and pnpm fix completed successfully.
  • [x] I have updated the documentation where necessary.
  • [x] New code is unit tested and all current tests pass when running pnpm test.

Screenshots

https://user-images.githubusercontent.com/3860298/174903466-bcac9fea-e4cb-4233-989f-7c87600b1659.mov

Created at 1 week ago
create branch
marcoSven create branch origin/bug-fix/link-ext-not-auto-detecting-adjacent-text-node
Created at 1 week ago
delete branch
marcoSven delete branch bug-fix/auto-link-not-detecting-trailing-text-node
Created at 1 week ago
pull request closed
fix(ext-link): not auto detecting adjacent text

Description

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in "window.confirm"

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in "window.confirm"

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Checklist

  • [x] I have read the contributing document.
  • [x] My code follows the code style of this project and pnpm fix completed successfully.
  • [x] I have updated the documentation where necessary.
  • [x] New code is unit tested and all current tests pass when running pnpm test.

Screenshots

https://user-images.githubusercontent.com/3860298/174903466-bcac9fea-e4cb-4233-989f-7c87600b1659.mov

Created at 1 week ago

fix(ext-link): not auto detecting adjacent text

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in window.confirm

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in window.confirm

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Created at 1 week ago

fix(ext-link): not auto detecting adjacent text

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in window.confirm

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in window.confirm

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Created at 1 week ago
pull request opened
fix(ext-link): unable to edit links

Description

When href equals text content there is no reason why a link should not be editable.

closes #1740

Checklist

  • [x] I have read the contributing document.
  • [x] My code follows the code style of this project and pnpm fix completed successfully.
  • [x] I have updated the documentation where necessary.
  • [x] New code is unit tested and all current tests pass when running pnpm test.
Created at 1 week ago
create branch
marcoSven create branch bug-fix/unable-to-edit-links
Created at 1 week ago

fix(ext-link): not auto detecting adjacent text

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in window.confirm

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in window.confirm

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Created at 1 week ago
issue comment
Custom link validation function option - link extension

Thank you @Amethystafyy282 I am aware of this option but I am proposing the option to provide your own validation that would be used instead of the autoLinkRegex

https://github.com/marcoSven/remirror/commit/f7f824fd4e72e53e16f69b4617d8f1190009ef8a#diff-c6362a6560783faf0b832a4b10098233042a3092f87b84b29f28f46c94410ac9R158

Created at 1 week ago

Fix(ext-link): Not auto detecting adjacent text

Before this change:

Auto link detection did not detect adjacent text.

Example:

Insert "window.confirm" results in window.confirm

After this change:

Adjacent text is detected and possibly removes invalid link or creates a link

Example:

Insert "window.confirm" results in window.confirm

Added "adjacentPunctuations" option to configure which adjacent punctuation are excluded from links

Closes #1732

Created at 1 week ago
pull request opened
Feature/optional link validation function

Description

Ability to provide a custom link validation function for the Remirror link extension.

Opening as a draft, this feature is based on a branch with an open pull request #1735

closes #1730

Checklist

  • [x] I have read the contributing document.
  • [x] My code follows the code style of this project and pnpm fix completed successfully.
  • [x] I have updated the documentation where necessary.
  • [x] New code is unit tested and all current tests pass when running pnpm test.
Created at 1 week ago