A very basic Whois client for PHP. The library limits function to be a low-level client that handles only request and raw output.
A php library to look up the whois servers of a Top Level Domain.
A collection of useful Laravel snippets in the form of easy to use traits.
I'm interested in helping keep this project going too. I often opt to use this in projects over using Regex. Whatever I can do to help, I'd love to make sure we preserve this as a maintained project for others to benefit too.
From what I can see in the code this issue is still relevant - I'm not seeing any changes to either the example repo, or the installer which would make things consistent. My impression from the comment would be that the generateHostName
function should use the DHCP hostname if one is set, otherwise defaulting to current behaviour makes sense.
Alternatively, it may just be easier to just update the examples repo to remove the comment saying hostname is optional if DHCP is used. Personally I think the former solution is nicer for end users though.
This change will fully fix #66
The issue affects all columns that contain Python dictionaries stored via the str()
method.
So for sure the leadershipSkills
column and purchaseUrls
are affected.
This currently has data like:
{'brawl': False, 'commander': True, 'oathbreaker': False}
This is a valid string version of Python's native dict
type but is not useful outside of ptyhon.
Given that any language can interact with an SQLite file, but not all of them can decode Pythong dicts - this is sad. 😿
To fix this it will now json.dumps
the dict into a valid JSON syntax object.
The after effect is:
{"brawl": false, "commander": true, "oathbreaker": false}
Happy JSON is happy 😸
The great thing about this PR is that it has the bonus effect of fixing the CSVs as well. As of RN, the CSVs also would look like:
,"{'cardKingdomFoil': 'https://mtgjson.com/links/4e3f626b14b25f54', 'tcgplayer': 'https://mtgjson.com/links/74fc1dd3bbb80489'}",
However after the fix they look like:
,"{""cardKingdomFoil"": ""https://mtgjson.com/links/4e3f626b14b25f54"", ""tcgplayer"": ""https://mtgjson.com/links/74fc1dd3bbb80489""}",
This is important since both Excel and Google Sheets will support JSON methods, but don't support python dicts.
Encountering this currently right now too. The issue being that SQLITE files store the JSON-like object in the database, but it's actually a Python dictionary instead of proper JSON. So taking the data into any JSON decode method will fail.
For instance, leadershipSkills
:
{'brawl': False, 'commander': True, 'oathbreaker': False}
Fair enough - I feel like array based configs are suboptimal for the reasons I expressed before. Mainly due to there being no method to ensure the array conforms to our expected shape. Thus requires reading the docs for something that could be learnable via better DX. However if you don't see an issue with those areas I won't change your mind. Cheers
This PR is a WIP to battle test a change in blade-icons. Once the change is made in blade-icons I will update this PR and remove the WIP tag.
Change was rejected upstream.
add way to use (compile time) Env vars in App
encrypt DB
static files for sqlcipher
WIP: Async UI progress
Fix minimum window size on desktop
Improve quit command UX
pick better method name and slight refactors
update for window_size static files
Merge branch 'WIP-async-UI'
Fix minimum window size on desktop
Improve quit command UX
pick better method name and slight refactors
update for window_size static files
small refactor and cleanup
small refactor and cleanup
small refactor and cleanup
small refactor and cleanup
small refactor and cleanup
small refactor and cleanup
small refactor and cleanup
small refactor and cleanup
small refactor and cleanup
try fix composer action cache