loic-sharma
Repos
119
Followers
226
Following
50

A lightweight NuGet and symbol server

2157
439

The NuGet search CLI app

18
0

Delete NuGet packages quickly

12
0

A PHP 5.3 profiler based off of Laravel 3's Anbu.

176
21

A Laravel Bundle for the Swiftmailer library

39
7

A Pokemon game written purely in Javascript

25
11

Events

issue comment
Get user's preferred languages from registry

We keep hitting the issue of Win32 C API calls in tests. It might be worth biting the bullet and creating a Win32API struct with trampoline functions for these like we do with the embedder API in the engine.

That sounds great to me! What are y'alls' thoughts on using windows_proc_table as that trampoline? It was originally meant to provide fallbacks for older Windows versions, but I think the name is general enough that it could be expanded to all win32 APIs for mocking purposes.

Created at 2 days ago
pull request opened
[Windows] Move to Visual Studio 2019

Use Visual Studio 2019 to build the engine. This code was modified from Chromium: https://source.chromium.org/chromium/chromium/src/+/main:build/vs_toolchain.py;l=22-48

This is the draft pull request to update the engine: https://github.com/flutter/engine/pull/36538

This is a requirement to roll ANGLE as it is affected by an STL bug if built using Visual Studio 2017: angleproject#7693

Part of: https://github.com/flutter/flutter/issues/110948

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read the Flutter Style Guide recently, and have followed its advice.
  • [x] I signed the CLA.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Created at 2 days ago

Add print debugging for CI failure

Created at 2 days ago
pull request opened
[Windows] Move to Visual Studio 2019

Use Visual Studio 2019 to build the engine. This is a requirement to roll ANGLE as that is affected by an STL bug in older versions of Visual Studio: angleproject#7693

Part of: https://github.com/flutter/flutter/issues/110948

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Created at 2 days ago

Bump ossf/scorecard-action from 2.0.3 to 2.0.4 (#630)

fix Visual Studio toolchain detection (#628)

Some VS packages may install redistributables in same folder than toolchains, under the name "v143" for instance (starting with a 'v').

In this case, an exception is thrown, as function _SortByHighestVersionNumberFirst does not expect this.

The fix was taken from dart-sdk, that itself takes it from Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/2645652

Bump github/codeql-action from 2.1.25 to 2.1.26 (#631)

Switch to VS 2019

Created at 2 days ago
loic-sharma create branch vs2019
Created at 2 days ago
closed issue
Migrate to new Azure Search SDK

Consider migrating to Azure.Search.Documents for improved performance and easier authentication.

Created at 2 days ago
issue comment
Migrate to new Azure Search SDK

Done in https://github.com/NuGet/NuGet.Jobs/pull/1034

Created at 2 days ago
GLSL's merge to direct for loop is regressed

Problem

The Flutter project has a test that previously used this branch to generate a for loop:

https://github.com/KhronosGroup/SPIRV-Cross/blob/81ba8f78f6646e5635129bd738f25bb3f43bbdb9/spirv_glsl.cpp#L15586-L15596

The test now incorrectly falls back to this branch instead:

https://github.com/KhronosGroup/SPIRV-Cross/blob/81ba8f78f6646e5635129bd738f25bb3f43bbdb9/spirv_glsl.cpp#L15612-L15632

Cause

It seems SPIRBlock is incorrectly initialized here: https://github.com/KhronosGroup/SPIRV-Cross/blob/81ba8f78f6646e5635129bd738f25bb3f43bbdb9/spirv_parser.cpp#L977

After the call to set, I'd expect that current_block->ops.buffer_size to be 0. However, it is a random non-zero value instead. It appears that any members after SPIRBlock.mesh aren't initialized:

https://github.com/KhronosGroup/SPIRV-Cross/blob/81ba8f78f6646e5635129bd738f25bb3f43bbdb9/spirv_common.hpp#L843-L848

As a result, the following check causes block_is_loop_candidate to return false incorrectly:

https://github.com/KhronosGroup/SPIRV-Cross/blob/81ba8f78f6646e5635129bd738f25bb3f43bbdb9/spirv_cross.cpp#L1524-1527

Created at 3 days ago

Commit skipped file

Created at 4 days ago