ljharb
Repos
215
Followers
5711
Following
323

JavaScript Style Guide

131299
22211

Node Version Manager - POSIX-compliant bash script to manage multiple active node.js versions

64362
6488

ECMAScript 5 compatibility shims for legacy (and modern) JavaScript engines

7119
893

A querystring parser with nesting support

7619
685

Tracking ECMAScript Proposals

16388
663

Events

issue comment
@deco before or after export keyword?

A class is already a function - decorators explicitly allow the capability to replace the value being decorated (when it's a class decorator). It would be trivial to ban that, but that was a critical use case for the decorator proposal - a good and necessary practice, not a bad one.

Created at 2 hours ago
issue comment
@deco before or after export keyword?

Of course we have a way to disallow it - decorators explicitly supports that use case because TC39 believes it is NOT a bad practice. If we thought it was a bad practice it wouldn't be possible.

Created at 2 hours ago
issue comment
@deco before or after export keyword?

The decorators are an inseparable part of the "type name" - especially since they might replace the entire value wholesale.

Created at 2 hours ago

[Refactor] hoist some vars to module level

Created at 2 hours ago
Rule proposal: One export per file `single-export-per-file`

Makes sense. Why isn't it welcome there?

Created at 2 hours ago
pull request closed
Update README.md

I ran into an issue installing NVM on my Mac Book Pro. I appended the nvm install instructions with the command to fix the scenario I ran into.

Created at 2 hours ago
issue comment
[no-restricted-exports] Fails on `export { default } from ...`

@elyobo if we enabled the option, it would break on eslint versions older than the one that added it - so, it's a breaking change to do so. This means that there should be a "TODO" comment above the rule, describing it as semver-major, and what change to make - that way, when we next have a breaking change, I'll do a sweep through the comments for any rules that are waiting to be enabled.

Created at 3 hours ago
issue comment
No way to turn off variable interpolation or other advanced features

Does that mean you don't even want to parse them, as opposed to failing loudly when they try to use them?

Created at 3 hours ago
Shane's December 2022 Proposal

I would hope that Temporal is never patched by anything except a 262 and/or 402 compliant polyfill - custom calendars shouldn’t be injected into globals.

Created at 3 hours ago
issue comment
Support Fuzzing JavaScript with Jazzer.js

Will this include some way to permanently persist any failing test inputs?

Created at 4 hours ago
issue comment
[BUG] npm install --omit=dev --omit=peer is installing peer dependencies of dependencies

You can't omit/prune react in this case, you have to link it as well, in both places.

Created at 8 hours ago
issue comment
Temporary access to win-vs2019 machine for @ljharb

I've still not resolved the issue, but I haven't heard further reports from citgm either, so maybe the issue's resolved itself? Either way, I'd prefer the issue to stay open for now.

Created at 8 hours ago
issue comment
[BUG] npm install --omit=dev --omit=peer is installing peer dependencies of dependencies

I think --omit=peer only omits your direct peer deps, not the peer deps of deps (which must be present for those deps to work). In this case, react-text-mask requires react to be present to function. Since you've omitted both dev and peer deps, there's no react present, so npm is forced to try to install a react that satisfies that package's peer dep.

Created at 8 hours ago
Rule proposal: One export per file `single-export-per-file`

@fregante this isn't a multi-file rule (for which "put it in the import plugin" is a very reasonable response), so i'm curious why that's a reason not to accept it into the unicorn plugin? (i can't comment there, unfortunately)

Created at 8 hours ago
issue comment
Custom escapes don't work properly

Looks like the BAREWORD regex hardcodes \s in the regex, which means space characters can't be escaped by the current implementation.

Created at 9 hours ago
rule to prohibit circular dependencies

It should indeed be able to find them; if it's not, please file a new issue. I wouldn't bother setting amd to true, though, if you're just checking require cycles.

Created at 10 hours ago
delete branch
ljharb delete branch nicolo-ribaudo-patch-1
Created at 10 hours ago
pull request closed
Add new import assertions slides
Created at 10 hours ago

Add my constraints

Add new import assertions slides

Created at 10 hours ago

Add new import assertions slides

Created at 10 hours ago
issue comment
No way to turn off variable interpolation or other advanced features

What sort of contexts? I'm not sure it makes sense to add complexity to a package called "shell quote" for non-shell usage.

Created at 10 hours ago
issue comment
No way to specify multiple escape characters

true. altho it's probably more likely that someone is using a multi-char escape sequence than that they're passing an array containing one item

Created at 10 hours ago
rule to prohibit circular dependencies

@srsudar incorrect, it does support them.

Created at 10 hours ago
issue comment
No way to turn off variable interpolation or other advanced features

Are there any shells where these things are off?

Created at 10 hours ago
issue comment
No way to specify multiple escape characters

What form would you expect?

I can imagine a regular expression or a predicate function, but those could have unpredictable results - a simpler option is to accept an array of multiple strings, but that would break anyone who'd been passing in an array of a single character. However, I'd hope nobody is doing this.

Created at 10 hours ago
issue comment
Custom escapes don't work properly

ha, true enough.

i can reproduce the bug easily but i can't figure out how to fix it yet.

Created at 10 hours ago