leth
Repos
49
Followers
27
Following
14

Events

delete branch
leth delete branch btrds-device-stats
Created at 1 week ago

Bump junit from 4.8.2 to 4.13.1

Bumps junit from 4.8.2 to 4.13.1.


updated-dependencies:

  • dependency-name: junit:junit dependency-type: direct:development ...

Signed-off-by: dependabot[bot] support@github.com

Merge pull request #1 from leth/dependabot/maven/junit-junit-4.13.1

Bump junit from 4.8.2 to 4.13.1

Created at 1 month ago
pull request closed
Bump junit from 4.8.2 to 4.13.1

Bumps junit from 4.8.2 to 4.13.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Created at 1 month ago
delete branch
leth delete branch dependabot/maven/org.yaml-snakeyaml-1.26
Created at 1 month ago

Bump snakeyaml from 1.8 to 1.26

Bumps snakeyaml from 1.8 to 1.26.


updated-dependencies:

  • dependency-name: org.yaml:snakeyaml dependency-type: direct:production ...

Signed-off-by: dependabot[bot] support@github.com

Merge pull request #2 from leth/dependabot/maven/org.yaml-snakeyaml-1.26

Bump snakeyaml from 1.8 to 1.26

Created at 1 month ago
pull request closed
Bump snakeyaml from 1.8 to 1.26

Bumps snakeyaml from 1.8 to 1.26.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Created at 1 month ago
delete branch
leth delete branch dependabot/maven/commons-io-commons-io-2.7
Created at 1 month ago

Bump commons-io from 2.0.1 to 2.7

Bumps commons-io from 2.0.1 to 2.7.


updated-dependencies:

  • dependency-name: commons-io:commons-io dependency-type: direct:production ...

Signed-off-by: dependabot[bot] support@github.com

Merge pull request #3 from leth/dependabot/maven/commons-io-commons-io-2.7

Bump commons-io from 2.0.1 to 2.7

Created at 1 month ago
pull request closed
Bump commons-io from 2.0.1 to 2.7

Bumps commons-io from 2.0.1 to 2.7.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Created at 1 month ago
Bump git from 2.6.5 to 4.11.4

Bumps git from 2.6.5 to 4.11.4.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Created at 1 month ago

Rename device_uuid label to btrfs_dev_uuid

It does not appear to be a device UUID, so attempt to be less misleading but keep the label to preserve separation between disks.

Signed-off-by: Marcus Cobden leth@users.noreply.github.com

Created at 2 months ago
issue comment
Add btrfs device error stats

Hmm, I've been trying to find an explanation of UUID_SUB to not much avail. /dev/disk/by-uuid definitely points to the UUID field as identifying the disk. It's not the partition ID, as your blkid has that as a different value.

I'm tempted to drop the label, but I'm worried that without the label the metrics for 2 different disks could overlap (if the path part remaining is non-unique for some reason?). I'm guessing quite a bit here, perhaps it could be BTRFs' internal identifier for this disk?

I'm gonna rename device_uuid to btrfs_dev_uuid.

Created at 2 months ago
issue comment
Support for php v 8.1

Hello! I don't check here often, I don't do any PHP these days! Wow PHP has changed a lot! A major version bump sounds like a good plan. I'd be happy to review a PR!

Created at 2 months ago
issue comment
Add btrfs device error stats

Ah! Thanks! Whoops, would you mind checking if it's the partition uuid?

On 23 Jul 2022, 19:00, at 19:00, "Holger Hoffstätte" @.***> wrote:

am I holding it wrong? :)

I was holding it wrong and successfully tested the master branch. :cocktail: Using the correct branch gives me:

node_btrfs_device_errors_total{device="sdc1",device_uuid="01d2fa5e-0994-4d29-add7-8596122817ca",type="corruption",uuid="d163af2f-6e03-4972-bfd6-30c68b6ed312"}
0
node_btrfs_device_errors_total{device="sdc1",device_uuid="01d2fa5e-0994-4d29-add7-8596122817ca",type="flush",uuid="d163af2f-6e03-4972-bfd6-30c68b6ed312"}
0
node_btrfs_device_errors_total{device="sdc1",device_uuid="01d2fa5e-0994-4d29-add7-8596122817ca",type="generation",uuid="d163af2f-6e03-4972-bfd6-30c68b6ed312"}
0
node_btrfs_device_errors_total{device="sdc1",device_uuid="01d2fa5e-0994-4d29-add7-8596122817ca",type="read",uuid="d163af2f-6e03-4972-bfd6-30c68b6ed312"}
0
node_btrfs_device_errors_total{device="sdc1",device_uuid="01d2fa5e-0994-4d29-add7-8596122817ca",type="write",uuid="d163af2f-6e03-4972-bfd6-30c68b6ed312"}
0

..which looks more or less as expected, though I'm not sure where the device_uuid comes from. I only have a single device sdc1 for my btrfs fs, and its UUID is d163af2f-.. not 01d2fa5e-..

$ls -l /sys/fs/btrfs/d163af2f-6e03-4972-bfd6-30c68b6ed312/devices
total 0
lrwxrwxrwx 1 root root 0 Jul 20 21:28 sdc1 ->
../../../../devices/pci0000:00/0000:00:1f.2/ata6/host5/target5:0:0/5:0:0:0/block/sdc/sdc1

-- Reply to this email directly or view it on GitHub: https://github.com/prometheus/node_exporter/pull/2193#issuecomment-1193164661 You are receiving this because you were mentioned.

Message ID: @.***>

Created at 2 months ago
issue comment
Add btrfs device error stats

Hi @SuperQ! Sorry to chase, but do you have time to review or advise on next steps? Thanks!

Created at 2 months ago