[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

• ~~OWNERS~~ [yliaog]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/lgtm /approve

What happened (please include outputs or screenshots):

The watch stream method does not show past DELETED or MODIFIED events when the watch is restarted.

If watch.Watch.stream() is running during the event it shows, but if you restart it, out of the older event only ADDED shows. So we are seeing past events, but only of type ADDED.

What you expected to happen:

I expect the DELETED and MODIFIED events to show for events that occurred before the watch was started. This is the same behaviour as kubectl get events -w.

How to reproduce it (as minimally and precisely as possible):

from kubernetes import client, config, watch

config.load_kube_config()

custom_objects_api = client.CustomObjectsApi()

w = watch.Watch()

NAMESPACE = "ncdc-015197-sit"


API_VERSION = "v1beta1"
PLURAL = "bigquerydatasets"
GROUP = "bigquery.cnrm.cloud.google.com"


for event in w.stream(
    custom_objects_api.list_namespaced_custom_object,
    GROUP,
    API_VERSION,
    NAMESPACE,
    PLURAL,
):

    print(
        f"name: {event['object']['metadata']['name']} , type: {event['type']}")

    if event["type"] == "DELETED":
        print("DETECTED deleted")

Ran a short python script above titled test-events.py

I ran the script at 10:05 first opening the watch, then applying my custom resource, followed by deleting it. The ADDED, MODIFIED and DELETED events all show while the stream() is running.

reran the script at 10:06, only get the ADDED events from the past, not DELETED or MODIFIED. Contrast that to the behavior of kubectl get events -w, where I get all past events before streaming updates for new events.

reran the script at 10:15 and 10:16 to confirm the same behaviour again as above.

Anything else we need to know?:

Environment:

• Kubernetes version (kubectl version): server version is 1.23, git_version: v1.23.9-gke.2100
• OS (e.g., MacOS 10.13.6): MacOS Monterey v12.5.1
• Python version (python --version): 3.10.6
• Python client version (pip list | grep kubernetes): 23.3.0

Hi @brendandburns, any news on this? It would be great to have this released. Could I help with something? Thanks!

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stan-sz Once this PR has been reviewed and has the lgtm label, please ask for approval from tg123 by writing /assign @tg123 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/assign @tg123

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot] Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval by writing /assign @brendandburns in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Bumps Microsoft.NET.Test.Sdk from 17.3.1 to 17.3.2.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot] Once this PR has been reviewed and has the lgtm label, please assign tg123 for approval by writing /assign @tg123 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Bumps Microsoft.TestPlatform.ObjectModel from 17.3.1 to 17.3.2.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Fixes #1032

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stan-sz Once this PR has been reviewed and has the lgtm label, please assign tg123 for approval by writing /assign @tg123 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Support round-trip CRD (de)serialization

  Windows Server 2022 Standard

Originally posted by @mig0000 in https://github.com/kubernetes-client/csharp/discussions/1031#discussioncomment-3715572

Currently, the Yaml deserializer is configured to convert all property types to strings. After https://github.com/aaubry/YamlDotNet/pull/699, it is now possible to deserialize bools and decimals with their types.

E.g.

apiVersion: foo.bar/v1alpha
kind: Foo
metadata:
  name: foo
  namespace: ns
spec:
  bool: false
  byte: 123
  float: 12.3

A call to KubernetesYaml.Deserialize and KubernetesYaml.Serialize will emit:

apiVersion: foo.bar/v1alpha
kind: Foo
metadata:
  name: foo
  namespace: ns
spec:
  bool: "false"
  byte: "123"
  float: "12.3"

Bump junit-vintage-engine from 5.9.0 to 5.9.1

Bumps junit-vintage-engine from 5.9.0 to 5.9.1.

• Release notes
• Commits

updated-dependencies:

• dependency-name: org.junit.vintage:junit-vintage-engine dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Merge pull request #2383 from kubernetes-client/dependabot/maven/org.junit.vintage-junit-vintage-engine-5.9.1

Bump junit-vintage-engine from 5.9.0 to 5.9.1

Bumps junit-vintage-engine from 5.9.0 to 5.9.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

• ~~OWNERS~~ [yue9944882]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Automated openapi generation from release-1.25

Signed-off-by: Kubernetes Prow Robot k8s.ci.robot@gmail.com

Fixes needed for the new API version.

Fix formatting.

Merge pull request #2385 from brendandburns/automated-generate-0dc01494

Regenerate the API for Kubernetes 1.25

I didn't see a way to update the existing PR.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

• ~~OWNERS~~ [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale