kolyshkin
Repos
149
Followers
117
Following
7

Events

issue comment
runc create hangup reproduced with specific kernel patch (`epoll: autoremove wakers even more aggressively`)

The kernel commit in question (a16ceb13961068f7209e34d7984f8e42d2c06159) only appeared in kernel 6.0 (since -rc1), but the commit was also backported to all 5.x stable kernels (5.4, 5.10, 5.15), so I guess we'll see more of it.

Note also that Amazon Linux has reverted this commit in their kernels (see https://github.com/amazonlinux/linux/commit/e30a8cb3626b0d59a3bd251d491f010008c3eeab).

The issue was reported to Ubuntu here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1990190/comments/4 (although I'm not sure it's the right way to report).

Interestingly, I was able to repro this on Ubuntu 20.04 (kernel Ubuntu 5.4.0-132.148-generic 5.4.212) using a minimal repro from https://github.com/prometheus/node_exporter/issues/2500#issuecomment-1304847221 and go 1.19.3, but I am unable to repro this on a Fedora 37 beta kernel 6.0.7-301.fc37.x86_64 which definitely has this commit.

Created at 4 days ago
issue comment
runc checkpoint: destroy only on success

@thaJeztah PTAL (low handing fruit here)

Created at 1 week ago
issue comment
fix libcontainer example

@yzxiu can you please sign the commit with your real name and email?

Created at 1 week ago
issue comment
fix libcontainer example

Some history:

  1. Commit 677baf22d2481 moved DeviceRule (et al) from libcontainer/configs to libcontainers/devices package (leaving the backward compatibility)
  2. Commit 4fc2de77e993f86d41f3 renamed "DeviceRuletoRule` to avoid stuttering
  3. Commit 3f23a736cb28933 removed the backward compatibility earlier added in (1)

Neither of those touched libcontainer/README.md, and after (3) it is no longer valid.

Created at 1 week ago
pull request closed
[debug] add a bad comment

Checking if godot is working.

Created at 1 week ago
issue comment
[debug] add a bad comment

Ah, OK, everything works as intended, since by default godot is only checking comments next to declarations.

One possible way is to add something like

diff --git a/.golangci-extra.yml b/.golangci-extra.yml
index be33f90d..e4a5787f 100644
--- a/.golangci-extra.yml
+++ b/.golangci-extra.yml
@@ -13,3 +13,7 @@ linters:
   enable:
     - godot
     - revive
+
+linters-settings:
+  godot:
+    scope: all

OTOH it might be too much, so leaving it as-is for now.

Created at 1 week ago

[debug] ci: show git info

Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com

Created at 1 week ago
issue comment
[debug] add a bad comment

Hmm, as I suspected, lint-extra job is not working. Investigating.

Created at 1 week ago
issue comment
Add support for umask when exec container

this will support update umask when exec container @kolyshkin

Thanks! Need to fix a linter warning (please use gofumpt), and add a test case.

For the test case, something like this should work:

diff --git a/tests/integration/umask.bats b/tests/integration/umask.bats
index fe9f9d63..38e8f621 100644
--- a/tests/integration/umask.bats
+++ b/tests/integration/umask.bats
@@ -21,4 +21,9 @@ function teardown() {
        [ "$status" -eq 0 ]
        # umask 63 decimal = umask 77 octal
        [[ "${output}" == *"77"* ]]
+
+       runc exec test_busybox grep '^Umask:' "/proc/self/status"
+       [ "$status" -eq 0 ]
+       # umask 63 decimal = umask 77 octal
+       [[ "${output}" == *"77"* ]]
Created at 1 week ago