kenguest
Repos
73
Followers
48
Following
81

Makes communicating with the Open Street Map API, and Nominatim, from PHP intuitive.

186
51

Phing tasks for working with the Mercurial distributed version control system.

0
0

Phing Sass task that uses either gem installed sass or scssphp.

0
0

PHP Compatibility check for PHP_CodeSniffer

0
0

SemanticScuttle is a social bookmarking tool experimenting new features like structured tags and collaborative tag descriptions

0
0

Events

issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord's count method

@rob006 - thanks for the gentle nudge in the right direction.

One of the models had indeed been declared with "implements Countable", but did not have its own count method, which gave rise to the error I included in my earlier comment.

Once I removed "implements Countable", without the annotation in place on CActiveRecord's count method, the error didn't occur.

Sorry for taking up your time on this. :/

Created at 6 days ago
issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord class's count* methods

If I remove the ReturnTypeWillChange annotation which I added for the CActiveRecord::count method, the following error is displayed and logged to the application.log file: 2022/09/28 14:32:13 [error] [php] Return type of CActiveRecord::count($condition = '', $params = []) should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice (/var/www/project/vendor/yiisoft/yii/framework/yiilite.php:8684)

I've removed the ReturnTypeWillChagne annotation from the countByAttributes and countBySql methods, as it is only needed for the count method

Created at 6 days ago

Consistency. ReturntypeWillChange -> ReturnTypeWillChange

Only the count method requires a ReturnTypeWillChange annotation

Created at 6 days ago

Humidity automations for ensuite

Created at 1 week ago
issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord class's count* methods

@marcovtwout the fixes that addressed misusage of the framework have been reverted since my initial commit - what remains are still required for PHP 8.1 compatibility, especially the annotations I added for framework/db/ar/CActiveRecord.php

Created at 1 week ago

Add temperature sensors to list

Created at 1 week ago

Add a group for all downstairs lights

Tumble-dryer to turn off when finished.

Fix some notifications

Merge branch 'master' of github.com:kenguest/Home-Assistant-Config

Created at 1 week ago
issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord class's count* methods

In the case of CCache it's due to its implementing the ArrayAccess interface - used in the prime example in the documentation at https://php.watch/versions/8.1/ReturnTypeWillChange

Your PR does not add ReturnTypeWillChange to CCache.

True. That's because @marcovtwout added ReturnTypeWillChange to CCache. :-)

Created at 3 weeks ago
issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord class's count* methods

In the case of CCache it's due to its implementing the ArrayAccess interface - used in the prime example in the documentation at https://php.watch/versions/8.1/ReturnTypeWillChange

Do you need me to find you a demo project for you to encounter these issues yourself? :-)

Created at 3 weeks ago
issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord class's count* methods

In the case of CCache it's due to its implementing the ArrayAccess interface - used in the prime example in the documentation at https://php.watch/versions/8.1/ReturnTypeWillChange

Created at 3 weeks ago
issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord class's count* methods

@rob006 I've reverted the guard-checks re calling unserialize with null args for e.g. CSecurityManager::validateData. I was perhaps too free with adding them.

Going back to my adding ReturnTypeWillChange attributes - this is to fix issues such as what you can see here, without changing the signatures of those methods: Return type of CActiveRecord::count($condition = '', $params = []) should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice (/var/www/webdiarywd47/vendor/yiisoft/yii/framework/yiilite.php:8684

Created at 3 weeks ago

Revert guard checks re calling unserialize with possible null value in Security Manager related code.

Created at 3 weeks ago
issue comment
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange attribute to CActiveRecord class's count* methods

@kenguest Which interface requires the ReturnTypeWillChange additions? Also please check formatting (tabs instead of spaces)

CActiveRecord's count, countByAttributes, and countBySql methods required ReturnTypeWillChange annotations before I could run my app against PHP 8.1

Created at 1 month ago

Delete accidental copy/paste.

Created at 1 month ago

CS formatting

Created at 1 month ago
Created at 1 month ago
pull request opened
php8.1 changes - don't call unserialize with null, also add ReturnTypeWillChange to CActiveRecord class

| Q | A | ------------- | --- | Is bugfix? | ✔️ | New feature? | ❌ | Breaks BC? | ❌ | Tests pass? | ✔️ | Fixed issues | comma-separated list of tickets # fixed by the PR, if any

Created at 1 month ago

Add guard statements re calling unserialize with a null value as appropriate

Created at 1 month ago

Add ReturnTypeWillChange for php8.1 compatibility

Created at 1 month ago
create branch
kenguest create branch php8.1-changes
Created at 1 month ago
Created at 1 month ago

Fix #4279: PHP 7.4 compatibility: Drop use of accessing string offsets using curly braces

Fix accidental changelog removal

Update FUNDING.yml

Use stable PHP 7.4 on Travis

Migrate Travis from .org to .com

Fix badge [skip ci]

Update yiilite.php

Update CHtml phpdoc types (#4286) [skip ci]

Fix #4256: PHP 7 compatibility: Fixed deprecated usage of create_function() in markdown.php

release version 1.1.22

prepare for next release

Fix #4276: CDataColumn::value property doc must contain that if Active record, then ->{column_name}, if sqldataprovider then ['column_name'] (#4287) [skip ci]

Fix #4291: The scheme (protocol) is deleted when validateIDN is enabled after validation

Fix typos in Russian guide (#4295)

Add missing option to CActiveForm::$clientOptions [skip ci]

Add NGINX Unit config to quickstart.apache-nginx-config.txt (#4300)

Fix #4294: Add PostgreSQL 12 support

Fix CFileHelper::findFiles() to use correct directory separator under Windows

Handle ReflectionParameter::isArray() deprecation in PHP 8

Patch phpunit to work with modern PHP versions

Created at 1 month ago
Created at 1 month ago